(Aura Designer) Fix health bar tint indicator stale state and live settings update#62
Merged
DanderBot merged 1 commit intoMay 11, 2026
Conversation
…ttings update - Re-sync tint overlay StatusBarTexture on each apply in case the frame was recycled to a different unit (stale texture from previous member) - Reset overlay SetStatusBarColor(1,1,1,1) in RevertHealthBar so stale tint colour cannot bleed through on the next activation cycle - In tint mode, briefly release the AD colour lock before re-applying so UpdateHealthBarAppearance can restore the underlying bar to its normal class/custom colour; fixes mode switching not taking effect on live frames without toggling the aura - UpdateHealthBarAppearance now only skips normal colour logic in replace mode; tint mode lets class/percent/custom colour updates run normally so the underlying bar stays correct across health events and form shifts
Owner
|
Thanks for the PR! Merged into main and will ship in the next alpha build. |
DanderBot
added a commit
that referenced
this pull request
May 11, 2026
…king PR #60 conflicted with PR #62 on the replace-mode hbTex:SetVertexColor block; applied only the non-duplicate parts manually. The state.healthbarMode/R/G/B/Blend writes also fix a latent bug in already-merged PR #62 where adHealthBarMode was read but never written, making the live tint/replace switch gate always fail.
5 tasks
Krathe82
pushed a commit
to Krathe82/DandersFrames
that referenced
this pull request
Jun 6, 2026
…tale-state (Aura Designer) Fix health bar tint indicator stale state and live settings update
Krathe82
pushed a commit
to Krathe82/DandersFrames
that referenced
this pull request
Jun 6, 2026
Krathe82
pushed a commit
to Krathe82/DandersFrames
that referenced
this pull request
Jun 6, 2026
…bar* tracking PR DanderBot#60 conflicted with PR DanderBot#62 on the replace-mode hbTex:SetVertexColor block; applied only the non-duplicate parts manually. The state.healthbarMode/R/G/B/Blend writes also fix a latent bug in already-merged PR DanderBot#62 where adHealthBarMode was read but never written, making the live tint/replace switch gate always fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetOrCreateTintOverlaycaptures the health bar's StatusBarTexture at creation time. When a frame is recycled to a different party member the underlying texture can change, leaving the overlay showing a stale texture.ApplyHealthBarnow re-syncs the texture before eachShow().RevertHealthBarnow callsSetStatusBarColor(1,1,1,1)after hiding the overlay so stale tint from a previous unit cannot bleed through on the next activation cycle (bug 861).UpdateHealthBarAppearanceblocked all colour updates while the AD indicator was active (including tint mode, where the underlying bar colour should still be managed normally). The guard now only blocks colour in replace mode; tint mode lets class/percent/custom colour logic run as expected.Test plan