Skip to content

Added translation for edit button text#4521

Merged
Jag96 merged 1 commit into
Expensify:mainfrom
mananjadhav:fix/edit-button-i18n
Aug 10, 2021
Merged

Added translation for edit button text#4521
Jag96 merged 1 commit into
Expensify:mainfrom
mananjadhav:fix/edit-button-i18n

Conversation

@mananjadhav

@mananjadhav mananjadhav commented Aug 10, 2021

Copy link
Copy Markdown
Collaborator

Details

  • Added translations for edit button text

Fixed Issues

$ #4494

Tests

  1. Tested texts in both the languages - English and Spanish
  2. Verified the button texts, on language change

QA Steps

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

edit-button-text-eng-web
edit-button-text-esp-web

Mobile Web

edit-button-text-eng-mweb
edit-button-text-esp-mweb

Desktop

edit-button-text-eng-desktop
edit-button-text-esp-desktop

iOS

edit-button-text-esp-ios

edit-button-text-eng-ios

Android

edit-button-text-eng-android

edit-button-text-esp-android

@mananjadhav mananjadhav requested a review from a team as a code owner August 10, 2021 03:45
@MelvinBot MelvinBot requested review from Jag96 and removed request for a team August 10, 2021 03:45

@Jag96 Jag96 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jag96 Jag96 merged commit 002dc8a into Expensify:main Aug 10, 2021
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @Jag96 in version: 1.0.83-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@botify

botify commented Aug 17, 2021

Copy link
Copy Markdown

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-08-24. 🎊

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @isagoico in version: 1.0.85-9 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants