fix: update the report primary action for when an export fails by nkdengineer · Pull Request #72292 · Expensify/App

nkdengineer · 2025-10-10T07:32:52Z

Explanation of Change

Fixed Issues

$ #70101
PROPOSAL: #70101 (comment)

Tests

Create a new workspace with connect accounting
Submit an expense
Approve this expense
Try to export as accounting fails
Verify that: Primary action show the Export button instead of Pay button
Verify that: next step message should show Waiting for [preferredExporter] to export this report

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android.mov

iOS: Native

i.mov

iOS: mWeb Safari

im.mov

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-10-13T15:24:27Z

@dominictb Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

nkdengineer · 2025-10-20T09:23:05Z

backend is on staging

i'll add the screenshots today

codecov · 2025-10-22T10:01:45Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/components/MoneyReportHeader.tsx	`0.00% <ø> (ø)`
src/libs/ReportPreviewActionUtils.ts	`91.17% <100.00%> (+0.26%)`	⬆️
src/libs/ReportPrimaryActionUtils.ts	`90.61% <100.00%> (+0.13%)`	⬆️
src/libs/ReportSecondaryActionUtils.ts	`92.19% <100.00%> (-0.20%)`	⬇️
... and 25 files with indirect coverage changes

nkdengineer · 2025-10-22T10:16:26Z

@dominictb i added the screenshots but the next steps message is still updated as expected. Can you please check on your end?

dominictb · 2025-10-26T16:36:53Z

Yeah the next step message is not working for me.

It's Waiting for [someone] to pay expenses. for manual export action:

Waiting for [someone] to pay expenses. Report is queued to auto-sync with QuickBooks Online shortly. for auto export:

(screenshot from @nkdengineer)

cc @dangrous Can you check if it's working on your side?

dangrous · 2025-10-27T16:59:00Z

Oh weird, it was working before? Here are the test steps I was using (and QA used) on the backend change -

Create a workspace with a connection to NetSuite or other external platform
Create, submit, and approve a report
Wait for the report to export successfully to NetSuite/the connection
Ensure the next step is waiting for [admin] to pay expenses
Try again but change the configuration of the report / connection as needed to ensure a failed export (mismatched currencies usually works)
Wait for the report failure message
Ensure the next step is waiting for [preferredExporter] to export this report.

Does that differ in a relevant way from the testing here?

dominictb · 2025-10-27T17:12:04Z

@dangrous Here's my test steps:

Create a workspace with a connection to NetSuite or other external platform
Create, submit, and approve a report
Either:
- Wait for the report to export automatically; or
- Manually trigger export from secondary actions menu
The export fails but next step message is still Waiting for [someone] to pay expenses.

So it's different from your test steps because it failed right from the first place. I expect that whenever export failed, we should show the Waiting for export next step, correct?

dangrous · 2025-10-27T17:56:58Z

oh okay i think i see what's happening here - so if you refresh the page with your report, does it hten show the export message?

We don't send an Onyx update with the new next step when the export fails, but if you leave and come back it should be the updated message. That's what I'm seeing, at least

dominictb · 2025-10-29T12:49:06Z

if you leave and come back it should be the updated message

@dangrous It's not working either:

Screen.Recording.2025-10-29.at.19.48.38.mov

dangrous · 2025-10-29T16:49:20Z

if you leave and come back it should be the updated message

@dangrous It's not working either:

Screen.Recording.2025-10-29.at.19.48.38.mov

That's odd! on staging it's working for me...

nkdengineer · 2025-10-29T16:49:30Z

@dominictb Updated.

dominictb · 2025-10-29T19:20:59Z

@dangrous I noticed that it only works when the report is auto sync. If I manually export before auto sync, the message won't show.

dangrous · 2025-10-30T15:44:59Z

oh interesting, I must have missed a condition somewhere. Let me try to repro and get an update out there if I can figure it out!

dangrous · 2025-11-19T17:32:40Z

It should be set! Feel free to test again and if we're still seeing issues let me know

dominictb · 2025-11-24T11:26:55Z

Thanks! The next step message is correct now:

dominictb · 2025-11-24T11:27:13Z

However, after successfully exporting the report, report.isExportedToIntegration is still false:

The report did get exported to Intacct:

@dangrous Can you help us to quick check why? I don't see this property being handled in the FE, read only.

dominictb · 2025-12-01T02:06:56Z

@dangrous Can you share the progress of checking ☝️ bug?

dangrous · 2025-12-01T17:46:50Z

So sorry, I missed this! Looking now

dangrous · 2025-12-01T22:31:07Z

Sorry for the delay, I've put into review a backend PR that should fix this issue!

dominictb · 2025-12-02T02:15:21Z

Thank you for the prompt work. Let us know when it's ready for retesting.

dominictb · 2025-12-11T02:22:52Z

@dangrous Can you let us know if the BE PR had been deployed to prod?

dangrous · 2025-12-11T18:03:02Z

augh so sorry @dominictb - yes, BE fix is on prod! I did not follow up on this, apologies

dominictb · 2025-12-16T17:05:15Z

@nkdengineer Can you resolve conflicts and retest?

dominictb · 2025-12-16T17:10:51Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

Simulator Screenshot - iPhone 16e - 2025-12-17 at 00 45 39

iOS: mWeb Safari

MacOS: Chrome / Safari

dominictb · 2025-12-16T17:31:26Z

@dangrous Not sure if this is expected behavior:

Submit then Approve the report
Manually Export the report via secondary menu
Export was successful
Next step message shows Waiting for you to pay expenses. Report is queued to auto-sync with Intacct shortly. even though it has already been exported. I think Waiting for you to pay expenses. alone is enough but not 100% sure.

dominictb · 2025-12-16T18:01:56Z

@nkdengineer

BUG: Report preview shows Pay button but report header shows Export to primary action

Screen.Recording.2025-12-17.at.01.00.21.mov

I can add your test account to this report to help with debugging because you don't have access to Sage Intacct.

nkdengineer · 2025-12-18T03:12:12Z

BUG: Report preview shows Pay button but report header shows Export to primary action

@dominictb I updated.

dominictb

🎀

dangrous · 2025-12-18T18:47:09Z

@dangrous Not sure if this is expected behavior:

Submit then Approve the report

Manually Export the report via secondary menu

Export was successful

Next step message shows Waiting for you to pay expenses. Report is queued to auto-sync with Intacct shortly. even though it has already been exported. I think Waiting for you to pay expenses. alone is enough but not 100% sure.

So sorry I missed this; I believe this IS correct coz export is different from sync? At least, it seemed like it had similar behavior before this. Will review and merge this shortly!

dangrous

LGTM!

OSBotify · 2025-12-19T23:58:45Z

🚀 Deployed to staging by https://github.com/dangrous in version: 9.2.85-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-23T00:32:09Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.85-7 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Krishna2323 · 2026-05-22T01:28:22Z

    const isReportApproved = isReportApprovedUtils({report});
    const isReportClosed = isClosedReportUtils(report);
    const isProcessingReport = isProcessingReportUtils(report);
+    const isExported = isExportedUtil(reportActions);


This introduced #87654. isExportedUtil(reportActions) is called without report, so it falls back to scanning report actions instead of reading report.isExportedToIntegration. After a failed export, the optimistic action persists, making isExported incorrectly return true and showing Pay instead of Export. Fixed in #90154.

fix: update the report primary action for when an export fails

6bb78ee

melvin-bot Bot assigned nkdengineer Oct 10, 2025

Merge branch 'main' into fix/70101

cd89410

nkdengineer marked this pull request as ready for review October 13, 2025 15:24

nkdengineer requested a review from a team as a code owner October 13, 2025 15:24

melvin-bot Bot requested review from dominictb and removed request for a team October 13, 2025 15:24

nkdengineer changed the title ~~fix: update the report primary action for when an export fails~~ [HOLD BE] fix: update the report primary action for when an export fails Oct 13, 2025

This comment was marked as outdated.

Sign in to view

nkdengineer changed the title ~~[HOLD BE] fix: update the report primary action for when an export fails~~ fix: update the report primary action for when an export fails Oct 20, 2025

Merge branch 'main' into fix/70101

2959099

Merge branch 'main' into fix/70101

ce021be

Add right icon to pay option

804d1b0

dominictb suggested changes Oct 29, 2025

View reviewed changes

Comment thread src/libs/ReportPrimaryActionUtils.ts Outdated

Comment thread src/libs/ReportPrimaryActionUtils.ts Outdated

nkdengineer added 2 commits October 29, 2025 23:45

Merge branch 'main' into fix/70101

0446edc

rename variable

c99179a

fix prettier

464f61d

resolve conflict

2bcd8be

nkdengineer dismissed heyjennahay’s stale review via 2bcd8be November 20, 2025 10:01

nkdengineer added 2 commits December 17, 2025 12:22

resolve conflict

580fa61

update report preview

72a5500

Merge branch 'main' into fix/70101

fa7341a

dominictb approved these changes Dec 18, 2025

View reviewed changes

melvin-bot Bot requested a review from dangrous December 18, 2025 17:37

dangrous approved these changes Dec 18, 2025

View reviewed changes

dangrous merged commit 2e4ad09 into Expensify:main Dec 18, 2025
30 of 31 checks passed

OSBotify mentioned this pull request Dec 19, 2025

Deploy Checklist: New Expensify 2025-12-19 #78170

Closed

87 tasks

melvin-bot Bot mentioned this pull request Dec 23, 2025

[Due for payment 2025-12-30] [$250] Update the report primary action for when an export fails #70101

Closed

Krishna2323 reviewed May 22, 2026

View reviewed changes

Krishna2323 mentioned this pull request May 22, 2026

[Due for payment 2026-05-28] [$250] IOU - The primary action shows pay button instead of Export #87654

Closed

7 tasks

Conversation

nkdengineer commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Oct 13, 2025

Uh oh!

This comment was marked as outdated.

nkdengineer commented Oct 20, 2025

Uh oh!

codecov Bot commented Oct 22, 2025 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nkdengineer commented Oct 22, 2025

Uh oh!

dominictb commented Oct 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dangrous commented Oct 27, 2025

Uh oh!

dominictb commented Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dangrous commented Oct 27, 2025

Uh oh!

dominictb commented Oct 29, 2025

Uh oh!

Uh oh!

Uh oh!

dangrous commented Oct 29, 2025

Uh oh!

nkdengineer commented Oct 29, 2025

Uh oh!

dominictb commented Oct 29, 2025

Uh oh!

dangrous commented Oct 30, 2025

Uh oh!

dangrous commented Nov 19, 2025

Uh oh!

dominictb commented Nov 24, 2025

Uh oh!

dominictb commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dominictb commented Dec 1, 2025

Uh oh!

dangrous commented Dec 1, 2025

Uh oh!

dangrous commented Dec 1, 2025

Uh oh!

dominictb commented Dec 2, 2025

Uh oh!

dominictb commented Dec 11, 2025

Uh oh!

dangrous commented Dec 11, 2025

Uh oh!

dominictb commented Dec 16, 2025

Uh oh!

dominictb commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

dominictb commented Dec 16, 2025

Uh oh!

dominictb commented Dec 16, 2025

Uh oh!

nkdengineer commented Dec 18, 2025

Uh oh!

dominictb left a comment

Choose a reason for hiding this comment

Uh oh!

dangrous commented Dec 18, 2025

nkdengineer commented Oct 10, 2025 •

edited

Loading

codecov Bot commented Oct 22, 2025 •

edited by github-actions Bot

Loading

dominictb commented Oct 26, 2025 •

edited

Loading

dominictb commented Oct 27, 2025 •

edited

Loading

dominictb commented Nov 24, 2025 •

edited

Loading

dominictb commented Dec 16, 2025 •

edited

Loading