-
Notifications
You must be signed in to change notification settings - Fork 3.9k
fix: update the report primary action for when an export fails #72292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+28
−6
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
6bb78ee
fix: update the report primary action for when an export fails
nkdengineer cd89410
Merge branch 'main' into fix/70101
nkdengineer 2959099
Merge branch 'main' into fix/70101
nkdengineer ce021be
Merge branch 'main' into fix/70101
nkdengineer 804d1b0
Add right icon to pay option
nkdengineer 0446edc
Merge branch 'main' into fix/70101
nkdengineer c99179a
rename variable
nkdengineer 464f61d
fix prettier
nkdengineer 71a51d9
Merge branch 'main' into fix/70101
nkdengineer 5cb1a3d
resolve conflict
nkdengineer 7f0e624
Merge branch 'main' into fix/70101
nkdengineer 2bcd8be
resolve conflict
nkdengineer 580fa61
resolve conflict
nkdengineer 72a5500
update report preview
nkdengineer fa7341a
Merge branch 'main' into fix/70101
nkdengineer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This introduced #87654.
isExportedUtil(reportActions)is called without report, so it falls back to scanning report actions instead of readingreport.isExportedToIntegration. After a failed export, the optimistic action persists, makingisExportedincorrectly return true and showing Pay instead of Export. Fixed in #90154.