Skip to content

[CP Staging] Revert "Expo-av to expo-video migration"#75219

Merged
mountiny merged 1 commit into
mainfrom
revert-66793-Guccio163/expo-video
Nov 16, 2025
Merged

[CP Staging] Revert "Expo-av to expo-video migration"#75219
mountiny merged 1 commit into
mainfrom
revert-66793-Guccio163/expo-video

Conversation

@cristipaval

@cristipaval cristipaval commented Nov 14, 2025 •
edited by mountiny
Loading

Copy link
Copy Markdown
Contributor

Reverts #66793

Reverts the PR because it introduces a new sensitive permission in AndroidManifest that needs to be declared and Google Play rejects when fastlane uploads the builds.

### Fixed issues

$ #75203
$ #75206
$ #75207
$ #75212
$ #75214
$ #75215
$ #75216
$ #75234

@cristipaval cristipaval requested review from a team as code owners November 14, 2025 23:31
@melvin-bot melvin-bot Bot requested review from trjExpensify and removed request for a team November 14, 2025 23:31
@melvin-bot

melvin-bot Bot commented Nov 14, 2025

Copy link
Copy Markdown

Hey, I noticed you changed some webpack configuration files. This can break production builds. Did you remember to run a production build locally to verify they still work?

@melvin-bot melvin-bot Bot requested a review from MonilBhavsar November 14, 2025 23:32
@melvin-bot

melvin-bot Bot commented Nov 14, 2025

Copy link
Copy Markdown

@MonilBhavsar Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot removed the request for review from a team November 14, 2025 23:32
@cristipaval cristipaval changed the title Revert "Expo-av to expo-video migration" [CP Staging] Revert "Expo-av to expo-video migration" Nov 14, 2025
@codecov

codecov Bot commented Nov 14, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/components/FullscreenLoadingIndicator.tsx 91.66% <100.00%> (ø)
src/components/VideoPlayer/index.native.tsx 100.00% <ø> (ø)
src/components/VideoPlayer/index.tsx 0.00% <ø> (ø)
...ts/VideoPlayerContexts/VideoPopoverMenuContext.tsx 90.00% <100.00%> (+3.63%) ⬆️
...c/components/VideoPlayerContexts/VolumeContext.tsx 78.57% <ø> (ø)
...rc/components/Attachments/AttachmentView/index.tsx 50.00% <0.00%> (-0.58%) ⬇️
...mponents/VideoPlayer/VideoPlayerControls/index.tsx 4.76% <0.00%> (+0.21%) ⬆️
.../VideoPlayer/useHandleNativeVideoControls/index.ts 0.00% <0.00%> (ø)
...ents/VideoPlayerContexts/PlaybackContext/index.tsx 88.46% <50.00%> (-3.85%) ⬇️
src/components/VideoPlayerPreview/index.tsx 11.76% <0.00%> (+0.65%) ⬆️
... and 9 more
... and 9 files with indirect coverage changes

@Guccio163

Guccio163 commented Nov 16, 2025

Copy link
Copy Markdown
Contributor

Hi, is it about android.permission.FOREGROUND_SERVICE or android.permission.FOREGROUND_SERVICE_MEDIA_PLAYBACK?

@Guccio163 Guccio163 mentioned this pull request Nov 16, 2025
Merged
84 tasks
mountiny
mountiny approved these changes Nov 16, 2025
View reviewed changes

@mountiny mountiny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straight revert

@mountiny mountiny merged commit 930127c into main Nov 16, 2025
37 of 42 checks passed
@mountiny mountiny deleted the revert-66793-Guccio163/expo-video branch November 16, 2025 19:58
@melvin-bot melvin-bot Bot added the Emergency label Nov 16, 2025
@melvin-bot

melvin-bot Bot commented Nov 16, 2025

Copy link
Copy Markdown

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@mountiny

mountiny commented Nov 16, 2025

Copy link
Copy Markdown
Contributor

Straight revert

OSBotify pushed a commit that referenced this pull request Nov 16, 2025
@mountiny @OSBotify
Merge pull request #75219 from Expensify/revert-66793-Guccio163/expo-…
ebcef15 
…video

[CP Staging] Revert "Expo-av to expo-video migration"

(cherry picked from commit 930127c)

(cherry-picked to staging by mountiny)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Nov 16, 2025
@OSBotify OSBotify mentioned this pull request Nov 16, 2025
Closed
69 tasks
@OSBotify

OSBotify commented Nov 16, 2025

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

OSBotify commented Nov 16, 2025

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.2.59-1 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Guccio163 added a commit to software-mansion-labs/expensify-app-fork that referenced this pull request Nov 16, 2025
@Guccio163
Revert "Merge pull request Expensify#75219 from Expensify/revert-6679…
66273c1 
…3-Guccio163/expo-video"

This reverts commit 930127c, reversing
changes made to 3efe8a0.
This was referenced Nov 16, 2025
Closed
Closed
This was referenced Nov 16, 2025
Closed
Closed
Closed
Closed
Closed
Closed
@OSBotify

OSBotify commented Nov 18, 2025

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.2.60-0 🚀

platform result
🖥 desktop 🖥 failure ❌
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Nov 18, 2025

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.2.60-0 🚀

platform result
🖥 desktop 🖥 failure ❌
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Nov 18, 2025

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.2.60-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Nov 19, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/grgia in version: 9.2.59-5 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 failure ❌

@OSBotify

OSBotify commented Nov 19, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/grgia in version: 9.2.60-2 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

This was referenced Nov 24, 2025
Open
Open
@nyomanjyotisa nyomanjyotisa mentioned this pull request Nov 26, 2025
Closed
54 tasks
@OSBotify OSBotify mentioned this pull request Jan 27, 2026
Closed
70 tasks
@IuliiaHerets

IuliiaHerets commented Jan 27, 2026 •
edited
Loading

Copy link
Copy Markdown

@cristipaval or @mountiny, I believe that there is no need to test it. CP was deployed earlier. Am I right?

@OSBotify

OSBotify commented Jan 27, 2026

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.3.10-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@mountiny

mountiny commented Jan 27, 2026

Copy link
Copy Markdown
Contributor

This is old PR

@OSBotify

OSBotify commented Jan 28, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.10-6 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Julesssss Julesssss Julesssss approved these changes

@mountiny mountiny mountiny approved these changes

@trjExpensify trjExpensify Awaiting requested review from trjExpensify

@MonilBhavsar MonilBhavsar Awaiting requested review from MonilBhavsar

Assignees

@cristipaval cristipaval

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@cristipaval @Guccio163 @mountiny @OSBotify @IuliiaHerets @Julesssss