[Bulk workspace edits] Add Copy Policy Settings select-workspaces page (step 1 of 3) by fedirjh · Pull Request #90079 · Expensify/App

fedirjh · 2026-05-08T20:47:03Z

Explanation of Change

Adds the entry point and the first RHP step of the new "Copy settings" flow that's part of the Bulk workspace edits project. This is task 3 of the project — task 1 (scaffold #89959) is merged; task 2 (action layer #89963) is still open and this PR is stacked on top of #89963. Please land #89963 first.

What this PR adds

Three-dot menu entry in src/pages/workspace/WorkspacesListPage.tsx — a new "Copy settings" item with the Gear icon next to "Duplicate Workspace", visible only for admins (existing isAdmin guard). Navigates to ROUTES.POLICY_COPY_SETTINGS.
Select Workspaces page in src/pages/workspace/copyPolicySettings/CopyPolicySettingsSelectWorkspacesPage.tsx — first step of the RHP flow. Renders a SelectionList with MultiSelectListItem of policies the current user is admin of, with the eligibility rules from the design doc:
- Excludes the source policy
- Excludes policies where the user is not admin and personal policies
- When the source is CORPORATE, only CORPORATE targets are shown (Release 1 restriction; Issue 7 lifts this in R2 with an upgrade step)
Layout:
- Select-all <Checkbox> above the list (indeterminate when partial)
- <SearchBar> appears only when there are more than 12 eligible workspaces
- "Next" persists targetPolicyIDs via setCopyPolicySettingsData (introduced in [No QA] [Bulk workspace edits] Add CopyPolicySettings action file and tests #89963) and navigates to POLICY_COPY_SETTINGS_SELECT_FEATURES; disabled until at least one workspace is selected
Translations — new workspace.copySettings.{title, selectWorkspaces, whichWorkspaces, searchPlaceholder, selectAll} block in all 10 language files.
Sentry label — CONST.SENTRY_LABEL.WORKSPACE.COPY_SETTINGS_SELECT_WORKSPACES_SELECT_ALL for the select-all pressable.

The page reads its persisted state (targetPolicyIDs) directly from ONYXKEYS.COPY_POLICY_SETTINGS so re-entry restores the user's previous selection.

Fixed Issues

$ #88669
PROPOSAL: N/A

Tests

Setup

Sign in as an admin on at least two non-personal workspaces (a mix of Team/Collect and Corporate/Control if possible).

Test 1 — Three-dot menu entry

Open the Workspaces list.
Click the three-dot menu on a workspace where you're admin.
Verify a new "Copy settings" item appears next to "Duplicate Workspace".
Verify "Copy settings" uses the Copy/duplicate icon and "Duplicate Workspace" uses the Plus icon.
Verify the item is not present on a workspace where you're not admin (or on personal workspaces).
Click "Copy settings" → the RHP slides open with the "Select workspaces" step.

Test 2 — Eligibility filtering

From a Corporate (Control) workspace, open Copy settings.
Verify the list excludes the source workspace.
Verify the list excludes any policy where you're not admin.
Verify the list excludes any personal policy.
Verify only other Corporate workspaces appear (Team workspaces are filtered out).
Go back, repeat from a Team (Collect) workspace.
Verify both Team and Corporate workspaces appear in the list.

Test 3 — Workspace avatars

Open Copy settings.
Verify each row shows the workspace avatar at the standard list-row size (not a tiny icon).
For workspaces without an avatarURL, verify the default workspace avatar (initials/colored placeholder) is rendered.

Test 4 — Select-all alignment and behavior

Open Copy settings.
Verify the select-all checkbox sits on the right of its header row, aligned with the per-row checkboxes below it.
Tap two rows — verify the select-all shows the indeterminate state.
Tap the remaining rows — verify the select-all becomes fully checked.
Tap the select-all checkbox — verify all rows clear.
Tap the select-all label/checkbox again — verify all rows toggle on.

Test 5 — Search

Open Copy settings on an account with 12 or fewer eligible workspaces.
Verify no search input is shown.
Open Copy settings on an account with more than 12 eligible workspaces.
Verify a search input appears above the select-all header (search → select-all → rows order).
Type part of a workspace name — verify the list filters case-insensitively.
Type a string that matches nothing — verify the empty state ("No results found") is shown.
Clear the input — verify the full list returns.

Test 6 — Next / commit selection

Open Copy settings.
With no rows selected, verify the "Next" button is disabled.
Select one or more rows — verify "Next" becomes enabled.
Click "Next" — verify the flow advances to the Select Features step (currently a stub page from this PR's scaffold).
In dev tools / Onyx console, verify copyPolicySettings.targetPolicyIDs now contains the selected IDs and copyPolicySettings.sourcePolicyID is set.

Test 7 — Selection cleared on RHP close

Open Copy settings, select 2–3 workspaces.
Close the RHP via the X / back button without clicking "Next".
Re-open Copy settings from the three-dot menu.
Verify the previous selection is not restored (selection is empty, "Next" disabled).

Test 8 — Console

Verify that no errors appear in the JS console while running tests 1–7.

Offline tests

The page is a pure read of ONYXKEYS.COLLECTION.POLICY plus a useState selection; the only Onyx write happens at "Next" via setCopyPolicySettingsData. Both should work fully offline:

Toggle off network connectivity.
From the three-dot menu open Copy settings → the page renders with the cached policies, eligibility filtering still works.
Toggle rows / select-all → state updates instantly.
Click "Next" → the flow advances; verify copyPolicySettings.targetPolicyIDs is written to Onyx even while offline.
Re-enable network — no redundant writes are queued (selection wasn't being persisted on every toggle).

QA Steps

Same as Tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Adds title, selectWorkspaces, whichWorkspaces, searchPlaceholder, and selectAll keys for the new "Copy settings" RHP flow's first step, across all ten language files.

Adds a new "Copy settings" item next to "Duplicate Workspace" in the admin three-dot menu on WorkspacesListPage. Uses the Gear icon and navigates to ROUTES.POLICY_COPY_SETTINGS, the first step of the new RHP flow. Visible only for admins (existing isAdmin guard).

First RHP step of the bulk Copy Policy Settings flow. Renders a SelectionList with MultiSelectListItem of policies the current user is admin of, excluding: - the source policy - personal policies - policies where the user is not admin - when the source is Corporate, non-Corporate targets (Release 1 restriction; Issue 7 lifts this with an upgrade step) Layout follows the design doc: - select-all Checkbox above the list (indeterminate when partial) - SearchBar appears only when there are more than 12 eligible workspaces - "Next" persists targetPolicyIDs through setCopyPolicySettingsData and routes to POLICY_COPY_SETTINGS_SELECT_FEATURES; disabled until at least one workspace is selected Adds CONST.SENTRY_LABEL.WORKSPACE.COPY_SETTINGS_SELECT_WORKSPACES_SELECT_ALL for the select-all pressable.

melvin-bot · 2026-05-08T20:47:08Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

codecov · 2026-05-08T20:56:18Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/SelectionList/BaseSelectionList.tsx	`67.20% <ø> (ø)`
...components/SelectionList/components/ListHeader.tsx	`85.71% <87.50%> (+2.38%)`	⬆️
src/pages/workspace/WorkspacesListPage.tsx	`72.95% <87.50%> (+0.77%)`	⬆️
...ettings/CopyPolicySettingsSelectWorkspacesPage.tsx	`0.00% <0.00%> (ø)`
... and 8 files with indirect coverage changes

Per review on PR Expensify#90079: use the Plus icon for "Duplicate workspace" and the Copy (duplicate) icon for "Copy settings", to better match each item's intent.

Per review on PR Expensify#90079: MultiSelectListItem renders its checkbox on the right side, so move the select-all Checkbox to the right of the header row (label on the left, checkbox on the right) so they line up with the per-row checkboxes below.

Drops the separate SearchBar component above the list in favour of SelectionList's built-in textInputOptions, which matches the search field used in the New Chat / start chat flow at /new/chat. The built-in input owns its own margin/padding so the design is consistent across the app. The "more than 12 eligible workspaces" gate is preserved by toggling shouldShowTextInput.

The built-in select-all header always rendered its checkbox on the left, which misaligned with lists whose per-row checkboxes use selectionButtonPosition=RIGHT (e.g. MultiSelectListItem). Adds a selectionButtonPosition prop to ListHeader (default LEFT for existing callers) and threads it from BaseSelectionList. When set to RIGHT, the label/checkbox order is swapped and the row uses justifyContentBetween so the checkbox sits flush right, matching the list rows below.

Three review fixes on the Select Workspaces page: - Use SelectionList's built-in onSelectAll with selectionButtonPosition=RIGHT, so the search input sits above the select-all header and the select-all checkbox lines up with the per-row checkboxes (both on the right). Drops the custom select-all header that used to sit above the SelectionList. - Render the workspace avatar at AVATAR_SIZE.DEFAULT via a leftElement on each list item. The previous icons-based path inside MultiSelectListItem hardcodes AVATAR_SIZE.SMALLER, which looked too small. Falls back to getDefaultWorkspaceAvatar when avatarURL is missing. - Track selectedTargetIDs in local useState instead of writing to COPY_POLICY_SETTINGS on every toggle. The Onyx key is now updated only when the user confirms "Next", so closing the RHP mid-flow naturally drops the in-progress selection without needing a manual clear-on-mount.

The page now uses SelectionList's built-in select-all header, which already reuses workspace.people.selectAll for its label and SENTRY_LABEL.SELECTION_LIST.LIST_HEADER_SELECT_ALL for its pressable. The custom workspace.copySettings.selectAll key (10 language files) and SENTRY_LABEL.WORKSPACE.COPY_SETTINGS_SELECT_WORKSPACES_SELECT_ALL are no longer referenced — remove them.

melvin-bot · 2026-05-11T11:51:04Z

@dmkt9 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5f2d85f6fb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Consolidates the two translation namespaces for the bulk Copy Policy Settings flow into a single workspace.copyPolicySettings block (next to the existing error key). Renames whichWorkspaces to description and updates the copy to: "Choose the workspaces you want to copy settings to, then select the settings you'd like to copy." Localizes the new description across all ten language files.

Updates the three-dot menu entry and the Select Workspaces page to read from workspace.copyPolicySettings.* now that the translation block was merged. Also swaps the page subheader to the renamed description key.

When search was active, toggleAll decided whether to clear or select against eligiblePolicies (the full unfiltered set) while SelectionList's header checkbox state was derived from filteredPolicies (the visible rows). That mismatch let the header appear checked yet pressing it would select additional hidden workspaces — copying settings to unintended targets. Scope select-all to the visible filtered rows: when every visible row is already selected, deselect just those; otherwise add the visible rows to the existing selection, preserving selections on rows hidden by the active search. Resolves Expensify#90079 (comment)

dmkt9 · 2026-05-12T13:44:31Z

If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

Could you add the link to the Slack message that approved the translation?

francoisl · 2026-05-20T00:16:14Z

Typecheck and Jest seem to be repeatedly failing

fedirjh · 2026-05-20T08:21:16Z

Could you add the link to the Slack message that approved the translation?

@dmkt9 Please check https://expensify.slack.com/archives/C01GTK53T8Q/p1778753210690539

dmkt9 · 2026-05-20T09:25:45Z

Could you add the link to the Slack message that approved the translation?

@dmkt9 Please check expensify.slack.com/archives/C01GTK53T8Q/p1778753210690539

Ah, thank you.

francoisl · 2026-05-21T01:27:14Z

@dmkt9 any chance you can review this today you think?

dmkt9 · 2026-05-21T01:29:05Z

@dmkt9 any chance you can review this today you think?

Yes. I will review this today.

dmkt9 · 2026-05-21T07:56:48Z

@codex review

chatgpt-codex-connector · 2026-05-21T08:06:01Z

Codex Review: Didn't find any major issues. Bravo.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

dmkt9 · 2026-05-21T08:48:37Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android.hybrid.mp4

Android: mWeb Chrome

android.chrome.mp4

iOS: HybridApp

ios.hybrid.mp4

iOS: mWeb Safari

ios.safari.mp4

MacOS: Chrome / Safari

mac.safari.mp4

dmkt9 · 2026-05-21T08:14:56Z

+            threeDotsMenuItems.push({
+                icon: icons.Copy,
+                text: translate('workspace.copyPolicySettings.title'),
+                onSelected: () => (item.policyID ? Navigation.navigate(ROUTES.POLICY_COPY_SETTINGS.getRoute(item.policyID)) : undefined),
+            });


This item will be rendered when isAdmin == true. If there is no other eligible workspace, this item will still display and open an empty list modal.
I am not sure whether this is a bug, since in the "Explanation of changes", we only refer to "isAdmin" as a guard:

Three-dot menu entry in src/pages/workspace/WorkspacesListPage.tsx — a new "Copy settings" item with the Gear icon next to "Duplicate Workspace", visible only for admins (existing isAdmin guard). Navigates to ROUTES.POLICY_COPY_SETTINGS.

This makes sense; I think we should hide the item in that case. Will push a fix for it. cc @francoisl for visibility.

Done in 942a7fc

Precomputes eligible target policy IDs via useMemo so the per-item menu render does a constant-time check instead of iterating all policies. Hides the menu entry entirely when there are no valid targets for the source workspace.

dmkt9

LGTM

github-actions · 2026-05-21T18:45:55Z

🚧 @francoisl has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-05-21T18:50:24Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #90079.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-daf2f6b-fdf8a2c-5e7c0434144e798272a0ed8d1325b8e7651cca29/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-daf2f6b-fdf8a2c-aa8900a6f1265a5b311c560613bdf2f375c98d72/index.html

Web 🕸️
https://90079.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-05-21T18:54:42Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-05-21T21:49:58Z

🚀 Deployed to staging by https://github.com/francoisl in version: 9.3.79-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

jponikarchuk · 2026-05-22T03:33:56Z

Deploy Blocker #91381 was identified to be related to this PR.

jponikarchuk · 2026-05-22T05:26:26Z

Deploy Blocker #91389 was identified to be related to this PR.

OSBotify · 2026-05-22T22:23:53Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.79-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fedirjh added 3 commits May 8, 2026 21:26

Add workspace.copySettings translation block

0fd5e18

Adds title, selectWorkspaces, whichWorkspaces, searchPlaceholder, and selectAll keys for the new "Copy settings" RHP flow's first step, across all ten language files.

melvin-bot Bot assigned fedirjh May 8, 2026

fedirjh changed the title ~~Add Copy Policy Settings select-workspaces page (step 1 of 3)~~ [Hold App/89963] [Bulk workspace edits] Add Copy Policy Settings select-workspaces page (step 1 of 3) May 8, 2026

fedirjh added 7 commits May 8, 2026 22:11

Address review: swap Duplicate/Copy menu icons

8e76652

Per review on PR Expensify#90079: use the Plus icon for "Duplicate workspace" and the Copy (duplicate) icon for "Copy settings", to better match each item's intent.

Merge branch 'Expensify:main' into copy-policy-settings-page-1

726b296

fedirjh requested a review from francoisl May 11, 2026 11:50

Merge branch 'Expensify:main' into copy-policy-settings-page-1

5f2d85f

fedirjh marked this pull request as ready for review May 11, 2026 11:50

fedirjh requested review from a team as code owners May 11, 2026 11:50

melvin-bot Bot requested review from dmkt9 and joekaufmanexpensify and removed request for a team May 11, 2026 11:51

melvin-bot Bot removed the request for review from a team May 11, 2026 11:51

chatgpt-codex-connector Bot reviewed May 11, 2026

View reviewed changes

Comment thread src/pages/workspace/copyPolicySettings/CopyPolicySettingsSelectWorkspacesPage.tsx Outdated

fedirjh added 3 commits May 11, 2026 13:17

Repoint Copy Settings UI to consolidated translation keys

2cb71bc

Updates the three-dot menu entry and the Select Workspaces page to read from workspace.copyPolicySettings.* now that the translation block was merged. Also swaps the page subheader to the renamed description key.

fedirjh mentioned this pull request May 11, 2026

[Bulk workspace edits] Add Copy Policy Settings select-features page (step 2 of 3) #90220

Merged

52 tasks

fedirjh changed the title ~~[Hold App/89963] [Bulk workspace edits] Add Copy Policy Settings select-workspaces page (step 1 of 3)~~ [Bulk workspace edits] Add Copy Policy Settings select-workspaces page (step 1 of 3) May 19, 2026

fedirjh added 2 commits May 20, 2026 08:39

Merge remote-tracking branch 'upstream' into copy-policy-settings-page-1

c051272

feat(i18n): add copy policy settings page translations

b9fd1de

dmkt9 reviewed May 21, 2026

View reviewed changes

fedirjh added 2 commits May 21, 2026 11:14

Merge branch 'Expensify:main' into copy-policy-settings-page-1

86223f1

fedirjh requested a review from dmkt9 May 21, 2026 10:42

dmkt9 approved these changes May 21, 2026

View reviewed changes

francoisl approved these changes May 21, 2026

View reviewed changes

francoisl merged commit daf2f6b into Expensify:main May 21, 2026
43 checks passed

fedirjh deleted the copy-policy-settings-page-1 branch May 21, 2026 18:50

OSBotify mentioned this pull request May 21, 2026

Deploy Checklist: New Expensify 2026-05-21 #91350

Closed

applause-bot Bot mentioned this pull request May 22, 2026

[Due for payment 2026-06-01] Workspaces - "Select All" checkbox not aligned with remaining checkboxes on "Copy Settings" #91381

Closed

7 tasks

jponikarchuk mentioned this pull request May 22, 2026

[Due for payment 2026-06-01] [Due for payment 2026-05-29] [Bulk workspace edits] Three-dot menu entry + Page 1 (Select workspaces) [3] #88669

Closed

applause-bot Bot mentioned this pull request May 22, 2026

[Due for payment 2026-06-01] Workspace - Workspace deleted offline still visible on "Copy Settings" and can be selected #91389

Closed

7 tasks

Conversation

fedirjh commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

What this PR adds

Fixed Issues

Tests

Setup

Test 1 — Three-dot menu entry

Test 2 — Eligibility filtering

Test 3 — Workspace avatars

Test 4 — Select-all alignment and behavior

Test 5 — Search

Test 6 — Next / commit selection

Test 7 — Selection cleared on RHP close

Test 8 — Console

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented May 8, 2026

Uh oh!

codecov Bot commented May 8, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented May 11, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

dmkt9 commented May 12, 2026

Uh oh!

francoisl commented May 20, 2026

Uh oh!

fedirjh commented May 20, 2026

Uh oh!

dmkt9 commented May 20, 2026

Uh oh!

francoisl commented May 21, 2026

Uh oh!

dmkt9 commented May 21, 2026

Uh oh!

dmkt9 commented May 21, 2026

Uh oh!

chatgpt-codex-connector Bot commented May 21, 2026

Uh oh!

dmkt9 commented May 21, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

dmkt9 May 21, 2026

Choose a reason for hiding this comment

Uh oh!

fedirjh May 21, 2026

Choose a reason for hiding this comment

Uh oh!

fedirjh May 21, 2026

Choose a reason for hiding this comment

Uh oh!

dmkt9 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented May 21, 2026

Uh oh!

github-actions Bot commented May 21, 2026

Uh oh!

OSBotify commented May 21, 2026

Uh oh!

OSBotify commented May 21, 2026

Uh oh!

jponikarchuk commented May 22, 2026

Uh oh!

jponikarchuk commented May 22, 2026

Uh oh!

fedirjh commented May 8, 2026 •

edited

Loading

codecov Bot commented May 8, 2026 •

edited by github-actions Bot

Loading