[Bulk workspace edits] Add Copy Policy Settings select-features page (step 2 of 3) by fedirjh · Pull Request #90220 · Expensify/App

fedirjh · 2026-05-11T16:53:47Z

Explanation of Change

Implements the second RHP step of the new Copy Settings flow that's part of the Bulk workspace edits project — task 4 of the project. Earlier tasks: scaffold #89959 (merged), action layer #89963, page 1 #90079. This PR is stacked on top of #90079 and depends on tasks 1 & 2 — please land the upstream PRs first.

What this PR adds

Accounting-compatibility utility in src/libs/CopyPolicySettingsUtils.ts. Ports Policy::getConnectionCompanyID from Auth/auth/lib/Policy.cpp to TypeScript so the App can compare external accounts across policies:
- QBO → config.realmId
- NetSuite → top-level accountID
- Xero / Sage Intacct / QuickBooks Desktop / Certinia → config.credentials.companyID
Exposes arePoliciesAccountingCompatible(source, target) — two policies are compatible only when both have no accounting connection, or they share the same connection name AND a matching non-empty companyID. areAllTargetsAccountingCompatible(source, targets) runs that across every target.
Unit tests in tests/unit/CopyPolicySettingsUtilsTest.ts — 15 cases covering the design-doc scenarios:
- source connected to nothing, target connected to NetSuite → INCOMPATIBLE
- source connected to QBO, target connected to nothing → INCOMPATIBLE
- source NetSuite Acme Corp vs target NetSuite ExpensivePie → INCOMPATIBLE
- different connection names entirely → INCOMPATIBLE
- both unconnected → COMPATIBLE
- same connection + same companyID → COMPATIBLE
- missing companyID on either side → INCOMPATIBLE
- QBO realmId equality
- per-integration getConnectionCompanyID extraction
Select Features page in src/pages/workspace/copyPolicySettings/CopyPolicySettingsSelectFeaturesPage.tsx. Renders the 13 part rows (overview, members, reports, accounting, categories, tags, taxes, workflows, rules, distanceRates, perDiem, invoices, travel) in a SelectionList with MultiSelectListItem. Behaviors:
- Disabled accounting-dependent rows. categories, tags, reports, taxes are greyed out + uncheckable whenever any selected target has a mismatched (or missing) connection vs. the source.
- Force-enable on Accounting. Selecting accounting flips those same four parts to isSelected: true, isDisabled: true so they can't be unchecked (syncing a connection implies its coding must come along).
- Workflows-without-members warning. On "Next", if workflows is selected but members is not, opens a confirm modal explaining that Submission and Payment settings will be copied without members. On confirm (or when there's no conflict) persists parts to ONYXKEYS.COPY_POLICY_SETTINGS via setCopyPolicySettingsData and routes to POLICY_COPY_SETTINGS_CONFIRM.
- Local selection state. Closing the RHP discards the in-progress selection (same pattern as Page 1).
Translations — new workspace.copyPolicySettings.{selectFeatures, whichFeatures, accountingDisabledTooltip, workflowsWithoutMembersTitle, workflowsWithoutMembersPrompt} across all 10 language files.

Fixed Issues

$ #88671
PROPOSAL: N/A

Tests

Setup

Sign in as an admin on at least three Corporate (Control) workspaces. Use a workspace with multiple members, categories, tags, workflows, and optionally an accounting connection as the source — this ensures all applicable feature rows appear. Have at least one pair of workspaces sharing the same accounting connection (e.g. both connected to the same NetSuite account) and at least one workspace connected to a different accounting account (or none).

Test 1 — Page renders only applicable feature rows

From the Workspaces list three-dot menu, open Copy settings → Select workspaces → tick at least one target → Next.
Verify the Select Features step shows only feature rows that are relevant to the source workspace. The full set of possible rows is: Overview, Members, Reports, Accounting, Categories, Tags, Taxes, Workflows, Rules, Distance rates, Per Diem, Invoices, Travel.
Features are conditionally shown based on the source policy's configuration:
- Members only appears when the source workspace has more than 1 member.
- Reports only appears when the source has report fields.
- Accounting only appears when the source has an active accounting connection.
- Categories only appears when the source has categories.
- Tags only appears when the source has tags.
- Taxes only appears when the source has taxes configured.
- Workflows only appears when the source has workflow rules configured.
- Rules only appears on Corporate policies with workspace rules.
- Distance rates only appears when the source has distance rates enabled with rates configured.
- Per Diem only appears when the source has per diem rates.
- Invoices only appears when the source has invoices enabled with invoice configuration.
- Travel only appears when the source has travel enabled.
- Overview always appears.

Test 2 — Accounting-compatibility disables Categories/Tags/Reports/Taxes/Accounting

From a source workspace connected to e.g. NetSuite account A, pick targets that all share the same NetSuite account A. Reach Select Features.
Verify Categories, Tags, Reports, Taxes, Accounting are toggleable (not greyed out).
Go back and add a target connected to a different NetSuite account (or no accounting connection).
Verify those rows are now greyed out and cannot be selected, with a tooltip explaining the accounting mismatch.
Repeat with the design-doc scenarios:
- source connected to nothing, target connected to NetSuite → disabled
- source connected to QBO, target connected to nothing → disabled
- source NetSuite Acme Corp vs target NetSuite ExpensivePie → disabled

Test 3 — Force-enable on Accounting

Reach Select Features with accounting-compatible targets.
Toggle Accounting on.
Verify Categories, Tags, Reports, Taxes become checked and locked (cannot be toggled off).
Toggle Accounting off.
Verify those four rows return to their normal toggleable state and revert to their previous (toggleable) selection.

Test 4 — Workflows-without-members warning

Reach Select Features with a source workspace that has >1 member.
Select Workflows but leave Members unchecked.
Click "Next".
Verify a confirm modal appears with the explanatory prompt about copying workflows without members.
Click "Cancel" → verify the modal closes and you remain on the page with selection intact.
Click "Next" again, confirm — verify the flow advances to the Confirm step and copyPolicySettings.parts in Onyx contains ["workflows", ...].
Repeat with both Workflows and Members selected → verify no modal appears and the flow advances immediately.
Repeat with a source workspace that has only 1 member (the owner) — Members row won't be visible. Select Workflows and click Next → verify the modal does NOT appear (there are no members to copy, so the warning is irrelevant).

Test 5 — Select-all + Next

Reach Select Features with accounting-compatible targets.
Tap "Select all" → verify all visible rows become checked.
Tap "Select all" again → verify all clear.
Reach the step again, select nothing → verify "Next" is disabled.
Select at least one row → "Next" becomes enabled.
Click "Next" → verify copyPolicySettings.parts is written to Onyx and the flow routes to the Confirm step.

Test 6 — Selection cleared on RHP close

Reach Select Features, select 2–3 parts.
Close the RHP via X/back without clicking "Next".
Re-enter the flow and reach Select Features.
Verify the previous part selection is not restored.

Test 7 — Console

Verify that no errors appear in the JS console while running tests 1–6.

Offline tests

The page only reads from Onyx (COLLECTION.POLICY + COPY_POLICY_SETTINGS) and writes via setCopyPolicySettingsData on Next. Both should work offline:

Toggle off network.
Reach Select Features.
Verify the accounting-disabled rows are correctly computed from the cached policy data.
Force-enable / select-all / Next still work; parts is written to Onyx.

QA Steps

Same as Tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Ports Auth's Policy::getConnectionCompanyID logic (QBO → config.realmId, NetSuite → top-level accountID, Xero/Intacct/QBD/Certinia → config.credentials.companyID) to TypeScript. Exposes: - getConnectionCompanyID(policy, connectionName) - getAccountingConnectionIdentity(policy) — first valid connection - arePoliciesAccountingCompatible(source, target) — true only when both policies have no accounting connection, or share the same connection AND a matching non-empty companyID - areAllTargetsAccountingCompatible(source, targets) — every-target compatibility check used by the Select Features step Page 2 will use this to disable Categories/Tags/Reports/Taxes whenever any selected target has a mismatched (or missing) connection.

Covers the design-doc scenarios for accounting compatibility: - source connected to nothing, target connected to NetSuite - source connected to QBO, target connected to nothing - source NetSuite Acme vs target NetSuite ExpensivePie - different connection names entirely - both unconnected - same connection + same companyID - missing companyID on either side - QBO realmId equality Plus per-integration getConnectionCompanyID extraction (QBO realmId, NetSuite top-level accountID, credentials.companyID for Sage Intacct, Xero, and QBD).

Adds the strings used by the Select Features step (Page 2 of the Copy Policy Settings flow) to workspace.copyPolicySettings across all ten language files: - selectFeatures — page H2 - whichFeatures — page subheader - accountingDisabledTooltip — tooltip for the Categories/Tags/Reports/Taxes rows when targets are not connected to the same accounting account - workflowsWithoutMembersTitle / workflowsWithoutMembersPrompt — confirm modal shown when the admin selects Workflows but not Members

Second RHP step of the bulk Copy Policy Settings flow. Renders the 13 part rows (overview, members, reports, accounting, categories, tags, taxes, workflows, rules, distanceRates, perDiem, invoices, travel) in a SelectionList with MultiSelectListItem. Behaviors required by the design doc: - Categories/Tags/Reports/Taxes are disabled when any selected target workspace has a mismatched (or missing) accounting connection relative to the source, via areAllTargetsAccountingCompatible. - Selecting "Accounting" force-selects + force-disables those same four parts (syncing a connection implies its coding must come along). - On "Next", if Workflows is selected but Members is not, opens a confirm modal warning that Submission and Payment settings will be copied without members. On confirm (or when there's no conflict) persists `parts` to COPY_POLICY_SETTINGS via setCopyPolicySettingsData and routes to POLICY_COPY_SETTINGS_CONFIRM. - Selection lives in useState so closing the RHP discards it (matches Page 1).

melvin-bot · 2026-05-11T16:53:53Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

codecov · 2026-05-11T17:03:31Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/SelectionList/BaseSelectionList.tsx	`67.98% <100.00%> (+0.77%)`	⬆️
...components/SelectionList/components/ListHeader.tsx	`90.90% <100.00%> (+5.19%)`	⬆️
...ettings/CopyPolicySettingsSelectWorkspacesPage.tsx	`0.00% <0.00%> (ø)`
src/libs/CopyPolicySettingsUtils.ts	`76.76% <76.76%> (ø)`
...ySettings/CopyPolicySettingsSelectFeaturesPage.tsx	`0.00% <0.00%> (ø)`
... and 10 files with indirect coverage changes

Replaces the verbose "Which configurations do you want to copy to the other workspaces? Only these settings will be overwritten on the target workspaces." with the shorter, more direct: "Select the settings to overwrite on your existing workspaces." Localizes the new copy across all ten language files.

cspell doesn't recognize "togglable" as a dictionary word. Rename the local variables (togglableParts / togglableSet / togglable comment) to the more conventional "selectable" — the meaning is identical in this context and it passes cspell without dictionary additions.

Refactors the page to inline the computed values (effectiveSelectedFeatures, listItems, isFeatureDisabled, selectableFeatures, toggleAll, onConfirm) that were previously wrapped in useMemo / useCallback. The values are already cheap to compute and the wrappers added noise without measurable benefit. Renames selectedParts -> selectedFeatures / togglePart -> toggleFeature for consistency with the page's UI vocabulary.

When the select-all checkbox sits on the right, the label is followed by the checkbox immediately, so the trailing horizontal padding from `styles.ph3` collides with the checkbox. Switch to `styles.pr3` on the right-positioned variant so only leading padding is applied to the label, keeping spacing symmetric with the left-positioned layout.

Mirrors the WorkspaceDuplicateSelectFeaturesForm pattern: each row now includes a short summary derived from the source workspace ("12 categories", "3 members", "QuickBooks Online", "$, Berlin, …" for overview, etc.) so the admin can see at a glance what will be copied. Reuses existing helpers (getMemberAccountIDsForWorkspace, getReportFieldsByPolicyID, getAllValidConnectedIntegration, getDistanceRateCustomUnit / getPerDiemCustomUnit, getWorkflowRules / getWorkspaceRules from the duplicate flow, formatAddressToString). Filters out pending-delete entries when counting so the numbers reflect what would actually be copied. Bumps alternateNumberOfSupportedLines to 2 since some rows (rules, invoices) can produce longer captions.

…languages

…ple languages

…ut members

melvin-bot · 2026-05-20T11:36:33Z

@truph01 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ishpaul777 · 2026-05-26T17:35:59Z

@yuwenmemon All yours!

yuwenmemon

Francois is on parental leave so I'll be reviewing for this project in his stead

github-actions · 2026-05-26T18:51:58Z

🚧 @yuwenmemon has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-05-26T18:58:16Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #90220.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-b68c1973d34-73f6a85-be5531bed2d9a7a3ff072281cd4c27aaaca3d752/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-b68c197-73f6a85-535a466a6dfa2a8923e03e2a32a62bf0676dc7a7/index.html

Web 🕸️
https://90220.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-05-26T19:01:02Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-05-26T20:37:54Z

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.3.83-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

jponikarchuk · 2026-05-27T05:45:26Z

Deploy Blocker #91791 was identified to be related to this PR.

mitarachim · 2026-05-27T05:47:52Z

Deploy Blocker #91792 was identified to be related to this PR.

jponikarchuk · 2026-05-27T06:00:58Z

Deploy Blocker #91793 was identified to be related to this PR.

jponikarchuk · 2026-05-27T08:49:28Z

Deploy Blocker #91805 was identified to be related to this PR.

jponikarchuk · 2026-05-27T10:22:37Z

Deploy Blocker #91821 was identified to be related to this PR.

jponikarchuk · 2026-05-27T10:44:55Z

Deploy Blocker #91825 was identified to be related to this PR.

jponikarchuk · 2026-05-27T10:56:13Z

Deploy Blocker #91827 was identified to be related to this PR.

jponikarchuk · 2026-05-27T11:20:14Z

Deploy Blocker #91830 was identified to be related to this PR.

jponikarchuk · 2026-05-27T11:45:56Z

Deploy Blocker #91833 was identified to be related to this PR.

OSBotify · 2026-05-27T17:27:31Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.83-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fedirjh added 4 commits May 11, 2026 17:28

melvin-bot Bot assigned fedirjh May 11, 2026

fedirjh changed the title ~~Add Copy Policy Settings select-features page (step 2 of 3)~~ [Bulk workspace edits] Add Copy Policy Settings select-features page (step 2 of 3) May 11, 2026

fedirjh added 12 commits May 11, 2026 19:15

Merge branch 'Expensify:main' into copy-policy-settings-page-2

17e6835

Merge remote-tracking branch 'upstream' into copy-policy-settings-page-2

b99512e

feat(i18n): add copy policy settings page translations

79e795b

feat(i18n): update translations for copy policy settings in multiple …

3d34f24

…languages

feat(i18n): refine translations for copy policy settings across multi…

758bff4

…ple languages

fix(i18n): update confirmation modal translations for workflows witho…

c6dbb06

…ut members

fix: sync select-all checkbox when forced features are selected

cbdec07

fedirjh requested review from francoisl and ishpaul777 May 20, 2026 11:36

fedirjh marked this pull request as ready for review May 20, 2026 11:36

fedirjh requested review from a team as code owners May 20, 2026 11:36

melvin-bot Bot requested review from joekaufmanexpensify and truph01 May 20, 2026 11:36

melvin-bot Bot removed request for a team May 20, 2026 11:36

ishpaul777 mentioned this pull request May 26, 2026

[Bulk workspace edits] Add Copy Policy Settings Double-check confirmation page (step 3 of 3) #91241

Merged

51 tasks

yuwenmemon approved these changes May 26, 2026

View reviewed changes

yuwenmemon merged commit b68c197 into Expensify:main May 26, 2026
45 checks passed

fedirjh deleted the copy-policy-settings-page-2 branch May 26, 2026 19:10

OSBotify mentioned this pull request May 26, 2026

Deploy Checklist: New Expensify 2026-05-26 #91756

Closed

54 tasks

truph01 mentioned this pull request May 27, 2026

[Bulk workspace edits] Page 2 (Select features) [4] #88671

Open

applause-bot Bot mentioned this pull request May 27, 2026

[Due for payment 2026-06-04] [Due for payment 2026-06-03] Workspace - Disabled feature is still displayed on "Copy Settings" page. #91791

Closed

7 tasks

applause-bot Bot mentioned this pull request May 27, 2026

Workspaces - Incorrect navigation from features page on "Copy Settings" after refreshing #91792

Open

7 tasks

applause-bot Bot mentioned this pull request May 27, 2026

[Due for payment 2026-06-04] [Due for payment 2026-06-03] Workspace - All feature lists are not shown in Copy settings page #91793

Closed

7 tasks

applause-bot Bot mentioned this pull request May 27, 2026

[Due for payment 2026-06-04] [Due for payment 2026-06-03] Workspace - Missing "your auto-categorization rules" when copying settings #91805

Closed

7 tasks

applause-bot Bot mentioned this pull request May 27, 2026

[Due for payment 2026-06-17] Workspace - Missing "1 bank accounts" on Invoice row when workspace has partially setup bank #91821

Closed

7 tasks

applause-bot Bot mentioned this pull request May 27, 2026

[Due for payment 2026-06-04] [Due for payment 2026-06-03] Workspace - App crashes when opening Copy settings after disconnecting Intacct&connecting QBD #91825

Closed

7 tasks

applause-bot Bot mentioned this pull request May 27, 2026

[Due for payment 2026-06-04] [Due for payment 2026-06-03] Workspace - Accounting row is shown when QBD connection fails #91827

Closed

7 tasks

applause-bot Bot mentioned this pull request May 27, 2026

[Due for payment 2026-06-04] [Due for payment 2026-06-03] Rules-Copy settings doesn't show merchant rules. #91830

Closed

7 tasks

applause-bot Bot mentioned this pull request May 27, 2026

[Due for payment 2026-06-17] Workspaces - Members row shows 2 members when there is only 1 member on Copy settings page #91833

Closed

7 tasks

Conversation

fedirjh commented May 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

What this PR adds

Fixed Issues

Tests

Setup

Test 1 — Page renders only applicable feature rows

Test 2 — Accounting-compatibility disables Categories/Tags/Reports/Taxes/Accounting

Test 3 — Force-enable on Accounting

Test 4 — Workflows-without-members warning

Test 5 — Select-all + Next

Test 6 — Selection cleared on RHP close

Test 7 — Console

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented May 11, 2026

Uh oh!

codecov Bot commented May 11, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented May 20, 2026

Uh oh!

ishpaul777 commented May 26, 2026

Uh oh!

yuwenmemon left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented May 26, 2026

Uh oh!

github-actions Bot commented May 26, 2026

Uh oh!

OSBotify commented May 26, 2026

Uh oh!

OSBotify commented May 26, 2026

Uh oh!

jponikarchuk commented May 27, 2026

Uh oh!

mitarachim commented May 27, 2026

Uh oh!

jponikarchuk commented May 27, 2026

Uh oh!

jponikarchuk commented May 27, 2026

Uh oh!

jponikarchuk commented May 27, 2026

Uh oh!

jponikarchuk commented May 27, 2026

Uh oh!

jponikarchuk commented May 27, 2026

Uh oh!

jponikarchuk commented May 27, 2026

Uh oh!

jponikarchuk commented May 27, 2026

Uh oh!

OSBotify commented May 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

fedirjh commented May 11, 2026 •

edited

Loading

codecov Bot commented May 11, 2026 •

edited by github-actions Bot

Loading