feat: Wire ExportDownloadStatusModal into CSV export flow by truph01 · Pull Request #92169 · Expensify/App

truph01 · 2026-06-01T07:07:20Z

Explanation of Change

This change wires the new ExportDownloadStatusModal into the Search bulk-export (CSV/template) flow so users get in-app feedback on their export instead of relying solely on the "Concierge will send" confirmation.

Fixed Issues

$ #90298
PROPOSAL:

Tests

Test 1:

Open ND.
Navigate to Spend > Expenses.
Select any expense.
Click the "x selected" dropdown button, then choose Export > All Data - Expense Level.
Verify that the following modal is displayed:
Wait a few seconds until the following modal appears:
Click Download file.
Verify that the file downloads successfully.

Test 2:

Open ND.
Navigate to Spend > Expenses.
Select any expense.
Click the "x selected" dropdown button, then choose Export > All Data - Expense Level.
Verify that the following modal is displayed:
Click on "Send me the file when it's ready".
Click on "Go to Concierge" button.
Wait a few seconds until the download file is received.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Test 1:

Open ND.
Navigate to Spend > Expenses.
Select any expense.
Click the "x selected" dropdown button, then choose Export > All Data - Expense Level.
Verify that the following modal is displayed:
Wait a few seconds until the following modal appears:
Click Download file.
Verify that the file downloads successfully.

Test 2:

Open ND.
Navigate to Spend > Expenses.
Select any expense.
Click the "x selected" dropdown button, then choose Export > All Data - Expense Level.
Verify that the following modal is displayed:
Click on "Send me the file when it's ready".
Click on "Go to Concierge" button.
Wait a few seconds until the download file is received.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Screen.Recording.2026-06-15.at.09.51.15.mov

iOS: Native

iOS: mWeb Safari

Screen.Recording.2026-06-15.at.09.47.16.mov

MacOS: Chrome / Safari

Screen.Recording.2026-06-15.at.09.44.30.mov

Screen.Recording.2026-06-15.at.17.25.16.mov

melvin-bot · 2026-06-01T07:07:27Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

melvin-bot · 2026-06-01T07:08:04Z

@daledah Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f1fd1abe69

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-06-01T07:10:59Z

+        exportID,
+    }) as QueueExportSearchItemsToCSVParams;
+
+    API.write(WRITE_COMMANDS.QUEUE_EXPORT_SEARCH_ITEMS_TO_CSV, finalParameters, {optimisticData});


Add failure data for failed queued exports

When QueueExportSearchToCSV returns a non-200 response, SaveResponseInOnyx only applies the request's failureData; this request now writes an optimistic preparing export entry but provides no rollback. In that failure scenario the new CSV export modal remains stuck in the non-dismissible preparing state because the Onyx entry is never cleared or moved to failed (the same pattern appears in queueExportSearchWithTemplate below). Please include failure/finally data that clears or fails the export entry.

Useful? React with 👍 / 👎.

Add failure data

codecov · 2026-06-01T07:14:54Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/API/types.ts	`100.00% <ø> (ø)`
src/libs/actions/Search.ts	`38.61% <100.00%> (+2.91%)`	⬆️
src/components/ExportDownloadStatusModal.tsx	`96.36% <94.11%> (+2.36%)`	⬆️
src/components/Search/SearchBulkActionsButton.tsx	`1.58% <0.00%> (-0.03%)`	⬇️
src/hooks/useSearchBulkActions.ts	`54.87% <36.84%> (+2.92%)`	⬆️
... and 13 files with indirect coverage changes

truph01 · 2026-06-01T08:53:44Z

@MelvinBot With the current fileDownload in ExportDownloadStatusModal component, when the downloadURL is "https://staging.expensify.com/secure?secureType=csvexport&filename=csv_exports%2Fexport_2026-06-01_08-52-39_6a1d485737eba.csv&downloadName=export_2026-06-01_08-52-39_6a1d485737eba.csv",
it opens https://staging.expensify.com/secure?secureType=csvexport&filename=csv_exports%2Fexport_2026-06-01_08-52-39_6a1d485737eba.csv&downloadName=export_2026-06-01_08-52-39_6a1d485737eba.csv in new tab without downloading.

Please help investigate.

MelvinBot · 2026-06-01T09:00:29Z

Issue Analysis

Root Cause: ExportDownloadStatusModal calls fileDownload(translate, downloadURL) with the raw secure URL and no encryptedAuthToken (ExportDownloadStatusModal.tsx:62 and :78). The /secure?secureType=csvexport&... endpoint requires authentication, but fetchFileDownload sends the request with credentials: 'same-origin' — and since NewDot and *.expensify.com are different origins, no cookies are sent and there's no token in the URL. The unauthenticated cross-origin fetch() fails, so the .catch() fallback runs Link.openExternalLink(url) → the URL opens in a new tab instead of downloading.

The URL itself is fine (tryResolveUrlFromApiRoot normalizes the staging.expensify.com origin, so isApiUrl is true and the early-return branch is not taken). The problem is purely the missing auth token on the request.

Recommended Fix: Mirror the existing secure-file download pattern — wrap the URL with addEncryptedAuthTokenToURL(...) before passing it to fileDownload, in both call sites:

import addEncryptedAuthTokenToURL from '@libs/addEncryptedAuthTokenToURL';
// ...
const [session] = useOnyx(ONYXKEYS.SESSION);
const encryptedAuthToken = session?.encryptedAuthToken ?? '';
// ...
fileDownload(translate, addEncryptedAuthTokenToURL(downloadURL, encryptedAuthToken, true));

hasOtherParameters must be true because downloadURL already has query params (it appends &encryptedAuthToken=...).

Investigation details & evidence

Why the fetch fails without the token. fetchFileDownload only opens a new tab in two places:

The early-return at L47-L56 — not hit here: shouldOpenExternalLink is false (modal passes only 2 args), isAttachmentUrl is false (ATTACHMENT_LOCAL_URL_PREFIX is ['blob:', 'file:']), and isApiUrl is true because tryResolveUrlFromApiRoot rewrites the https://staging.expensify.com/ origin to the current API root, which the very next line then compares against.
The .catch() at L78-L85 — this is the path taken. The actual request uses the original url with credentials: 'same-origin', so the cross-origin secure endpoint gets no auth → the fetch rejects → new tab.

Proven working pattern (same URL shape, same fetchFileDownload): WalletStatementPage.tsx:82 downloads a secure?secureType=pdfreport&... URL on the same host and it works — because it appends the token via addEncryptedAuthTokenToURL. Same approach in Report.downloadReportPDF and TravelInvoicingUtils.ts:151. The token is read from session.encryptedAuthToken (Session type).

(Note: the other CSV-export call sites — Search.ts, Domain.ts, Policy/*.ts — use a different mechanism: a POST to an /api/... command URL with the authToken in formData. That pattern doesn't apply here because your downloadURL is already a fully-formed secure?secureType=... file URL, so the PDF/secure pattern is the right match.)

Optional secondary nit: the modal passes no fileName (3rd arg). On the success path the blob would still download, but supplying a name (you have downloadName=... in the URL) gives a proper filename and lets the JSON-error guard at L67-L69 catch a server error response for .csv downloads.

Next Steps: Reply with @MelvinBot implement this to create a draft PR with the fix, or @MelvinBot <your feedback> to refine this analysis.

daledah · 2026-06-03T05:28:19Z

@truph01 is this PR ready for review?

trjExpensify · 2026-06-03T21:43:17Z

@truph01 bump on the question above.

truph01 · 2026-06-04T06:03:00Z

@truph01 is this PR ready for review?

@daledah No, i am still working on it. I will remove "WIP" label once it is ready for review.

dannymcclain · 2026-06-16T14:58:10Z

didn't we land on wanting to open Concierge in the RHP when clicked here to keep people in the current context? I think that would be better.

Agree with that Tom, I think that'd be nice.

mollfpr · 2026-06-16T15:52:59Z

Yeahhh, I miss that part 😅

@truph01 I think we only need to update handleGoToConcierge, right?

truph01 · 2026-06-17T03:19:51Z

@truph01 I think we only need to update handleGoToConcierge, right?

@mollfpr I updated handleGoToConcierge. Here is result:

Screen.Recording.2026-06-17.at.10.19.19.mov

mollfpr · 2026-06-17T03:21:54Z

Love it! Thanks @truph01!

mollfpr · 2026-06-17T03:27:26Z

@truph01 the changes looks good to me! Only need to fix the failing test.

truph01 · 2026-06-17T03:41:06Z

@mollfpr All good now

github-actions · 2026-06-17T03:48:12Z

🚧 @mollfpr has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-06-17T03:53:25Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-06-17T03:53:36Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #92169.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-257cd2db459-136c658-80cb7162da7abf7d5ade0e0e6ef690e30128b558/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-257cd2d-136c658-08188f56c4fd9e006affbdf8bdcc8619894ec254/index.html

Web 🕸️
https://92169.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-06-17T18:42:00Z

🚀 Deployed to staging by https://github.com/mollfpr in version: 9.4.10-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-06-17T18:46:25Z

Help site review — docs update required ✅

This PR changes how Search bulk exports (CSV/template) are delivered: instead of the old "Concierge will send the file" confirmation, users now see an in-app Preparing download window that downloads the file directly, with an option to Send me the file when it's ready via Concierge.

This makes the Export as CSV sections (Web + Mobile) and the How do I receive my export? FAQ in Search-and-Download-Expenses.md outdated, since they still describe Concierge as the only delivery method.

Draft help site PR: #93866

What changed in the docs

Export as CSV → Web / Mobile: replaced the "You'll receive a message from Concierge" line with the in-app download status modal behavior.
FAQ → How do I receive my export?: replaced the Basic-vs-other-templates Concierge split with the unified status-modal flow.

UI copy (Send me the file when it's ready, Preparing download) was sourced from the merged exportDownload strings in src/languages/en.ts. Navigation labels were left unchanged as they already match the UI.

@truph01, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review.

nlemma · 2026-06-17T19:35:38Z

Deploy Blocker #93873 was identified to be related to this PR.

nlemma · 2026-06-17T19:48:11Z

Deploy Blocker #93874 was identified to be related to this PR.

OSBotify · 2026-06-18T00:18:06Z

🚀 Deployed to staging by https://github.com/mollfpr in version: 9.4.12-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-06-18T00:22:51Z

Help site changes required ✅

This PR changes a user-facing flow: CSV/template exports from Spend no longer always arrive as a Concierge direct message. Instead, the new ExportDownloadStatusModal shows an in-app status window while the file is prepared, then downloads the file directly in the app (with the option to have Concierge send it via Send me the file when it's ready).

The existing help article Search-and-Download-Expenses.md still told users they'd "receive a message from Concierge with the exported file," which is now outdated.

Draft help site PR: #93890

It updates the Export as CSV (Web), Export as CSV (Mobile), and FAQ → How do I receive my export? sections to describe the status-window + in-app download behavior. UI labels were verified against the exportDownload strings in src/languages/en.ts.

@truph01, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review.

OSBotify · 2026-06-18T03:03:41Z

🚀 Deployed to staging by https://github.com/mollfpr in version: 9.4.14-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

OSBotify · 2026-06-18T17:14:26Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.4.14-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

feat: Wire ExportDownloadStatusModal into CSV export flow

f1fd1ab

melvin-bot Bot assigned truph01 Jun 1, 2026

truph01 changed the title ~~feat: Wire ExportDownloadStatusModal into CSV export flow~~ [WIP] feat: Wire ExportDownloadStatusModal into CSV export flow Jun 1, 2026

truph01 marked this pull request as ready for review June 1, 2026 07:07

truph01 requested review from a team as code owners June 1, 2026 07:07

melvin-bot Bot requested review from daledah and heyjennahay and removed request for a team June 1, 2026 07:08

chatgpt-codex-connector Bot reviewed Jun 1, 2026

View reviewed changes

truph01 added 2 commits June 1, 2026 14:38

fix: add failure data

1b0763e

fix: lint

43cf551

fix: update fileDownload

01b3131

truph01 added 5 commits June 3, 2026 16:02

fix: conflicts

68737e0

fix: conflicts

2b13d84

fix: missing exportID

5b63de7

fix: lint

20d4f61

fix: tests

1dedaf2

truph01 added 3 commits June 4, 2026 07:07

Merge branch 'Expensify:main' into fix/90298

28a401d

fix: lint

585b3be

Merge branch 'Expensify:main' into fix/90298

8b46b5c

trjExpensify mentioned this pull request Jun 16, 2026

feat: Enable multi-select Download as PDF #92275

Merged

51 tasks

truph01 added 2 commits June 17, 2026 10:07

Merge branch 'Expensify:main' into fix/90298

d0da579

fix: update handleGoToConcierge

47608dd

truph01 dismissed mollfpr’s stale review via 47608dd June 17, 2026 03:18

fix: test

c02e8bd

mollfpr approved these changes Jun 17, 2026

View reviewed changes

mollfpr merged commit 257cd2d into Expensify:main Jun 17, 2026
33 checks passed

OSBotify mentioned this pull request Jun 17, 2026

Deploy Checklist: New Expensify 2026-06-17 #93863

Closed

67 tasks

MelvinBot mentioned this pull request Jun 17, 2026

[No QA] Docs updates for E/A#92169 Search CSV export download status modal #93866

Draft

1 task

applause-bot Bot mentioned this pull request Jun 17, 2026

[Due for payment 2026-06-26] [Due for payment 2026-06-25] Expense - Exported file is not received in Concierge chat #93873

Closed

7 tasks

applause-bot Bot mentioned this pull request Jun 17, 2026

[Due for payment 2026-06-26] [Due for payment 2026-06-25] Expense - Your file is ready! modal does not close when click Download file #93874

Closed

7 tasks

applause-bot Bot mentioned this pull request Jun 17, 2026

[Exploratory] IOU - Exported file shows negative expense amount #93880

Open

7 tasks

MelvinBot mentioned this pull request Jun 18, 2026

[No QA] Docs updates for E/A#92169 CSV export download status modal flow #93890

Open

Conversation

truph01 commented Jun 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jun 1, 2026

Uh oh!

melvin-bot Bot commented Jun 1, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jun 1, 2026

Choose a reason for hiding this comment

Uh oh!

truph01 Jun 1, 2026

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Jun 1, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

truph01 commented Jun 1, 2026

Uh oh!

MelvinBot commented Jun 1, 2026

Issue Analysis

Uh oh!

daledah commented Jun 3, 2026

Uh oh!

trjExpensify commented Jun 3, 2026

Uh oh!

truph01 commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dannymcclain commented Jun 16, 2026

Uh oh!

mollfpr commented Jun 16, 2026

Uh oh!

truph01 commented Jun 17, 2026

Uh oh!

mollfpr commented Jun 17, 2026

Uh oh!

mollfpr commented Jun 17, 2026

Uh oh!

truph01 commented Jun 17, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jun 17, 2026

Uh oh!

OSBotify commented Jun 17, 2026

Uh oh!

github-actions Bot commented Jun 17, 2026

Uh oh!

OSBotify commented Jun 17, 2026

Uh oh!

MelvinBot commented Jun 17, 2026

Help site review — docs update required ✅

Uh oh!

nlemma commented Jun 17, 2026

Uh oh!

nlemma commented Jun 17, 2026

Uh oh!

OSBotify commented Jun 18, 2026

Uh oh!

MelvinBot commented Jun 18, 2026

Help site changes required ✅

Uh oh!

OSBotify commented Jun 18, 2026

Uh oh!

OSBotify commented Jun 18, 2026

Uh oh!

Reviewers

Assignees

truph01 commented Jun 1, 2026 •

edited

Loading

codecov Bot commented Jun 1, 2026 •

edited by github-actions Bot

Loading

truph01 commented Jun 4, 2026 •

edited

Loading