Skip to content

[No QA] Docs updates for E/A#92169 CSV export download status modal flow#93890

Open
MelvinBot wants to merge 2 commits into
mainfrom
docs-export-status-modal-90298
Open

[No QA] Docs updates for E/A#92169 CSV export download status modal flow#93890
MelvinBot wants to merge 2 commits into
mainfrom
docs-export-status-modal-90298

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Why

Expensify/App#92169 wires the new ExportDownloadStatusModal into the Search bulk-export (CSV/template) flow. Exports no longer always arrive as a Concierge direct message — instead, an in-app status window appears while the file is prepared and the file downloads directly in the app when ready, with the option to have Concierge send it instead.

What changed

Updated docs/articles/new-expensify/reports-and-expenses/Search-and-Download-Expenses.md to describe the new flow in three places:

  • Export as CSV → Web: replaced "You'll receive a message from Concierge with the exported file" with the status-window + auto-download behavior, including the Download file and Send me the file when it's ready options.
  • Export as CSV → Mobile: same update, using tap wording.
  • FAQ → How do I receive my export?: replaced the Basic Export / other-templates split with the new download-in-app + optional Concierge behavior.

UI labels used (verified against src/languages/en.ts exportDownload): Download file, Send me the file when it's ready, Go to Concierge.

Note for reviewer

I verified the new copy against the PR's source and the exportDownload translation strings, but I did not exercise the live UI. One nuance not spelled out in the article: a single-selection Basic Export still downloads immediately without the status window, while select-all and template exports now use the status window. Please confirm whether the article should call out that distinction.

@truph01, please review the files changed and confirm they reflect the current behavior. Then mark this PR Ready for review.

Co-authored-by: truph01 <truph01@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Jun 18, 2026
@github-actions github-actions Bot changed the title Docs updates for E/A#92169 CSV export download status modal flow [No QA] Docs updates for E/A#92169 CSV export download status modal flow Jun 18, 2026
@OSBotify

This comment has been minimized.

@truph01

truph01 commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot Mark this PR as ready for review

@MelvinBot MelvinBot marked this pull request as ready for review June 19, 2026 11:46

- **Basic Export**: Downloads immediately to your device.
- **All other templates**: Concierge will send the export file to you via direct message.
A status window appears while your file is prepared, and the file downloads automatically when it’s ready (if it doesn’t, use the **Download file** button). If you’d rather not wait, click **Send me the file when it’s ready** and Concierge will send it to you in a chat message.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent UI/term formatting (Deterministic Writing Rule): "Concierge" is bolded as Concierge on the changed web (line 33) and mobile (line 46) lines, but here it is plain text. Per HELPSITE_NAMING_CONVENTIONS.md (Deterministic Writing Rule: "Be consistent. Avoid stylistic variation."), reference Concierge the same way throughout — use Concierge.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done — bolded Concierge in the FAQ answer for consistency with the Web/Mobile sections. Search-and-Download-Expenses.md:107


- **Basic Export**: Downloads immediately to your device.
- **All other templates**: Concierge will send the export file to you via direct message.
A status window appears while your file is prepared, and the file downloads automatically when it’s ready (if it doesn’t, use the **Download file** button). If you’d rather not wait, click **Send me the file when it’s ready** and Concierge will send it to you in a chat message.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cross-platform clarity: This FAQ answer applies to both web and mobile, but it uses web-only verbs ("click", "use the Download file button"). Per HELPSITE_NAMING_CONVENTIONS.md (Cross-Platform Clarity Rule), don't assume parity — either use platform-neutral wording or specify web vs mobile (e.g., "click/tap"). The web (line 33) and mobile (line 46) sections correctly differentiate "click" vs "tap".

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done — changed "click" to "click/tap" so the FAQ answer covers both web and mobile. Search-and-Download-Expenses.md:107

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR updates Search-and-Download-Expenses.md to describe the new CSV/template export flow, where an in-app status window appears and the file downloads automatically (with the option to have Concierge send it instead). The change is limited to three prose paragraphs (Export as CSV -> Web, Export as CSV -> Mobile, and the FAQ "How do I receive my export?"). The proposed copy is accurate, well-written, and uses UI labels verified against en.ts (exportDownload). No headings, metadata, or structure were altered.

Scores Summary

  • Readability: 8/10 - Sentences are clear, action-oriented, and platform-aware (click vs. tap). Minor nit: each paragraph is fairly dense and uses an em dash mid-sentence; breaking the download fallback into its own sentence or a short list would improve scannability.
  • AI Readiness: 8/10 - Copy uses full feature/label names (Download file, Send me the file when it is ready, Concierge) and reinforces real search intent ("how do I receive my export?"). Scoped to the diff, no metadata/heading changes were needed and none regressed.
  • Style Compliance: 9/10 - Button labels are bolded in Sentence case and match the UI exactly per the Naming Conventions. Concierge is consistently bolded in the body. One minor inconsistency: in the FAQ paragraph "Concierge" is not bolded, whereas it is bolded in the Web/Mobile sections—align for consistency.

Key Findings

  • Strong, verifiable use of exact UI labels (cross-checked against the exportDownload translation strings), satisfying the core UI Referencing Rules.
  • Correct platform-specific phrasing: "click" on Web, "tap" on Mobile.
  • The PR author flagged an unverified nuance: a single-selection Basic Export still downloads immediately without the status window, while select-all and template exports use the status window. The new FAQ text now describes only the status-window path, which may be slightly incomplete for the Basic Export single-selection case. Worth confirming before merge.
  • Minor: inconsistent bolding of Concierge between the FAQ and the body sections.

Recommendations

  • Confirm the Basic Export single-selection behavior and, if it still downloads immediately without a status window, restore a short note so the FAQ remains accurate for that path.
  • Bold Concierge in the FAQ answer to match the Web/Mobile sections.
  • Optional readability: split the download-fallback clause into its own sentence (instead of an em dash) for easier scanning.

Files Reviewed

  • docs/articles/new-expensify/reports-and-expenses/Search-and-Download-Expenses.md - 3 prose updates; accurate and compliant, with two minor items above.

Note: Detailed line-by-line feedback has been provided as inline comments.

@truph01

truph01 commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot Resolve all above comments

Co-authored-by: truph01 <truph01@users.noreply.github.com>
@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://f6625150.helpdot.pages.dev ⚡️

Updated articles:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants