[No QA] Docs updates for E/A#92169 CSV export download status modal flow#93890
[No QA] Docs updates for E/A#92169 CSV export download status modal flow#93890MelvinBot wants to merge 2 commits into
Conversation
Co-authored-by: truph01 <truph01@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
|
@MelvinBot Mark this PR as ready for review |
|
|
||
| - **Basic Export**: Downloads immediately to your device. | ||
| - **All other templates**: Concierge will send the export file to you via direct message. | ||
| A status window appears while your file is prepared, and the file downloads automatically when it’s ready (if it doesn’t, use the **Download file** button). If you’d rather not wait, click **Send me the file when it’s ready** and Concierge will send it to you in a chat message. |
There was a problem hiding this comment.
Inconsistent UI/term formatting (Deterministic Writing Rule): "Concierge" is bolded as Concierge on the changed web (line 33) and mobile (line 46) lines, but here it is plain text. Per HELPSITE_NAMING_CONVENTIONS.md (Deterministic Writing Rule: "Be consistent. Avoid stylistic variation."), reference Concierge the same way throughout — use Concierge.
There was a problem hiding this comment.
Done — bolded Concierge in the FAQ answer for consistency with the Web/Mobile sections. Search-and-Download-Expenses.md:107
|
|
||
| - **Basic Export**: Downloads immediately to your device. | ||
| - **All other templates**: Concierge will send the export file to you via direct message. | ||
| A status window appears while your file is prepared, and the file downloads automatically when it’s ready (if it doesn’t, use the **Download file** button). If you’d rather not wait, click **Send me the file when it’s ready** and Concierge will send it to you in a chat message. |
There was a problem hiding this comment.
Cross-platform clarity: This FAQ answer applies to both web and mobile, but it uses web-only verbs ("click", "use the Download file button"). Per HELPSITE_NAMING_CONVENTIONS.md (Cross-Platform Clarity Rule), don't assume parity — either use platform-neutral wording or specify web vs mobile (e.g., "click/tap"). The web (line 33) and mobile (line 46) sections correctly differentiate "click" vs "tap".
There was a problem hiding this comment.
Done — changed "click" to "click/tap" so the FAQ answer covers both web and mobile. Search-and-Download-Expenses.md:107
HelpDot Documentation ReviewOverall AssessmentThis PR updates Search-and-Download-Expenses.md to describe the new CSV/template export flow, where an in-app status window appears and the file downloads automatically (with the option to have Concierge send it instead). The change is limited to three prose paragraphs (Export as CSV -> Web, Export as CSV -> Mobile, and the FAQ "How do I receive my export?"). The proposed copy is accurate, well-written, and uses UI labels verified against en.ts (exportDownload). No headings, metadata, or structure were altered. Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
|
@MelvinBot Resolve all above comments |
Co-authored-by: truph01 <truph01@users.noreply.github.com>
|
A preview of your ExpensifyHelp changes have been deployed to https://f6625150.helpdot.pages.dev ⚡️ Updated articles: |
Why
Expensify/App#92169 wires the new
ExportDownloadStatusModalinto the Search bulk-export (CSV/template) flow. Exports no longer always arrive as a Concierge direct message — instead, an in-app status window appears while the file is prepared and the file downloads directly in the app when ready, with the option to have Concierge send it instead.What changed
Updated
docs/articles/new-expensify/reports-and-expenses/Search-and-Download-Expenses.mdto describe the new flow in three places:UI labels used (verified against
src/languages/en.tsexportDownload): Download file, Send me the file when it's ready, Go to Concierge.Note for reviewer
I verified the new copy against the PR's source and the
exportDownloadtranslation strings, but I did not exercise the live UI. One nuance not spelled out in the article: a single-selection Basic Export still downloads immediately without the status window, while select-all and template exports now use the status window. Please confirm whether the article should call out that distinction.@truph01, please review the files changed and confirm they reflect the current behavior. Then mark this PR
Ready for review.