fix: prevent signing from wrong key in multisig#1319
Merged
ulbqb merged 5 commits intoFinschia:mainfrom Mar 28, 2024
Merged
Conversation
ulbqb
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1319 +/- ##
==========================================
- Coverage 70.41% 70.39% -0.03%
==========================================
Files 643 643
Lines 54752 54779 +27
==========================================
+ Hits 38556 38564 +8
- Misses 14021 14040 +19
Partials 2175 2175
|
ulbqb
requested review from
0Tech,
jaeseung-bae,
tkxkd0159 and
zemyblue
as code owners
jaeseung-bae
approved these changes
Mar 27, 2024
0Tech
approved these changes
Mar 28, 2024
mergify bot
pushed a commit
that referenced
this pull request
Mar 28, 2024
* Add multisig check * Update CHANGELOG * Update CHANGELOG.md (cherry picked from commit c051dcc) # Conflicts: # CHANGELOG.md
5 tasks
0Tech
added a commit
that referenced
this pull request
Mar 29, 2024
* fix: prevent signing from wrong key in multisig (#1319) * Add multisig check * Update CHANGELOG * Update CHANGELOG.md (cherry picked from commit c051dcc) # Conflicts: # CHANGELOG.md * Update CHANGELOG.md --------- Co-authored-by: Shogo Hyodo <mmoshg8u@gmail.com> Co-authored-by: Youngtaek Yoon <noreply@yoon.mailer.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
When signing an multisig tx, you are required to provide the multisig address (--multisig) and the key you are signing with (--from), but there's no check that the key is actually part of the multisig. This makes it very easy to accidentally sign with the wrong key and only figure it out when you try to broadcast the invalid tx that includes a signature from a key thats not in the multisig.
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml