fix: prevent signing from wrong key in multisig (backport #1319)#1324
Merged
0Tech merged 3 commits intorelease/v0.48.xfrom Mar 29, 2024
Merged
fix: prevent signing from wrong key in multisig (backport #1319)#13240Tech merged 3 commits intorelease/v0.48.xfrom
0Tech merged 3 commits intorelease/v0.48.xfrom
Conversation
* Add multisig check * Update CHANGELOG * Update CHANGELOG.md (cherry picked from commit c051dcc) # Conflicts: # CHANGELOG.md
Contributor
Author
|
Cherry-pick of c051dcc has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/v0.48.x #1324 +/- ##
===================================================
- Coverage 69.78% 69.76% -0.02%
===================================================
Files 646 646
Lines 67507 67573 +66
===================================================
+ Hits 47109 47142 +33
- Misses 18212 18242 +30
- Partials 2186 2189 +3
|
0Tech
reviewed
Mar 29, 2024
0Tech
approved these changes
Mar 29, 2024
jaeseung-bae
approved these changes
Mar 29, 2024
zemyblue
approved these changes
Mar 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
When signing an multisig tx, you are required to provide the multisig address (--multisig) and the key you are signing with (--from), but there's no check that the key is actually part of the multisig. This makes it very easy to accidentally sign with the wrong key and only figure it out when you try to broadcast the invalid tx that includes a signature from a key thats not in the multisig.
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yamlThis is an automatic backport of pull request #1319 done by [Mergify](https://mergify.com).