Skip to content

Release/v0.13.0#114

Open
PTaylor-us wants to merge 24 commits into
masterfrom
release/v0.13.0
Open

Release/v0.13.0#114
PTaylor-us wants to merge 24 commits into
masterfrom
release/v0.13.0

Conversation

@PTaylor-us

@PTaylor-us PTaylor-us commented Aug 28, 2021

Copy link
Copy Markdown
Member

Features

  • Generic add/sub
  • sub-unity units (milli, micro, etc) (pushing to later release)
  • feature support for defmt

Changes

  • consistent integer() return types

@PTaylor-us PTaylor-us modified the milestone: v0.13.0 Aug 29, 2021
@PTaylor-us PTaylor-us linked an issue Aug 29, 2021 that may be closed by this pull request
…ric_ Duration and Rate handling

- removed impl of Duration and Rate from `Generic` types
@korken89

korken89 commented Sep 2, 2021

Copy link
Copy Markdown
Collaborator

Great to see this getting released!

@burrbull

burrbull commented Oct 6, 2021

Copy link
Copy Markdown

On my machine read_timer test fails time to time.

running 4 tests
test periodic_expiration ... ok
test oneshot_wait ... ok
test read_timer ... FAILED
test periodic_wait ... ok

failures:

---- read_timer stdout ----
thread 'read_timer' panicked at 'assertion failed: `(left == right)`
  left: `Ok(Seconds(1))`,
 right: `Ok(Seconds(0))`', tests/timer.rs:105:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


failures:
    read_timer

test result: FAILED. 3 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

Fixed generic comparison where the destination integer is larger
@PTaylor-us

Copy link
Copy Markdown
Member Author

On my machine read_timer test fails time to time.

@burrbull That sounds like a timing issue if the tests are run multithreaded. Using the --test-threads=1 option may clear this up. (see https://github.com/FluenTech/embedded-time/blob/master/.github/workflows/ci.yml)

@ghost

ghost commented Jan 4, 2022

Copy link
Copy Markdown

Any news on when this might get released? I can't upgrade rtic to 1.0 without the changes in this branch.

@burrbull

burrbull commented Jan 4, 2022

Copy link
Copy Markdown

Any news on when this might get released? I can't upgrade rtic to 1.0 without the changes in this branch.

RTIC 1.0 depends on fugit, not embedded-time

@ghost

ghost commented Jan 4, 2022

Copy link
Copy Markdown

Any news on when this might get released? I can't upgrade rtic to 1.0 without the changes in this branch.

RTIC 1.0 depends on fugit, not embedded-time

According to this: rtic-rs/rtic#578 that is not the case

@korken89

korken89 commented Jan 4, 2022

Copy link
Copy Markdown
Collaborator

Both work :)

@ghost

ghost commented Aug 21, 2022

Copy link
Copy Markdown

It's been a year since this PR was opened and 8 months since the last comment, how's progress going on this release? Is there anywhere that needs additional assistance I or others may be able to provide to get this to the finish line?

Particularly I'm in need of the change for the Generic duration not implementing FixedPoint, which in my case blocks me from doing clock.new_timer(generic_duration).

@SimonIT

SimonIT commented Aug 10, 2025

Copy link
Copy Markdown

@PTaylor-us is there a schedule for this PR? There hasn't been any activity for a couple of years...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duration from checked_duration_since cannot be added with Instant?

6 participants