Fix deleted videos appears when another video added to another playlist#7681
Merged
FreeTubeBot merged 2 commits intoFreeTubeApp:developmentfrom Jul 28, 2025
Merged
Conversation
PikachuEXE
requested review from
ChunkyProgrammer,
absidue and
efb4f5ff-1298-471a-8973-3d47447115dc
github-actions
bot
added
the
PR: waiting for review
1 task
PikachuEXE
changed the title
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Jul 16, 2025
absidue
approved these changes
Jul 20, 2025
Member
|
@ChunkyProgrammer @MarmadileManteater @kommunarr could you prioritise reviewing this whenever you have the time for it. It would be the last commit I need to cherry pick for #7670. More info on that in Matrix Dev channel |
efb4f5ff-1298-471a-8973-3d47447115dc
requested review from
MarmadileManteater and
kommunarr
ChunkyProgrammer
approved these changes
Jul 28, 2025
github-actions
bot
removed
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
pushed a commit
to efb4f5ff-1298-471a-8973-3d47447115dc/FreeTube
that referenced
this pull request
Jul 28, 2025
…st (FreeTubeApp#7681) * $ Rename local data, extra timeout value * ! Fix deleted videos appears when another video added to another playlist
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Jul 29, 2025
* development: (192 commits) Translated using Weblate (Japanese) Fix scroll to seek/change volume/playback rate changing too fast with touchpad (FreeTubeApp#6666) Move General section within the Distraction Free Settings to top (FreeTubeApp#7719) Fix deleted videos appears when another video added to another playlist (FreeTubeApp#7681) Change Settings order (FreeTubeApp#7722) Migrate Subscriptions{Videos,Live,Shorts,Posts} to the composition API (FreeTubeApp#7717) Translated using Weblate (Romanian) Translated using Weblate (German) Migrate the FtToggleSwitch component to the composition API (FreeTubeApp#7740) Add missing FontAwesomeIcon imports to `<script setup>` components (FreeTubeApp#7739) Translated using Weblate (Spanish) Translated using Weblate (French) Translated using Weblate (Basque) Translated using Weblate (Chinese (Simplified Han script)) Translated using Weblate (Breton) Translated using Weblate (Estonian) Translated using Weblate (Italian) Translated using Weblate (Tamil) Translated using Weblate (Czech) Translated using Weblate (Hungarian) ... # Conflicts: # package.json # src/renderer/components/ft-shaka-video-player/ft-shaka-video-player.js # src/renderer/helpers/api/local.js # yarn.lock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
Closes #7678
Description
Bug happens due to user playlist updated and local state (playlist items) was manipulated directly to affect the displayed items
Updated to show calculated shown items (existing items - to be deleted items) which works even user playlist re-parsed
Screenshots
Testing
The case in #7678
Previous PRs for undo
Online playlist should not be affected but should be tested
Except there is an error when I try to load more in an online playlist
Desktop
Additional context