Skip to content

Change Settings order#7722

Merged
FreeTubeBot merged 2 commits intoFreeTubeApp:developmentfrom
efb4f5ff-1298-471a-8973-3d47447115dc:change-settings-order
Jul 27, 2025
Merged

Change Settings order#7722
FreeTubeBot merged 2 commits intoFreeTubeApp:developmentfrom
efb4f5ff-1298-471a-8973-3d47447115dc:change-settings-order

Conversation

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc commented Jul 21, 2025 •
edited
Loading

Pull Request Type

  • Visual change

Related issue

#7719

Description

This PR tries to implement logical changes to the order of the Settings.

Old Order New Order
1. General 1. General
2. Theme 2. Theme
3. Player 3. Player
4. External Player 4. External Player
5. Subscription 5. Subscription
6. Distraction Free 6. Distraction Free
7. Privacy 7. Parental control
8. Data 8. Privacy
9. Proxy 9. Data
10. Download 10. Proxy
11. Parental control 11. Download
12. SponsorBlock 12. SponsorBlock
13. Experimental 13. Password
14. Password 14. Experimental
  • 7 = Parental controls, because it makes more sense to group that with 6
  • 13 = Password, see reasoning 14
  • 14 = Experimental, last because settings that are not part of "Normal" settings belong at the bottom

Testing

  1. Go to Settings
  2. Observe Setting order changes

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) July 21, 2025 21:40
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jul 21, 2025
@PikachuEXE
Copy link
Member

PikachuEXE commented Jul 22, 2025

I think password should still be at the end coz it doesn't make sense to lock settings before I read all the settings section before (unless you jump to password section)
Parental control is for other users not myself so I am not so sure if that should even be moved...

I would at most swap 11 & 12 (from old) or move 11 to 13

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member Author

efb4f5ff-1298-471a-8973-3d47447115dc commented Jul 22, 2025 •
edited
Loading

I think password should still be at the end coz it doesn't make sense to lock settings before I read all the settings section before

An user reads all the settings the first time they install an application and maybe after an update. Not all the time. What you're saying resonates more to us doing that allot because of testing and what not

Parental control is for other users not myself so I am not so sure if that should even be moved...

Distraction Free Settings and Parental Control do the same they hide elements from the user thats why i grouped them. The only real difference is the target audience

I would at most swap 11 & 12 (from old) or move 11 to 13

umm im not following... what would you like to be moved around from the new list?

@PikachuEXE
Copy link
Member

PikachuEXE commented Jul 23, 2025

I would still say SponsorBlock IS part of the app (just disabled by default like IV API, proxy, external player...
Swap 12 & 13 in new list then it's fine

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member Author

efb4f5ff-1298-471a-8973-3d47447115dc commented Jul 23, 2025

I would still say SponsorBlock IS part of the app (just disabled by default like IV API, proxy, external player... Swap 12 & 13 in new list then it's fine

Sure that reasoning makes sense

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member Author

efb4f5ff-1298-471a-8973-3d47447115dc commented Jul 23, 2025

Done

@FreeTubeBot FreeTubeBot merged commit b7504bb into FreeTubeApp:development Jul 27, 2025
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Jul 27, 2025
@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc deleted the change-settings-order branch July 27, 2025 21:46
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Jul 29, 2025
@PikachuEXE
Merge branch 'development' into sabr-pika-2
215cc65 
* development: (192 commits)
  Translated using Weblate (Japanese)
  Fix scroll to seek/change volume/playback rate changing too fast with touchpad (FreeTubeApp#6666)
  Move General section within the Distraction Free Settings to top (FreeTubeApp#7719)
  Fix deleted videos appears when another video added to another playlist (FreeTubeApp#7681)
  Change Settings order (FreeTubeApp#7722)
  Migrate Subscriptions{Videos,Live,Shorts,Posts} to the composition API (FreeTubeApp#7717)
  Translated using Weblate (Romanian)
  Translated using Weblate (German)
  Migrate the FtToggleSwitch component to the composition API (FreeTubeApp#7740)
  Add missing FontAwesomeIcon imports to `<script setup>` components (FreeTubeApp#7739)
  Translated using Weblate (Spanish)
  Translated using Weblate (French)
  Translated using Weblate (Basque)
  Translated using Weblate (Chinese (Simplified Han script))
  Translated using Weblate (Breton)
  Translated using Weblate (Estonian)
  Translated using Weblate (Italian)
  Translated using Weblate (Tamil)
  Translated using Weblate (Czech)
  Translated using Weblate (Hungarian)
  ...

# Conflicts:
#	package.json
#	src/renderer/components/ft-shaka-video-player/ft-shaka-video-player.js
#	src/renderer/helpers/api/local.js
#	yarn.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PikachuEXE PikachuEXE PikachuEXE approved these changes

@absidue absidue absidue approved these changes

@ChunkyProgrammer ChunkyProgrammer ChunkyProgrammer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@efb4f5ff-1298-471a-8973-3d47447115dc @PikachuEXE @absidue @ChunkyProgrammer @FreeTubeBot