Skip to content

Move General section within the Distraction Free Settings to top#7719

Merged
FreeTubeBot merged 7 commits intoFreeTubeApp:developmentfrom
efb4f5ff-1298-471a-8973-3d47447115dc:change-distraction-settings-order
Jul 28, 2025
Merged

Move General section within the Distraction Free Settings to top#7719
FreeTubeBot merged 7 commits intoFreeTubeApp:developmentfrom
efb4f5ff-1298-471a-8973-3d47447115dc:change-distraction-settings-order

Conversation

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc commented Jul 21, 2025

Pull Request Type

  • Visual change

Description

General being at the bottom of the the Distraction Free Settings seems a bit silly so i moved it to the top to make to make the order of the sections more logical

Screenshots

VirtualBoxVM_VJwMLTsGyR

Testing

  1. Go to the Distraction Free Settings
  2. Check if General section is the first one listed

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jul 21, 2025
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) July 21, 2025 14:30
@PikachuEXE
Copy link
Member

I think the spacing between the box and the group title need some adjustment...
Existing (0.5em
image

2em
image

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member Author

efb4f5ff-1298-471a-8973-3d47447115dc commented Jul 22, 2025

I think the spacing between the box and the group title need some adjustment.

Good catch. What would be best here. Create a separate class for this case?

So it would be the same as this but just with 2.0em

:deep(.groupTitle) {
text-align: center;
margin-block: 0.5em;
}

@PikachuEXE
Copy link
Member

Add class name for Settings.Distraction Free Settings.Hide Videos and Playlists Containing Text (or the flex box
And add margin-block-end 2.0em (as in keep your distance from my butt

Co-Authored-By: PikachuEXE <1018543+PikachuEXE@users.noreply.github.com>
Co-Authored-By: absidue <48293849+absidue@users.noreply.github.com>
This reverts commit b1a7796.
Co-Authored-By: PikachuEXE <1018543+PikachuEXE@users.noreply.github.com>
Co-Authored-By: absidue <48293849+absidue@users.noreply.github.com>
@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member Author

Srry i tested something very unrelated and noticed i pushed it towards this branch. Reverted those commits and have added the proper code now

@FreeTubeBot FreeTubeBot merged commit 00d4695 into FreeTubeApp:development Jul 28, 2025
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Jul 28, 2025
@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc deleted the change-distraction-settings-order branch July 28, 2025 08:22
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Jul 29, 2025
* development: (192 commits)
  Translated using Weblate (Japanese)
  Fix scroll to seek/change volume/playback rate changing too fast with touchpad (FreeTubeApp#6666)
  Move General section within the Distraction Free Settings to top (FreeTubeApp#7719)
  Fix deleted videos appears when another video added to another playlist (FreeTubeApp#7681)
  Change Settings order (FreeTubeApp#7722)
  Migrate Subscriptions{Videos,Live,Shorts,Posts} to the composition API (FreeTubeApp#7717)
  Translated using Weblate (Romanian)
  Translated using Weblate (German)
  Migrate the FtToggleSwitch component to the composition API (FreeTubeApp#7740)
  Add missing FontAwesomeIcon imports to `<script setup>` components (FreeTubeApp#7739)
  Translated using Weblate (Spanish)
  Translated using Weblate (French)
  Translated using Weblate (Basque)
  Translated using Weblate (Chinese (Simplified Han script))
  Translated using Weblate (Breton)
  Translated using Weblate (Estonian)
  Translated using Weblate (Italian)
  Translated using Weblate (Tamil)
  Translated using Weblate (Czech)
  Translated using Weblate (Hungarian)
  ...

# Conflicts:
#	package.json
#	src/renderer/components/ft-shaka-video-player/ft-shaka-video-player.js
#	src/renderer/helpers/api/local.js
#	yarn.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants