Skip to content

[Feature]: Hide videos immediately when marking as watched#7866

Merged
FreeTubeBot merged 6 commits intoFreeTubeApp:developmentfrom
palharesf:fix/5401-new
Sep 16, 2025
Merged

[Feature]: Hide videos immediately when marking as watched#7866
FreeTubeBot merged 6 commits intoFreeTubeApp:developmentfrom
palharesf:fix/5401-new

Conversation

@palharesf
Copy link
Contributor

@palharesf palharesf commented Aug 18, 2025 •
edited
Loading

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

Closes #5401

Description

Currently, when the 'Hide Videos on Watch' setting is enabled and videos are marked as watched manually via the dropdown menu, that video is shown as watched (greyed out) but doesn't disappear until the page is refreshed.

With the proposed changes, marking the video as watched immediately hides that video from the video list.

Screenshots

Current behavior:
Animation_0

Proposed behavior:
Animation

Testing

(A)

  • Navigate to 'Settings' --> 'Subscription'
  • Enable 'Hide Videos on Watch'
  • Subscribe a profile with unwatched videos (to ensure at least one video shows up in the 'Subscriptions' page)
  • Navigate to 'Subscriptions' page (ensure at least one unwatched video is available)
  • On the video card, click on the dropdown menu (three vertical dots) --> 'Mark as Watched'
  • Video should disappear automatically and toast should be displayed
  • To ensure proper functionality, navigate to 'History' -- the video should be listed there

Desktop

  • OS: Windows
  • OS Version: Windows 11 Pro 24H2 build 26100.4946
  • FreeTube version: v0.23.7 Beta

Additional context

The enhancement also works for the 'Live' and 'Shorts' tabs of the 'Subscriptions' page

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Aug 18, 2025
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) August 18, 2025 17:35
@palharesf palharesf changed the title Refactor activeVideoList to use filteredVideoList and exclude watched videos from videoList [Feature Request]: Hide videos immediately when marking as watched, if 'hide videos on watch' is enabled Aug 18, 2025
@palharesf palharesf changed the title [Feature Request]: Hide videos immediately when marking as watched, if 'hide videos on watch' is enabled [Feature]: Hide videos immediately when marking as watched Aug 18, 2025
absidue
absidue reviewed Aug 24, 2025
View reviewed changes
absidue
absidue reviewed Aug 24, 2025
View reviewed changes
Copy link
Member

@absidue absidue left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also forgot to remove the filtering code in the original location, so it is currently doing the filtering twice (in my advice on the issue I specifically said move, not copy).

@absidue absidue added PR: changes requested and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Aug 24, 2025
auto-merge was automatically disabled August 24, 2025 23:45

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) August 24, 2025 23:46
@palharesf
Copy link
Contributor Author

palharesf commented Aug 24, 2025

I added the requested computer property. Apologies about the subscription.js file, I failed to notice the filtering was duplicated. Thank you for letting me know

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2025

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@PikachuEXE PikachuEXE added PR: waiting for review For PRs that are complete, tested, and ready for review and removed PR: stale PR: changes requested labels Sep 8, 2025
absidue
absidue reviewed Sep 14, 2025
View reviewed changes
efb4f5ff-1298-471a-8973-3d47447115dc
efb4f5ff-1298-471a-8973-3d47447115dc previously approved these changes Sep 15, 2025
View reviewed changes
Copy link
Member

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

absidue
absidue previously approved these changes Sep 15, 2025
View reviewed changes
@absidue absidue self-requested a review September 15, 2025 16:23
absidue
absidue reviewed Sep 15, 2025
View reviewed changes
@absidue absidue dismissed stale reviews from efb4f5ff-1298-471a-8973-3d47447115dc and themself via 9e7b583 September 15, 2025 16:33
@FreeTubeBot FreeTubeBot merged commit 4b72084 into FreeTubeApp:development Sep 16, 2025
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Sep 16, 2025
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Sep 17, 2025
@PikachuEXE
Merge branch 'development' into custom-builds/sabr
dc33ee5 
* development:
  Translated using Weblate (Portuguese (Brazil))
  Update shaka-player to 4.16.x (FreeTubeApp#7919)
  Translated using Weblate (Portuguese (Brazil))
  Translated using Weblate (Portuguese (Brazil))
  [Feature]: Hide videos immediately when marking as watched (FreeTubeApp#7866)
  Bump actions/setup-node from 4 to 5 (FreeTubeApp#8000)
PikachuEXE added a commit to NishPatel101/FreeTube that referenced this pull request Sep 17, 2025
@PikachuEXE
Merge branch 'development' into feat/clickable-playlist-progressbar
42afcf5 
* development: (65 commits)
  Translated using Weblate (Portuguese (Brazil))
  Update shaka-player to 4.16.x (FreeTubeApp#7919)
  Translated using Weblate (Portuguese (Brazil))
  Translated using Weblate (Portuguese (Brazil))
  [Feature]: Hide videos immediately when marking as watched (FreeTubeApp#7866)
  Bump actions/setup-node from 4 to 5 (FreeTubeApp#8000)
  Bump mikefarah/yq from 4.47.1 to 4.47.2 (FreeTubeApp#8039)
  Bump marked from 16.2.1 to 16.3.0 (FreeTubeApp#8040)
  Bump eslint-plugin-jsdoc from 57.0.3 to 57.0.8 in the eslint group (FreeTubeApp#8038)
  Adjust homebrew link to maintainers tap (FreeTubeApp#8041)
  Remove n argument in sed (FreeTubeApp#8033)
  Translated using Weblate (Russian)
  Bump eslint-plugin-jsdoc from 56.1.2 to 57.0.3 in the eslint group (FreeTubeApp#8030)
  Bump youtubei.js from 15.1.0 to 15.1.1 (FreeTubeApp#8031)
  Translated using Weblate (Polish)
  Bump eslint-plugin-jsdoc from 55.0.0 to 56.1.2 in the eslint group (FreeTubeApp#8020)
  Bump lefthook from 1.12.4 to 1.13.0 (FreeTubeApp#8026)
  Bump swiper from 11.2.10 to 12.0.1 (FreeTubeApp#8024)
  Bump globals from 16.3.0 to 16.4.0 (FreeTubeApp#8023)
  Bump package version from 0.23.8 to 0.23.9 (FreeTubeApp#8027)
  ...
caetano-dev pushed a commit to caetano-dev/FreeTube that referenced this pull request Sep 17, 2025
@palharesf @absidue @caetano-dev
[Feature]: Hide videos immediately when marking as watched (FreeTubeA…
0588499 
…pp#7866)

* Add computed properties for history cache and filtered video list

* Refactor activeVideoList to use filteredVideoList and exclude watched videos from videoList

* Creating a computed property to de-couple filteredVideoList from the store getters (SRP)

* Transferred filtering logic to SubscriptionsTabUi component

* Fix variable name

* Don't try to filter videos on the posts tab

---------

Co-authored-by: absidue <48293849+absidue@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PikachuEXE PikachuEXE PikachuEXE approved these changes

@absidue absidue absidue approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Hide videos immediately when marking as watched, if 'hide videos on watch' is enabled.

5 participants

@palharesf @PikachuEXE @absidue @efb4f5ff-1298-471a-8973-3d47447115dc @FreeTubeBot