Skip to content

Adjust homebrew link to maintainers tap#8041

Merged
FreeTubeBot merged 3 commits intoFreeTubeApp:developmentfrom
kokomo123:patch-1
Sep 15, 2025
Merged

Adjust homebrew link to maintainers tap#8041
FreeTubeBot merged 3 commits intoFreeTubeApp:developmentfrom
kokomo123:patch-1

Conversation

@kokomo123
Copy link
Contributor

@kokomo123 kokomo123 commented Sep 15, 2025 •
edited
Loading

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

Description

As homebrew officially deprecated the official cask back on September 1st, it feels appropriate to adjust this to Pikachu's tap on github instead. There should be minimal impacts to people using this tap instead of the official one, hopefully.

Screenshots

Testing

By uninstalling the freetube unofficial homebrew cask from the main repository, and reinstalling using pikachu's tap (provided you have an apple silicon mac)

Desktop

  • OS:
  • OS Version:
  • FreeTube version:

Additional context

N/A, but if there's any concerns, comments, suggestions, please let me know!

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Sep 15, 2025
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) September 15, 2025 10:53
auto-merge was automatically disabled September 15, 2025 11:08

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) September 15, 2025 11:08
@kokomo123 kokomo123 changed the title Adjust homebrew link to maintainers tap instead Adjust homebrew link to maintainers tap, and brew.sh (for intel) Sep 15, 2025
@kokomo123
Copy link
Contributor Author

kokomo123 commented Sep 15, 2025

I added back the brew.sh link as I have seen the maintainers of homebrew-cask still merge updates with freetube, even though it is disabled/deprecated and unsigned. So, I might just recommend the intel build from homebrew cask (however long that's maintained for) and apple silicon with pikachu's unofficial tap. I am open to hearing other's thoughts on the matter.

efb4f5ff-1298-471a-8973-3d47447115dc
efb4f5ff-1298-471a-8973-3d47447115dc reviewed Sep 15, 2025
View reviewed changes
Copy link
Member

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i prefer removing links to the deprecated one even though it still receives updates for a unknown amount of time

@PikachuEXE
Copy link
Member

PikachuEXE commented Sep 15, 2025

We still got dmg for intel one so I am fine with removing deprecated intel tap

auto-merge was automatically disabled September 15, 2025 18:47

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) September 15, 2025 18:47
@kokomo123 kokomo123 changed the title Adjust homebrew link to maintainers tap, and brew.sh (for intel) Adjust homebrew link to maintainers tap Sep 15, 2025
@kokomo123
Copy link
Contributor Author

kokomo123 commented Sep 15, 2025

Pushed, thank you for the feedback! :)

@FreeTubeBot FreeTubeBot merged commit 10163fa into FreeTubeApp:development Sep 15, 2025
6 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Sep 15, 2025
@kokomo123 kokomo123 deleted the patch-1 branch September 15, 2025 21:27
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Sep 15, 2025
@PikachuEXE
Merge branch 'development' into custom-builds/sabr
712d046 
* development: (31 commits)
  Bump mikefarah/yq from 4.47.1 to 4.47.2 (FreeTubeApp#8039)
  Bump marked from 16.2.1 to 16.3.0 (FreeTubeApp#8040)
  Bump eslint-plugin-jsdoc from 57.0.3 to 57.0.8 in the eslint group (FreeTubeApp#8038)
  Adjust homebrew link to maintainers tap (FreeTubeApp#8041)
  Remove n argument in sed (FreeTubeApp#8033)
  Translated using Weblate (Russian)
  Bump eslint-plugin-jsdoc from 56.1.2 to 57.0.3 in the eslint group (FreeTubeApp#8030)
  Bump youtubei.js from 15.1.0 to 15.1.1 (FreeTubeApp#8031)
  Translated using Weblate (Polish)
  Bump eslint-plugin-jsdoc from 55.0.0 to 56.1.2 in the eslint group (FreeTubeApp#8020)
  Bump lefthook from 1.12.4 to 1.13.0 (FreeTubeApp#8026)
  Bump swiper from 11.2.10 to 12.0.1 (FreeTubeApp#8024)
  Bump globals from 16.3.0 to 16.4.0 (FreeTubeApp#8023)
  Bump package version from 0.23.8 to 0.23.9 (FreeTubeApp#8027)
  Bump youtubei.js from 15.0.1 to 15.1.0 (FreeTubeApp#8022)
  Add Workflow to Automate Updating the Website Version Number (FreeTubeApp#7989)
  Translated using Weblate (Czech)
  Translated using Weblate (Dutch)
  Translated using Weblate (Icelandic)
  Bump sass from 1.91.0 to 1.92.1 (FreeTubeApp#8003)
  ...

# Conflicts:
#	package.json
PikachuEXE added a commit to NishPatel101/FreeTube that referenced this pull request Sep 17, 2025
@PikachuEXE
Merge branch 'development' into feat/clickable-playlist-progressbar
42afcf5 
* development: (65 commits)
  Translated using Weblate (Portuguese (Brazil))
  Update shaka-player to 4.16.x (FreeTubeApp#7919)
  Translated using Weblate (Portuguese (Brazil))
  Translated using Weblate (Portuguese (Brazil))
  [Feature]: Hide videos immediately when marking as watched (FreeTubeApp#7866)
  Bump actions/setup-node from 4 to 5 (FreeTubeApp#8000)
  Bump mikefarah/yq from 4.47.1 to 4.47.2 (FreeTubeApp#8039)
  Bump marked from 16.2.1 to 16.3.0 (FreeTubeApp#8040)
  Bump eslint-plugin-jsdoc from 57.0.3 to 57.0.8 in the eslint group (FreeTubeApp#8038)
  Adjust homebrew link to maintainers tap (FreeTubeApp#8041)
  Remove n argument in sed (FreeTubeApp#8033)
  Translated using Weblate (Russian)
  Bump eslint-plugin-jsdoc from 56.1.2 to 57.0.3 in the eslint group (FreeTubeApp#8030)
  Bump youtubei.js from 15.1.0 to 15.1.1 (FreeTubeApp#8031)
  Translated using Weblate (Polish)
  Bump eslint-plugin-jsdoc from 55.0.0 to 56.1.2 in the eslint group (FreeTubeApp#8020)
  Bump lefthook from 1.12.4 to 1.13.0 (FreeTubeApp#8026)
  Bump swiper from 11.2.10 to 12.0.1 (FreeTubeApp#8024)
  Bump globals from 16.3.0 to 16.4.0 (FreeTubeApp#8023)
  Bump package version from 0.23.8 to 0.23.9 (FreeTubeApp#8027)
  ...
caetano-dev pushed a commit to caetano-dev/FreeTube that referenced this pull request Sep 17, 2025
@kokomo123 @caetano-dev
Adjust homebrew link to maintainers tap (FreeTubeApp#8041)
8a1541c 
* Adjust homebrew link to maintainers tap instead

* Add back intel link, and separate intel and apple silicon download links.

* Remove Deprecated Intel Tap per maintainer feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PikachuEXE PikachuEXE PikachuEXE approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@kommunarr kommunarr kommunarr approved these changes

@absidue absidue Awaiting requested review from absidue

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kokomo123 @PikachuEXE @efb4f5ff-1298-471a-8973-3d47447115dc @kommunarr @FreeTubeBot