Update shaka-player to 4.16.x by absidue · Pull Request #7919 · FreeTubeApp/FreeTube

absidue · 2025-08-24T14:28:06Z

Pull Request Type

Feature Implementation
Other

Related issue

Description

shaka-player 4.15 includes a redesigned player UI, which required a few changes to our custom player components as well as the CSS. As the UI changes increase the spacing between the player buttons, I also thought this was a good momement to address Move player controls to the overflow menu which we have been planning to do for a while now. Additionally I switched our audio track selector over to the new getAudioTracks() and selectAudioTrack() API.

shaka-player 4.16 changed from using the Material Icons font in the CSS file to using SVGs created via JavaScript, this does mean that the JavaScript file is larger but we no longer need to download the Material Icons font and patch the CSS file to reference the downloaded version.

Screenshots

Testing

Try playing some videos and test that the various UI components work correctly.

Desktop

OS: Windows
OS Version: 10

PikachuEXE · 2025-08-25T01:30:18Z

All scroll over player functions not working (I tried all

PikachuEXE · 2025-08-25T08:51:22Z

Adding classList.contains('shaka-controls-container') to handleControlsContainerWheel seems to work

efb4f5ff-1298-471a-8973-3d47447115dc · 2025-08-25T21:10:25Z

i change the volume with the slider but the color wont adjust

Freetube.8Hbapf9cpa.mp4

efb4f5ff-1298-471a-8973-3d47447115dc · 2025-08-26T13:48:56Z

FYI: v4.16.0 just released

absidue · 2025-08-26T13:53:03Z

I'll change this PR to jump straight to 4.16.0 then, no point doing two separate PRs right after each other (4.16 will also require more changes than just bumping the version).

absidue · 2025-08-28T17:18:56Z

@efb4f5ff-1298-471a-8973-3d47447115dc That issue is caused by touch interactions triggering the mouse wheel event that we add to the volume slider, so you can adjust it by hovering over it and scrolling. I don't know why touch interactions trigger touch events and wheel events at the same time but that's what is causing the problem here.

PikachuEXE · 2025-08-28T21:37:08Z

Not review for this PR but SABR implementation seems broken (renderer process taking 100% CPU) after merging this (no code conflict) and I have no idea why...
(Note: only SABR, current DASH implementation is fine

A request stuck in pending?

Update 1: even non SABR request can be stuck

Update 2: Also got stuck in 4.5.12, not sure if the cause is the same though

Update 3: After using local shaka-player repo to checkout tags (long process), it seems to be shaka-project/shaka-player#8782 causing the issue

Update 4: Issue with our custom URL triggering a bug in https://github.com/shaka-project/shaka-player/blob/v4.16.0/lib/util/cmcd_manager.js#L1348, adding a fake host seems to workaround it

Update 5: Submitted issue shaka-project/shaka-player#9050

PikachuEXE · 2025-09-01T01:09:27Z

Testing SABR with this PR: https://github.com/PikachuEXE/FreeTube/actions/runs/17323879326
Will approve after testing for ~ 1 week (no issues so far last few days

efb4f5ff-1298-471a-8973-3d47447115dc

Error while testing various window sizes

VirtualBoxVM_YIOKFNvgUw.mp4

How player icons looked like in an earlier build of this PR. These look correct to me

How they look now

absidue · 2025-09-01T14:23:35Z

@efb4f5ff-1298-471a-8973-3d47447115dc That error message is not from us, that's coming from webpack's dev server intercepting errors to show in that popup, in this case it's a warning from Electron that an event handler is too slow and may cause performance problems during the resize but as there is nothing in the console I'm pretty sure it is happening inside shaka-player. (reminder that we need to turn off that webpack dev server overlay, as this is not the first time that it has shown irrelevant errors)

The only icon of concern is the theatre mode one, all others are different because shaka-player changed Material Icons to Material Symbols to in 0.16.x.

absidue · 2025-09-09T15:29:55Z

@PikachuEXE It's been 9 days, any issues?

PikachuEXE · 2025-09-09T17:26:02Z

No issue
I can see https://github.com/shaka-project/shaka-player/releases/tag/v4.16.1 released which should be included for prefers-reduced-transparency and a fix which enables me to remove the workaround
After that we can merge this

absidue · 2025-09-10T16:38:53Z

Done!

PikachuEXE · 2025-09-11T01:12:50Z

reminder that we need to turn off that webpack dev server overlay

Separate PR I guess

github-actions · 2025-09-12T16:12:46Z

Conflicts have been resolved. A maintainer will review the pull request shortly.

PikachuEXE · 2025-09-15T01:10:18Z

@efb4f5ff-1298-471a-8973-3d47447115dc ?

* development: Translated using Weblate (Portuguese (Brazil)) Update shaka-player to 4.16.x (FreeTubeApp#7919) Translated using Weblate (Portuguese (Brazil)) Translated using Weblate (Portuguese (Brazil)) [Feature]: Hide videos immediately when marking as watched (FreeTubeApp#7866) Bump actions/setup-node from 4 to 5 (FreeTubeApp#8000)

* development: (65 commits) Translated using Weblate (Portuguese (Brazil)) Update shaka-player to 4.16.x (FreeTubeApp#7919) Translated using Weblate (Portuguese (Brazil)) Translated using Weblate (Portuguese (Brazil)) [Feature]: Hide videos immediately when marking as watched (FreeTubeApp#7866) Bump actions/setup-node from 4 to 5 (FreeTubeApp#8000) Bump mikefarah/yq from 4.47.1 to 4.47.2 (FreeTubeApp#8039) Bump marked from 16.2.1 to 16.3.0 (FreeTubeApp#8040) Bump eslint-plugin-jsdoc from 57.0.3 to 57.0.8 in the eslint group (FreeTubeApp#8038) Adjust homebrew link to maintainers tap (FreeTubeApp#8041) Remove n argument in sed (FreeTubeApp#8033) Translated using Weblate (Russian) Bump eslint-plugin-jsdoc from 56.1.2 to 57.0.3 in the eslint group (FreeTubeApp#8030) Bump youtubei.js from 15.1.0 to 15.1.1 (FreeTubeApp#8031) Translated using Weblate (Polish) Bump eslint-plugin-jsdoc from 55.0.0 to 56.1.2 in the eslint group (FreeTubeApp#8020) Bump lefthook from 1.12.4 to 1.13.0 (FreeTubeApp#8026) Bump swiper from 11.2.10 to 12.0.1 (FreeTubeApp#8024) Bump globals from 16.3.0 to 16.4.0 (FreeTubeApp#8023) Bump package version from 0.23.8 to 0.23.9 (FreeTubeApp#8027) ...

* Update shaka-player to 4.15.x * Move some items into the overflow menu on all player sizes * Fix mouse wheel actions * Update shaka-player to 4.16.x * Re-order entries in the overflow menu on mobile * Fix player icons * Optimise audio track handling * Upstream prefers-reduced-transparency for shaka-player's UI elements * Update shaka-player to 4.16.1

absidue added 2 commits August 24, 2025 15:38

Update shaka-player to 4.15.x

c8c3134

Move some items into the overflow menu on all player sizes

5c05a77

absidue requested review from ChunkyProgrammer, MarmadileManteater, PikachuEXE, efb4f5ff-1298-471a-8973-3d47447115dc and kommunarr August 24, 2025 14:28

FreeTubeBot enabled auto-merge (squash) August 24, 2025 14:28

github-actions bot added PR: dependencies Pull requests that update a dependency file PR: waiting for review For PRs that are complete, tested, and ready for review labels Aug 24, 2025

efb4f5ff-1298-471a-8973-3d47447115dc added PR: changes requested and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Aug 25, 2025

absidue added 3 commits August 27, 2025 18:56

Fix mouse wheel actions

2895ce6

Merge branch 'development' into update-shaka-player

158ffb1

Update shaka-player to 4.16.x

38f2ecd

absidue changed the title ~~Update shaka-player to 4.15.x~~ Update shaka-player to 4.16.x Aug 28, 2025

absidue added PR: waiting for review For PRs that are complete, tested, and ready for review and removed PR: changes requested labels Aug 28, 2025

Re-order entries in the overflow menu on mobile

dd7c6bc

efb4f5ff-1298-471a-8973-3d47447115dc reviewed Sep 1, 2025

View reviewed changes

absidue mentioned this pull request Sep 1, 2025

Bump shaka-player from 4.14.26 to 4.16.0 #7974

Closed

absidue requested a review from efb4f5ff-1298-471a-8973-3d47447115dc September 5, 2025 18:19

absidue added 2 commits September 10, 2025 18:33

Merge branch 'development' into update-shaka-player

efa2940

Update shaka-player to 4.16.1

8664908

PikachuEXE previously approved these changes Sep 11, 2025

View reviewed changes

This comment was marked as resolved.

Sign in to view

github-actions bot added PR: merge conflicts / rebase needed and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Sep 12, 2025

Merge branch 'development' into update-shaka-player

50be516

absidue dismissed PikachuEXE’s stale review via 50be516 September 12, 2025 16:12

github-actions bot removed the PR: merge conflicts / rebase needed label Sep 12, 2025

absidue added the PR: waiting for review For PRs that are complete, tested, and ready for review label Sep 12, 2025

PikachuEXE approved these changes Sep 13, 2025

View reviewed changes

This comment was marked as outdated.

Sign in to view

efb4f5ff-1298-471a-8973-3d47447115dc approved these changes Sep 16, 2025

View reviewed changes

ChunkyProgrammer approved these changes Sep 16, 2025

View reviewed changes

FreeTubeBot merged commit f5ac1a3 into FreeTubeApp:development Sep 16, 2025
5 checks passed

github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Sep 16, 2025

absidue deleted the update-shaka-player branch September 17, 2025 08:03

This was referenced Sep 18, 2025

Move Loop to Overflow menu #8049

Merged

Change Player icons #8057

Merged

absidue mentioned this pull request Sep 26, 2025

Hide webpack-dev-server error overlay for application errors #8087

Merged

1 task

Conversation

absidue commented Aug 24, 2025 • edited by efb4f5ff-1298-471a-8973-3d47447115dc Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Type

Related issue

Description

Screenshots

Testing

Desktop

Uh oh!

PikachuEXE commented Aug 25, 2025

Uh oh!

PikachuEXE commented Aug 25, 2025

Uh oh!

efb4f5ff-1298-471a-8973-3d47447115dc commented Aug 25, 2025

Uh oh!

efb4f5ff-1298-471a-8973-3d47447115dc commented Aug 26, 2025

Uh oh!

absidue commented Aug 26, 2025

Uh oh!

absidue commented Aug 28, 2025

Uh oh!

PikachuEXE commented Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PikachuEXE commented Sep 1, 2025

Uh oh!

efb4f5ff-1298-471a-8973-3d47447115dc left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

absidue commented Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

absidue commented Sep 9, 2025

Uh oh!

PikachuEXE commented Sep 9, 2025

Uh oh!

absidue commented Sep 10, 2025

Uh oh!

PikachuEXE commented Sep 11, 2025

Uh oh!

This comment was marked as resolved.

github-actions bot commented Sep 12, 2025

Uh oh!

PikachuEXE commented Sep 15, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

absidue commented Aug 24, 2025 •

edited by efb4f5ff-1298-471a-8973-3d47447115dc

Loading

PikachuEXE commented Aug 28, 2025 •

edited

Loading

efb4f5ff-1298-471a-8973-3d47447115dc left a comment •

edited

Loading

absidue commented Sep 1, 2025 •

edited

Loading