Gazebo plugin advertise add group after simulation starts - #104
Merged
iamtesch merged 4 commits intoMar 6, 2019
Merged
Conversation
added 2 commits
September 12, 2018 13:49
iamtesch
reviewed
Nov 19, 2018
| private: | ||
|
|
||
| physics::ModelPtr model; | ||
| bool first_sim_iteration; |
Contributor
There was a problem hiding this comment.
Super minor (and there are a lot of more significant style issues in the code right now), but I'd probably change this to
bool first_sim_iteration{true}; here. That way you don't have to set the variable in the load function below, and there is never a period where is is undefined.
Contributor
Author
There was a problem hiding this comment.
Thanks. Will change.
iamtesch
reviewed
Nov 19, 2018
iamtesch
left a comment
iamtesch
left a comment
Contributor
There was a problem hiding this comment.
Again, looks good -- I just made one small suggestion. Thanks!
Contributor
Author
|
Changed with iamtesch's suggestion |
iamtesch
approved these changes
Mar 6, 2019
iamtesch
left a comment
iamtesch
left a comment
Contributor
There was a problem hiding this comment.
Sorry for not getting this in much sooner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple patch for #103