Support ros namespaces for multiple robots - #106
Merged
iamtesch merged 6 commits intoNov 19, 2018
Merged
Conversation
added 4 commits
November 2, 2018 13:27
iamtesch
reviewed
Nov 19, 2018
| ros::init(argc, argv, "hebiros_gazebo_plugin_node"); | ||
| this->n.reset(new ros::NodeHandle); | ||
|
|
||
| this->add_group_srv = |
Contributor
There was a problem hiding this comment.
Why did the add_group service get removed here?
Contributor
Author
There was a problem hiding this comment.
I mistakenly included that (from https://github.com/HebiRobotics/HEBI-ROS/pull/104/files) when I copied over changes. I'll fix it.
iamtesch
reviewed
Nov 19, 2018
iamtesch
left a comment
iamtesch
left a comment
Contributor
There was a problem hiding this comment.
This looks good -- I just had one quick question before merging in (see comment inline)
iamtesch
approved these changes
Nov 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
http://wiki.ros.org/Names