Fixes Underwater Camera Plugin which sets the ROS2 node name statically, which doesn't allow to have multiples#23
Merged
woensug-choi merged 1 commit intoJun 16, 2025
Conversation
woensug-choi
approved these changes
Feb 5, 2025
woensug-choi
left a comment
There was a problem hiding this comment.
Thank you! Take the pleasure of clicking the Merge button :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When adding multiple underwater camera plugins to a model sdf the output throws a warning as:
[gazebo-1] [WARN] [1732716498.287779827] [rcl.logging_rosout]: Publisher already registered for node name: 'underwater_camera_node'. If this is due to multiple nodes with the same name then all logs for the logger named 'underwater_camera_node' will go out over the existing publisher. As soon as any node with that name is destructed it will unregister the publisher, preventing any further logs for that name from being published on the rosout topic.This is caused by setting the ros node name statically. This pull request fixes that by taking the sdf sensor name as a node name. For example:
will result in a ros2 node name:
camera_front_node.