merge, trim and update python dependencies sections#218
Closed
egpbos wants to merge 2 commits into
Closed
Conversation
Collaborator
Author
|
CI failures not caused by this PR. Could do a separate one to fix links. |
1 task
Collaborator
Author
|
I think this can be safely merged, please review contents :) |
Member
|
@egpbos It looks like a reviewed this pull request in your other pull request #219 (comment)? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #156
Below, describe what this Pull Request adds:
Primarily, I added the recommendation from the discussion in #156. Simultaneously, I merged the two sections on Python dependencies & packages (I think the Building packages should be a subsection here, it's really intertwined). Also trimmed the existing text here and there, it was rather verbose, with lots of examples of commands that you can also easily find online with the right keywords (which we provide here).