Fix broken Python links & update testing section#219
Conversation
|
Don't pull, I'm going to rebase and force push... sorry for the confusion. |
|
Ok, there we go, no more merge conflicts ;) |
|
The remaining errors are intermittent and should go away later (https://code.google.com/p/py-leveldb/ is there, so must have been a fluke, pylint.org is indeed actually down at the moment). Should rerun checks later to make sure. |
egpbos
changed the title
| This is also the primary location where you should list your dependencies (find the currently installed packages with `pip freeze` or `conda list`). | ||
| Use the `install_requires` argument to list them. | ||
| Keep version constraints to a minimum; use, in order of descending preference: no constraints, lower bounds, lower + upper bounds, exact versions. | ||
| Use of `requirements.txt` is discouraged, unless necessary for something specific, see the [discussion here](https://github.com/NLeSC/guide/issues/156). |
There was a problem hiding this comment.
Maybe you could add an external source instead of our GitHub issue?
There was a problem hiding this comment.
I would prefer to link to the internal discussion, since that's what the recommendation was based on.
| Set up continuous integration to test your installation script. Use `pyroma` (can be run as part of `prospector`) as a linter for your installation script. | ||
|
|
||
| There are two main distributions of Conda: [Anaconda](http://continuum.io/downloads) and [Miniconda](http://conda.pydata.org/miniconda.html). Anaconda is large and contains a lot of common packages, like numpy and matplotlib, whereas Miniconda is very lightweight and only contains Python. If you need more, the `conda` command acts as a package manager for Python packages. | ||
| For packaging your code, you can either use `pip` or `conda`. Neither of them is [better than the other](https://jakevdp.github.io/blog/2016/08/25/conda-myths-and-misconceptions/) -- they are different; use the one which is more suitable for your project. `pip` may be more suitable for distributing pure python packages, and it provides some support for binary dependencies using [`wheels`](http://pythonwheels.com). `conda` may be more suitable when you have external dependencies which cannot be packaged in a wheel. |
There was a problem hiding this comment.
This looks a bit like a duplicate of the section on what conda is
There was a problem hiding this comment.
Maybe so. Of course making a conda package and using conda for dependencies are two different things with different reasons for choosing it over pip/pypi. I'm open to suggestions, but let's do that in another PR.
|
Ok, I was confused, but most of your review comments are really for #218. I'll address them there and will figure out some weird git magic to make things make sense again :P |
@egpbos Are you waiting for me to do something? Or did you simply not have the time to do this yet? |
The comments were given in #219 already, but still apply here.
2 participants
Below, describe what this Pull Request adds:
In #218 it turned out a few links were broken in the Python chapter, this PR fixes that. Note: this PR branches off of the branch of #218, so DON'T MERGE BEFORE #218.