Skip to content

[None][infra] Waive 5 failed cases for main in post-merge 2733 - #14516

Merged
mzweilz merged 1 commit into
NVIDIA:mainfrom
ZhanruiSunCh:trtllm-ci-report/waive-20260525-064215
May 25, 2026
Merged

[None][infra] Waive 5 failed cases for main in post-merge 2733#14516
mzweilz merged 1 commit into
NVIDIA:mainfrom
ZhanruiSunCh:trtllm-ci-report/waive-20260525-064215

Conversation

@ZhanruiSunCh

@ZhanruiSunCh ZhanruiSunCh commented May 25, 2026

Copy link
Copy Markdown
Collaborator

Auto-generated Waive PR

Created by: TensorRT LLM CI Report (requested by @mzweilz)
Target branch: main
Bug(s): 6215793, 6215810, 6215844

Waive entries added

accuracy/test_llm_api_pytorch.py::TestDeepSeekR1::test_nvfp4_multi_gpus[throughput_tp4] SKIP (https://nvbugs/6215793)
perf/test_perf_sanity.py::test_e2e[aggr_upload-ctx_only-gb300_deepseek-r1-fp4_128k8k_con256_ctx1_pp4_gen1_dep8_eplb0_mtp1_ccb-NIXL] SKIP (https://nvbugs/6215810)
perf/test_perf_sanity.py::test_e2e[disagg_upload-e2e-gb200_deepseek-r1-fp4_128k8k_con128_ctx1_pp8_gen1_dep16_eplb0_mtp1_ccb-NIXL] SKIP (https://nvbugs/6215844)
perf/test_perf_sanity.py::test_e2e[disagg_upload-e2e-gb300_deepseek-r1-fp4_128k8k_con256_ctx1_pp4_gen1_dep8_eplb0_mtp1_ccb-NIXL] SKIP (https://nvbugs/6215844)
perf/test_perf_sanity.py::test_e2e[disagg_upload-gen_only-gb300_deepseek-r1-fp4_128k8k_con256_ctx1_pp4_gen1_dep8_eplb0_mtp1_ccb-NIXL] SKIP (https://nvbugs/6215844)

This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.

Summary by CodeRabbit

  • Tests
    • Added accuracy test waivers for specific model inference test cases.
    • Expanded performance test waiver coverage for multiple model configurations across various test scenarios.

Review Change Stack

Bug(s): 6215793, 6215810, 6215844
Requested by: @mzweilz

Signed-off-by: ZhanruiSunCh <184402041+ZhanruiSunCh@users.noreply.github.com>
@mzweilz

mzweilz commented May 25, 2026

Copy link
Copy Markdown
Collaborator

/bot skip --comment "post merge waive PR created via CI report, skip testing."

@mzweilz
mzweilz enabled auto-merge (squash) May 25, 2026 06:43
@coderabbitai

coderabbitai Bot commented May 25, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

This PR adds five new test waiver entries to tests/integration/test_lists/waives.txt: one for an accuracy test of DeepSeek R1 NVFP4 performance, and four for performance test scenarios involving DeepSeek R1 and V32 models with aggregation/disaggregation upload variants on gb300 hardware.

Changes

Test Waiver Configuration

Layer / File(s) Summary
Accuracy test waiver for DeepSeek R1 NVFP4
tests/integration/test_lists/waives.txt
Adds SKIP waiver for TestDeepSeekR1::test_nvfp4_multi_gpus[throughput_tp4] accuracy test with associated nvbugs reference.
Performance test waiver expansion for aggregation and disaggregation upload scenarios
tests/integration/test_lists/waives.txt
Extends perf/test_perf_sanity.py::test_e2e[...] SKIP waiver section with new DeepSeek R1 and V32 model variants for ctx_only and disaggregation upload test scenarios on gb300 hardware, retaining existing waivers in that region.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

  • NVIDIA/TensorRT-LLM#14503: Modifies the same waivers file by adding SKIP entries for different failing tests.
  • NVIDIA/TensorRT-LLM#14034: Updates waivers for perf/test_perf_sanity.py::test_e2e DeepSeek R1 scenarios with overlapping aggr_upload/disaggregation cases.
  • NVIDIA/TensorRT-LLM#14461: Also modifies tests/integration/test_lists/waives.txt entries for perf/test_perf_sanity.py::test_e2e[...] waiver management.

Suggested reviewers

  • mzweilz
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The auto-generated description includes waive entries with bug references, but lacks required sections like overall description, test coverage rationale, and PR checklist confirmation. Add a brief description explaining why these cases are being waived, and confirm that the PR checklist items have been reviewed as appropriate for this type of infrastructure change.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the PR's purpose: waiving 5 failed test cases for the main branch, with proper format including ticket reference and type.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@tests/integration/test_lists/waives.txt`:
- Line 26: The SKIP entries in tests/integration/test_lists/waives.txt are not
exact pytest nodeids so the waivers don’t apply; run pytest --collect-only to
capture the exact parameterized nodeid strings and replace the current entries
(e.g.,
accuracy/test_llm_api_pytorch.py::TestDeepSeekR1::test_nvfp4_multi_gpus[throughput_tp4]
and the perf/test_perf_sanity.py::test_e2e[...] entries) with the exact nodeids
produced by pytest, ensuring each updated string exactly matches the identifiers
used in CI selection lists and the corresponding
tests/integration/test_lists/test-db/l0_*.yml and
tests/integration/test_lists/qa/llm_perf_*.yml entries.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 820b2a73-2bee-44ce-a00e-e422496b50a7

📥 Commits

Reviewing files that changed from the base of the PR and between e6d4f9f and 8787c47.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt

Comment thread tests/integration/test_lists/waives.txt
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50163 [ skip ] triggered by Bot. Commit: 8787c47 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50163 [ skip ] completed with state SUCCESS. Commit: 8787c47
Skipping testing for commit 8787c47

Link to invocation

@mzweilz

mzweilz commented May 25, 2026

Copy link
Copy Markdown
Collaborator

/bot run --stage-list "A10-Build_Docs"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50169 [ run ] triggered by Bot. Commit: 8787c47 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50169 [ run ] completed with state SUCCESS. Commit: 8787c47
/LLM/main/L0_MergeRequest_PR pipeline #39713 (Partly Tested) completed with status: 'SUCCESS'

CI Report

Link to invocation

@mzweilz

mzweilz commented May 25, 2026

Copy link
Copy Markdown
Collaborator

/bot skip --comment "Waive PR created via CI report, skip testing"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50188 [ skip ] triggered by Bot. Commit: 8787c47 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50188 [ skip ] completed with state SUCCESS. Commit: 8787c47
Skipping testing for commit 8787c47

Link to invocation

@mzweilz
mzweilz merged commit 2e3a75c into NVIDIA:main May 25, 2026
12 checks passed
KleinBlueC pushed a commit to KleinBlueC/TensorRT-LLM that referenced this pull request May 26, 2026
…A#14516)

Signed-off-by: ZhanruiSunCh <184402041+ZhanruiSunCh@users.noreply.github.com>
bmarimuthu-nv pushed a commit to nv-auto-deploy/TensorRT-LLM that referenced this pull request May 28, 2026
…A#14516)

Signed-off-by: ZhanruiSunCh <184402041+ZhanruiSunCh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants