[https://nvbugs/6185248][test] Unwaive K2.5 thinking MTP3 perf sanity test - #14461
Conversation
… test Bug fixed by PR NVIDIA#14379 (merge commit eb6ee93) which added draft_config / draft_model / load_draft_weights property forwarders on KimiK25ForConditionalGeneration and threaded **kwargs through its forward to reach DeepseekV3 MTP. However, the waive entry was added later by PR NVIDIA#14405 (merge commit 736d580) — NVIDIA#14379's base predates that waive, so the merged fix did not remove the waive line. Remove it explicitly here. Signed-off-by: Tianyu Xiong <117647511+tianyuxbear@users.noreply.github.com>
|
/bot run --extra-stage "GB200-4_GPUs-PyTorch-PerfSanity-Post-Merge-1" |
📝 WalkthroughWalkthroughThis PR removes a single test-waive entry from ChangesPerformance Test Waiver Removal
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
PR_Github #49937 [ run ] triggered by Bot. Commit: |
|
PR_Github #49937 [ run ] completed with state
|
|
/bot run --extra-stage "GB200-4_GPUs-PyTorch-PerfSanity-Post-Merge-1" --disable-fail-fast |
|
PR_Github #50036 [ run ] triggered by Bot. Commit: |
|
PR_Github #50036 [ run ] completed with state |
… test (NVIDIA#14461) Signed-off-by: Tianyu Xiong <117647511+tianyuxbear@users.noreply.github.com>
… test (NVIDIA#14461) Signed-off-by: Tianyu Xiong <117647511+tianyuxbear@users.noreply.github.com>
Summary
Re-enables
test_perf_sanity.py::test_e2e[aggr_upload-ctx_only-gb200_kimi-k25-thinking-fp4_8k1k_con4_ctx1_dep4_gen1_tep8_eplb0_mtp3_ccb-NIXL]. The underlying defect tracked by nvbug 6185248 is already fixed onmainby PR #14379; this PR only removes the waive entry that was added in parallel.Background
Nvbug 6185248:
AttributeError: 'KimiK25ForConditionalGeneration' object has no attribute 'draft_config'attensorrt_llm/_torch/pyexecutor/model_loader.pywhen MTP speculative decoding is enabled. Root cause: PR #12788 refactoredKimiK25ForConditionalGenerationinto a composition pattern (self.llm = DeepseekV3ForCausalLM(...)), but the loader expecteddraft_configdirectly on the top-level model.PR #14379 fixed this by adding
draft_config/draft_model/load_draft_weightsproperty forwarders onKimiK25ForConditionalGeneration(delegating toself.llm) and threading**kwargsthroughKimiK25.forwardsospec_metadatareaches DeepseekV3's MTP forward path.Why a separate unwaive PR
The fix PR #14379 was merged but did not remove the waive line, due to the merge ordering between the fix PR and the waive PR:
b3fcf083(waive does not exist yet onmain)main736d580f80modeling_kimi_k25.pyeb6ee930Verification:
git merge-base --is-ancestor 736d580f80 b3fcf083→NO. PR #14379's base predates the waive, so #14379's diff does not include an unwaive change. This PR removes the now-stale waive entry explicitly.