[None][infra] Waive 8 failed cases for main in post-merge 2738 - #14615
Conversation
Bug(s): 6221022, 6221024, 6221483, 6227203, 6227472 Requested by: @mzweilz Signed-off-by: ZhanruiSunCh <184402041+ZhanruiSunCh@users.noreply.github.com>
📝 WalkthroughWalkthroughThis PR adds eight new test waiver entries across ChangesTest Waivers
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
tests/integration/test_lists/waives.txt (1)
313-315: 💤 Low valuePerformance test coverage temporarily reduced for K25 thinking configurations.
These three perf sanity tests cover K25 thinking model configurations on Blackwell with different parameter settings (tep8_adp, dep8, tep8 with various context/output lengths). Waiving them removes performance regression detection for these configurations until the underlying issues tracked in NVBug 6227472 are resolved.
As per coding guidelines: Check whether perf test coverage is present for performance-sensitive paths, especially for attention kernels, MoE routing, KV cache management, scheduler, and batching logic.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/integration/test_lists/waives.txt` around lines 313 - 315, The waivers removed three perf/test_perf_sanity.py::test_e2e cases for K25 thinking configs (mentioned as SKIP referencing NVBug 6227472), which reduces coverage of performance-sensitive code paths; restore coverage by adding targeted perf tests that exercise the same K25 "thinking" configurations or by adding focused micro-benchmarks for the attention kernels, MoE routing, KV cache management, scheduler, and batching logic used by test_e2e, and update the test suite so these new tests (or re-enabled parametrized variants of test_e2e) run even while the NVBug 6227472 root cause is being addressed. Ensure the tests explicitly reference the same model/config parameters from the skipped test_e2e cases so they cover tep8_adp, dep8, and tep8 context/output length variants.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@tests/integration/test_lists/waives.txt`:
- Around line 313-315: The waivers removed three
perf/test_perf_sanity.py::test_e2e cases for K25 thinking configs (mentioned as
SKIP referencing NVBug 6227472), which reduces coverage of performance-sensitive
code paths; restore coverage by adding targeted perf tests that exercise the
same K25 "thinking" configurations or by adding focused micro-benchmarks for the
attention kernels, MoE routing, KV cache management, scheduler, and batching
logic used by test_e2e, and update the test suite so these new tests (or
re-enabled parametrized variants of test_e2e) run even while the NVBug 6227472
root cause is being addressed. Ensure the tests explicitly reference the same
model/config parameters from the skipped test_e2e cases so they cover tep8_adp,
dep8, and tep8 context/output length variants.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: f1e9b445-a5eb-40d1-ace2-833a9b9b2834
📒 Files selected for processing (1)
tests/integration/test_lists/waives.txt
|
/bot skip --comment "waive tests" |
|
PR_Github #50468 [ skip ] triggered by Bot. Commit: |
|
PR_Github #50468 [ skip ] completed with state |
…A#14615) Signed-off-by: ZhanruiSunCh <184402041+ZhanruiSunCh@users.noreply.github.com>
Auto-generated Waive PR
Created by: TensorRT LLM CI Report (requested by @mzweilz)
Target branch:
mainBug(s): 6221022, 6221024, 6221483, 6227203, 6227472
Waive entries added
This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.
Summary by CodeRabbit
Note: This is an internal testing infrastructure update with no visible impact on end-user functionality.