Skip to content

[https://nvbugs/6184914][test] Unwaive related tests#14523

Merged
yuxianq merged 1 commit into
NVIDIA:mainfrom
yuxianq:nvbug-6184914-unwaive-tests
May 26, 2026
Merged

[https://nvbugs/6184914][test] Unwaive related tests#14523
yuxianq merged 1 commit into
NVIDIA:mainfrom
yuxianq:nvbug-6184914-unwaive-tests

Conversation

@yuxianq

@yuxianq yuxianq commented May 25, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Tests
    • Updated test waiver entries for DeepSeekV3Lite model accuracy testing.

Review Change Stack

Description

Remove every waiver tied to NVBug 6184914 from tests/integration/test_lists/waives.txt so CI can exercise the related DeepSeek V3 Lite 4-GPU cases again.

Removed waivers:

  • TestDeepSeekV3Lite::test_fp8_block_scales_4gpus[pp4-mtp_nextn=0-fp8kv=False-attention_dp=True-cuda_graph=True-overlap_scheduler=True-torch_compile=False-sampler_async_worker=False]
  • TestDeepSeekV3Lite::test_nvfp4_4gpus[moe_backend=CUTLASS-mtp_nextn=0-pp4-fp8kv=False-attention_dp=False-cuda_graph=False-overlap_scheduler=False-low_precision_combine=False-torch_compile=True]
  • TestDeepSeekV3Lite::test_nvfp4_4gpus[moe_backend=CUTLASS-mtp_nextn=2-pp4-fp8kv=True-attention_dp=True-cuda_graph=True-overlap_scheduler=True-low_precision_combine=False-torch_compile=False]

Test Coverage

  • rg -n "6184914" tests/integration/test_lists/waives.txt tests/integration/test_lists || true returned no remaining waivers.
  • git diff --check
  • python scripts/test_to_stage_mapping.py --tests <three removed node ids>
  • CI will be triggered with /bot run --disable-fail-fast after opening this PR.

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>

yuxianq commented May 25, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-reuse-test --disable-fail-fast

@coderabbitai

coderabbitai Bot commented May 25, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

Two test waiver entries in tests/integration/test_lists/waives.txt are updated with new parameter combinations for DeepSeekV3Lite accuracy tests, with corresponding changes to nvbugs references.

Changes

Test Waiver Updates

Layer / File(s) Summary
DeepSeekV3Lite test waivers
tests/integration/test_lists/waives.txt
Two waiver entries are replaced: test_fp8_block_scales_4gpus (line 54) and test_nvfp4_4gpus (lines 73–74) with different parameter sets and updated nvbugs references.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • chzblych
  • zhenhuaw-me
  • dc3671
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the NVBugs reference and indicates the action (unwaiving tests), accurately reflecting the main change of removing waivers from the test list.
Description check ✅ Passed The description provides a clear explanation of what waivers were removed and why, includes specific test coverage steps, and follows the repository's template structure with completed checklist items.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50177 [ run ] triggered by Bot. Commit: a632fde Link to invocation

@yuxianq
yuxianq requested a review from crazydemo May 25, 2026 08:07
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50177 [ run ] completed with state SUCCESS. Commit: a632fde
/LLM/main/L0_MergeRequest_PR pipeline #39720 completed with status: 'SUCCESS'

CI Report

Link to invocation

@yuxianq yuxianq changed the title [NVBUG-6184914][test] Unwaive related tests [https://nvbugs/6184914][test] Unwaive related tests May 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants