Skip to content

Mr main unwaive qwen3 30b test - #14727

Closed
kris1025 wants to merge 2 commits into
NVIDIA:mainfrom
kris1025:mr-main-unwaive-qwen3-30b-test
Closed

Mr main unwaive qwen3 30b test#14727
kris1025 wants to merge 2 commits into
NVIDIA:mainfrom
kris1025:mr-main-unwaive-qwen3-30b-test

Conversation

@kris1025

@kris1025 kris1025 commented May 29, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Tests
    • Removed a test waiver to re-enable a previously skipped test case.

Review Change Stack

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

@coderabbitai

coderabbitai Bot commented May 29, 2026

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: cd795037-2c61-41cc-b475-ae0e8177166b

📥 Commits

Reviewing files that changed from the base of the PR and between 018c432 and 1a63c05.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

A single waiver entry for a test_nvfp4 test case is removed from the integration test waiver list, allowing the previously skipped test to run without exemption.

Changes

Test Waiver Cleanup

Layer / File(s) Summary
Remove test waiver entry
tests/integration/test_lists/waives.txt
The SKIP waiver for accuracy/test_llm_api_pytorch.py::TestQwen3_30B_A3B::test_nvfp4[tep4_latency_moe_trtllm-torch_compile=True] is removed, allowing the test to run without exemption.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • ZhanruiSunCh
  • jieli-matrix
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant