Skip to content

[https://nvbugs/6079440][test] Unwaive MTP speculative decoding test - #14341

Merged
mikeiovine merged 2 commits into
NVIDIA:mainfrom
sunnyqgg:bug_6079440
May 21, 2026
Merged

[https://nvbugs/6079440][test] Unwaive MTP speculative decoding test#14341
mikeiovine merged 2 commits into
NVIDIA:mainfrom
sunnyqgg:bug_6079440

Conversation

@sunnyqgg

@sunnyqgg sunnyqgg commented May 20, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Remove the test_llmapi_speculative_decoding_mtp skip entry for nvbugs/6079440 from waives.txt.

Changes

  • tests/integration/test_lists/waives.txt: unwaive llmapi/test_llm_examples.py::test_llmapi_speculative_decoding_mtp.

Test plan

  • pre-commit run --files tests/integration/test_lists/waives.txt
  • CI

Summary by CodeRabbit

  • Tests
    • Updated test skip configurations to reflect changes in test execution requirements.

Review Change Stack

Signed-off-by: qgai <qgai@nvidia.com>

Copy link
Copy Markdown
Collaborator Author

/bot run

@coderabbitai

coderabbitai Bot commented May 20, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

This PR updates the test waiver list for speculative decoding tests. The test_llmapi_speculative_decoding_mtp test is removed from the skip list and replaced with test_llmapi_speculative_decoding_eagle3, both associated with nvbugs references.

Changes

Test Waiver Update

Layer / File(s) Summary
Speculative decoding test waiver update
tests/integration/test_lists/waives.txt
Speculative decoding test waiver entry replaced: removed MTP variant skip and added Eagle3 variant skip with associated nvbugs reference.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • NVIDIA/TensorRT-LLM#13641: Modifies the same tests/integration/test_lists/waives.txt file to adjust nvbugs-based SKIP/waiver entries.
  • NVIDIA/TensorRT-LLM#14163: Changes SKIP waiver entries in tests/integration/test_lists/waives.txt.
  • NVIDIA/TensorRT-LLM#14324: Directly modifies tests/integration/test_lists/waives.txt by adding/removing SKIP entries for speculative decoding test cases.

Suggested reviewers

  • chuangz0
  • chzblych
  • zhenhuaw-me
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is fully related to the main change: it clearly indicates the removal of a skip/waiver entry for the MTP speculative decoding test.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The pull request description clearly explains the issue and the solution, includes relevant test coverage information, and follows the basic requirements of the template.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #49366 [ run ] triggered by Bot. Commit: 0e4cff8 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #49366 [ run ] completed with state SUCCESS. Commit: 0e4cff8
/LLM/main/L0_MergeRequest_PR pipeline #39020 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@sunnyqgg

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #49654 [ run ] triggered by Bot. Commit: 156412b Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #49654 [ run ] completed with state SUCCESS. Commit: 156412b
/LLM/main/L0_MergeRequest_PR pipeline #39269 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

CI Report

Link to invocation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants