Skip to content

[None][test] Unwaive fp8 blockscale baseline mtp1 - #14666

Merged
sunnyqgg merged 1 commit into
NVIDIA:mainfrom
sunnyqgg:unwaive-fp8-blockscale-baseline-mtp1
May 28, 2026
Merged

[None][test] Unwaive fp8 blockscale baseline mtp1#14666
sunnyqgg merged 1 commit into
NVIDIA:mainfrom
sunnyqgg:unwaive-fp8-blockscale-baseline-mtp1

Conversation

@sunnyqgg

@sunnyqgg sunnyqgg commented May 28, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Unwaive DeepSeekV32 fp8 blockscale baseline_mtp1 integration test.

Changes

  • Removed the baseline_mtp1 SKIP entry from tests/integration/test_lists/waives.txt.

Test plan

  • pre-commit run --files tests/integration/test_lists/waives.txt
  • Validate target waive entry is absent

Summary by CodeRabbit

  • Tests
    • Removed a previously-waived test case from the test waiver list.

Review Change Stack

Signed-off-by: qgai <qgai@nvidia.com>
@sunnyqgg

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 96204e45-b8e5-440b-a9e0-a317de5b46dc

📥 Commits

Reviewing files that changed from the base of the PR and between 1b8c739 and d40b477.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

The PR removes a single test waiver entry for TestDeepSeekV32::test_fp8_blockscale[baseline_mtp1] from the test waiver list, indicating the previously-waived issue has been resolved.

Changes

Test Waiver Cleanup

Layer / File(s) Summary
Remove fp8_blockscale baseline_mtp1 waiver
tests/integration/test_lists/waives.txt
The waiver entry for accuracy/test_llm_api_pytorch.py::TestDeepSeekV32::test_fp8_blockscale[baseline_mtp1] and its associated NVBUG reference are removed from the waiver list.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~1 minute

Possibly related PRs

  • NVIDIA/TensorRT-LLM#14541: Both PRs change the same tests/integration/test_lists/waives.txt waiver list by removing a TestDeepSeekV32::test_fp8_blockscale[...]-type entry.
  • NVIDIA/TensorRT-LLM#14341: Both PRs modify tests/integration/test_lists/waives.txt to remove existing nvbugs-linked waiver entries for MTP-related tests.
  • NVIDIA/TensorRT-LLM#14511: Both PRs modify the same waiver list file by removing different test waiver entries.

Suggested reviewers

  • jieli-matrix
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: removing a waiver for the fp8 blockscale baseline mtp1 test.
Description check ✅ Passed The description includes a summary, changes, and test plan sections, providing clear information about the PR objectives and validation steps, though it lacks some optional template sections.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50688 [ run ] triggered by Bot. Commit: d40b477 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50688 [ run ] completed with state SUCCESS. Commit: d40b477
/LLM/main/L0_MergeRequest_PR pipeline #40176 completed with status: 'SUCCESS'

CI Report

Link to invocation

@sunnyqgg
sunnyqgg requested a review from EmmaQiaoCh May 28, 2026 07:01
@sunnyqgg
sunnyqgg merged commit 9feaa76 into NVIDIA:main May 28, 2026
11 checks passed
@coderabbitai coderabbitai Bot mentioned this pull request May 29, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants