[https://nvbugs/6248769][fix] In KVCacheManager.__init__, after resolving max_attention_window_vec and… - #14887
Conversation
Signed-off-by: tensorrt-cicd <90828364+tensorrt-cicd@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughKVCacheManager now imports ChangesKV Cache Manager Window Clamping and Test Configuration Update
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/bot run --extra-stage "DGX_B200-4_GPUs-AutoDeploy-1, DGX_H100-4_GPUs-AutoDeploy-1" --disable-fail-fast |
|
PR_Github #51816 [ run ] triggered by Bot. Commit: |
|
PR_Github #51816 [ run ] completed with state
|
Summary
max_attention_window_vecis clamped tomax_seq_len(512) by_resolve_max_attention_window_vec, butpool_configurationsretained the unclamped sliding window (Ministral's 32768), so layers resolving to window 512 had no matching pool key →KeyError: 512.KVCacheManager.__init__, after resolvingmax_attention_window_vecand before_build_layer_to_pool_idx(), rebuildself.pool_configurationswithwindow_size=min(pc.window_size, self.max_seq_len), keepinghead_dim/dtypeand pool indices intact.Test plan
Links
Summary by CodeRabbit
Bug Fixes
Tests