[None][infra] Waive 12 failed cases for main in post-merge 2749 - #14802
Conversation
Bug(s): 6144270, 6156233, 6191524, 6248744, 6248757, 6248764, 6248769, 6248776, 6248783, 6248827, 6248837 Requested by: @EmmaQiaoCh Signed-off-by: ZhanruiSunCh <184402041+ZhanruiSunCh@users.noreply.github.com>
|
/bot run |
📝 WalkthroughWalkthroughThis PR adds twelve new SKIP waiver entries to the test exclusion list, primarily for autodeploy registry accuracy tests and various model-specific parameterized test cases that are currently failing and need to be skipped from the CI suite. ChangesTest Waiver Updates
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
tests/integration/test_lists/waives.txt (1)
18-19: ⚡ Quick winAdd explicit follow-up tracking for waived coverage gaps.
Waive syntax/format looks correct, but coverage is now insufficient for the newly skipped paths in:
accuracy/test_llm_api_autodeploy.pyaccuracy/test_llm_api_pytorch.pyaccuracy/test_llm_api_pytorch_multimodal.pyunittest/llmapi/test_llm_pytorch.pyPlease add/confirm a linked follow-up tracker per file (owner + target unwaive milestone) outside this PR so these 12 SKIPs don’t become permanent.
Based on learnings: "In tests/integration/test_lists/waives.txt, prefer the short nvbug URL format https://nvbugs/XXXX ... ensure consistency by using the short form in this file."
Also applies to: 22-22, 25-25, 72-72, 86-87, 125-125, 134-134, 143-143, 374-375
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/integration/test_lists/waives.txt` around lines 18 - 19, Update tests/integration/test_lists/waives.txt to include explicit follow-up tracker links and owner+target unwaive milestone references for each waived test group listed (specifically for accuracy/test_llm_api_autodeploy.py, accuracy/test_llm_api_pytorch.py, accuracy/test_llm_api_pytorch_multimodal.py, and unittest/llmapi/test_llm_pytorch.py) and replace long nvbug URLs with the short form (https://nvbugs/XXXX) for the existing waived entries (including those around lines 22,25,72,86-87,125,134,143,374-375); ensure each waived line has a short nvbug reference plus an owner and target milestone noted in a consistent comment format so maintainers can track and unwaive later.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@tests/integration/test_lists/waives.txt`:
- Around line 18-19: Update tests/integration/test_lists/waives.txt to include
explicit follow-up tracker links and owner+target unwaive milestone references
for each waived test group listed (specifically for
accuracy/test_llm_api_autodeploy.py, accuracy/test_llm_api_pytorch.py,
accuracy/test_llm_api_pytorch_multimodal.py, and
unittest/llmapi/test_llm_pytorch.py) and replace long nvbug URLs with the short
form (https://nvbugs/XXXX) for the existing waived entries (including those
around lines 22,25,72,86-87,125,134,143,374-375); ensure each waived line has a
short nvbug reference plus an owner and target milestone noted in a consistent
comment format so maintainers can track and unwaive later.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 34602a06-481a-48e6-b836-4864de3330bb
📒 Files selected for processing (1)
tests/integration/test_lists/waives.txt
|
PR_Github #51290 [ run ] triggered by Bot. Commit: |
|
/bot skip --comment "The previous CI passed check test list" |
|
PR_Github #51326 [ skip ] triggered by Bot. Commit: |
|
PR_Github #51290 [ run ] completed with state |
|
PR_Github #51326 [ skip ] completed with state |
Auto-generated Waive PR
Created by: TensorRT LLM CI Report (requested by @EmmaQiaoCh)
Target branch:
mainBug(s): 6144270, 6156233, 6191524, 6248744, 6248757, 6248764, 6248769, 6248776, 6248783, 6248827, 6248837
Waive entries added
This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.
Summary by CodeRabbit