[None][infra] Waive 11 failed cases for main in post-merge 2760 - #15003
Conversation
Bug(s): 6272556, 6272573, 6272598, 6272608, 6272644, 6272653, 6272656, 6272668, 6272673 Requested by: @EmmaQiaoCh Signed-off-by: ZhanruiSunCh <184402041+ZhanruiSunCh@users.noreply.github.com>
📝 WalkthroughWalkthroughUpdated ChangesTest Waiver Additions
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/integration/test_lists/waives.txt`:
- Line 330: The waiver entry uses a directory path "unittest/_torch/executor"
which won't match collected tests because apply_waives_ut only supports exact
file/function/nodeid matches; update the waiver list to reference explicit test
file paths or nodeids under that directory (for example
"unittest/_torch/executor/<test_file>.py" or specific nodeids) so
apply_waives_ut will correctly skip the intended tests, and verify against the
parser logic in tests/unittest/conftest.py::apply_waives_ut when choosing names.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 01412b83-c8e5-46cf-be2e-59e48bd9a738
📒 Files selected for processing (1)
tests/integration/test_lists/waives.txt
Signed-off-by: Emma Qiao <qqiao@nvidia.com>
|
/bot run |
|
PR_Github #52328 [ run ] triggered by Bot. Commit: |
|
/bot skip --comment "Previous CI passed check test list" |
|
PR_Github #52339 [ skip ] triggered by Bot. Commit: |
|
PR_Github #52328 [ run ] completed with state |
|
PR_Github #52339 [ skip ] completed with state |
…IA#15003) Signed-off-by: ZhanruiSunCh <184402041+ZhanruiSunCh@users.noreply.github.com> Signed-off-by: Emma Qiao <qqiao@nvidia.com> Co-authored-by: Emma Qiao <qqiao@nvidia.com> Signed-off-by: NVFB <186336021+NVFB@users.noreply.github.com>
…IA#15003) Signed-off-by: ZhanruiSunCh <184402041+ZhanruiSunCh@users.noreply.github.com> Signed-off-by: Emma Qiao <qqiao@nvidia.com> Co-authored-by: Emma Qiao <qqiao@nvidia.com>
Auto-generated Waive PR
Created by: TensorRT LLM CI Report (requested by @EmmaQiaoCh)
Target branch:
mainBug(s): 6272556, 6272573, 6272598, 6272608, 6272644, 6272653, 6272656, 6272668, 6272673
Waive entries added
Already waived (skipped)
unittest/_torch/modeling/test_modeling_step3p7.py::TestStep3p7Checkpoint::test_config_and_weight_accounting_1_nvfp4This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.
Summary by CodeRabbit