Skip to content

[https://nvbugs/6321874][test] Unwaive test_autotuner_distributed_str… - #15864

Closed
QiJune wants to merge 1 commit into
NVIDIA:mainfrom
QiJune:unwaive_1
Closed

[https://nvbugs/6321874][test] Unwaive test_autotuner_distributed_str…#15864
QiJune wants to merge 1 commit into
NVIDIA:mainfrom
QiJune:unwaive_1

Conversation

@QiJune

@QiJune QiJune commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

…ategy

Summary by CodeRabbit

  • Tests
    • Removed a test waiver, so the previously skipped autotuner distributed strategy test will now run again.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

…ategy

Signed-off-by: junq <22017000+QiJune@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 5dd71bb5-2cb4-4f31-929d-05771af7f2e4

📥 Commits

Reviewing files that changed from the base of the PR and between 3d78a6a and f42f281.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

A single waiver entry is removed from the test waive list, re-enabling the test_autotuner_distributed_strategy test in unittest/_torch/misc/test_autotuner.py to run instead of being skipped.

Changes

Waiver List Update

Layer / File(s) Summary
Remove test skip waiver entry
tests/integration/test_lists/waives.txt
The SKIP entry for unittest/_torch/misc/test_autotuner.py::test_autotuner_distributed_strategy is removed, allowing that test to run instead of being skipped.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: yuxianq, pcastonguay

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is mostly template text and lacks the required issue summary, solution details, and test coverage. Replace the template text with a brief problem/solution summary and add specific test coverage plus any checklist items that apply.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the main change: removing the waiver for the autotuner distributed strategy test.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@QiJune

QiJune commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #57091 [ run ] triggered by Bot. Commit: f42f281 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #57091 [ run ] completed with state FAILURE. Commit: f42f281
/LLM/main/L0_MergeRequest_PR pipeline #45878 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@QiJune

QiJune commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #57145 [ run ] triggered by Bot. Commit: f42f281 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #57145 [ run ] completed with state FAILURE. Commit: f42f281
/LLM/main/L0_MergeRequest_PR pipeline #45926 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@QiJune QiJune closed this Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants