Skip to content

[None][chore] Waive failing allreduce tests#15850

Merged
brb-nv merged 1 commit into
NVIDIA:mainfrom
brb-nv:user/brb/waive-failing-ad-tests
Jul 1, 2026
Merged

[None][chore] Waive failing allreduce tests#15850
brb-nv merged 1 commit into
NVIDIA:mainfrom
brb-nv:user/brb/waive-failing-ad-tests

Conversation

@brb-nv

@brb-nv brb-nv commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Description

Waive failing allreduce tests.

Test Coverage

N/A

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Summary by CodeRabbit

  • Tests
    • Updated integration test waivers to account for two additional skipped configurations, helping keep automated test runs aligned with known issues and reducing false failures.

Signed-off-by: Balaram Buddharaju <169953907+brb-nv@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 25ff812f-7112-434b-8111-394aa3c4be0e

📥 Commits

Reviewing files that changed from the base of the PR and between 50ea42a and 3a09f56.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

This PR adds two new skip entries to the integration test waivers list, disabling test_allreduce_strategies for the ONESHOT and TWOSHOT strategy configurations on DGX_B200 multigpu auto-deploy custom ops tests, referencing an existing NV bug URL.

Changes

Waiver List Update

Layer / File(s) Summary
Add ONESHOT and TWOSHOT waiver entries
tests/integration/test_lists/waives.txt
Added two new skip lines for test_allreduce_strategies[ONESHOT] and test_allreduce_strategies[TWOSHOT] under DGX_B200 multigpu auto_deploy custom_ops tests, referencing the same NV bug URL as the existing MIN_LATENCY entry.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: jieli-matrix, yingguo-trt, StanleySun639

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title follows the required template and accurately summarizes the change to waive failing allreduce tests.
Description check ✅ Passed The description includes the required Description, Test Coverage, and PR Checklist sections and is mostly complete.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@dpitman-nvda

Copy link
Copy Markdown
Collaborator

/bot skip --comment "Waive only"

@brb-nv
brb-nv enabled auto-merge (squash) July 1, 2026 20:27
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #57021 [ skip ] triggered by Bot. Commit: 3a09f56 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #57021 [ skip ] completed with state SUCCESS. Commit: 3a09f56
Skipping testing for commit 3a09f56

Link to invocation

@brb-nv
brb-nv merged commit 920a50a into NVIDIA:main Jul 1, 2026
12 checks passed
evezhier pushed a commit to evezhier/TensorRT-LLM that referenced this pull request Jul 2, 2026
Signed-off-by: Balaram Buddharaju <169953907+brb-nv@users.noreply.github.com>
BrianLi23 pushed a commit to BrianLi23/TensorRT-LLM that referenced this pull request Jul 9, 2026
Signed-off-by: Balaram Buddharaju <169953907+brb-nv@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants