Skip to content

[https://nvbugs/6473161][chore] unwaive 4 TestLlama3_1 tests - #16824

Merged
lori-ren merged 1 commit into
NVIDIA:mainfrom
lori-ren:chore/unwaive-bug6473161
Jul 24, 2026
Merged

[https://nvbugs/6473161][chore] unwaive 4 TestLlama3_1 tests#16824
lori-ren merged 1 commit into
NVIDIA:mainfrom
lori-ren:chore/unwaive-bug6473161

Conversation

@lori-ren

@lori-ren lori-ren commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Dev Engineer Review

  • Removed the four intended L40S waivers for TestLlama3_1_8BInstruct FP8 tests across FLASHINFER, torch compile, and both FP8 KV settings.
  • Waiver formatting and scope remain consistent; no unrelated entries were changed.

QA Engineer Review

  • Modified test-list file: tests/integration/test_lists/waives.txt
    • Removed four waivers for test_fp8 and test_fp8_4gpus.
    • No test-db/ or qa/ files were modified.
  • Verdict: needs follow-up because CBTS coverage data is unavailable.

Description

Tests

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: Lori Ren <lorir@nvidia.com>
@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 252e0ef5-42fc-4d15-a29b-fa5f0eed5ebb

📥 Commits

Reviewing files that changed from the base of the PR and between cf49225 and b73dd70.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt

Walkthrough

Four L40S-scoped waivers are removed for TestLlama3_1_8BInstruct FP8 tests using FLASHINFER attention, torch_compile=True, and both fp8kv settings.

Changes

Integration waiver updates

Layer / File(s) Summary
Remove L40S FP8 waivers
tests/integration/test_lists/waives.txt
Removes four waiver entries covering test_fp8 and test_fp8_4gpus with both fp8kv=False and fp8kv=True.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: emmaqiaoch, niukuo, qijune, stanleysun639

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise, uses the required ticket/type format, and accurately describes unwaiving four tests.
Description check ✅ Passed The description follows the template and clearly explains the change and reason, though Test Coverage is left empty.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@lori-ren

Copy link
Copy Markdown
Contributor Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #61494 [ run ] triggered by Bot. Commit: b73dd70 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #61494 [ run ] completed with state SUCCESS. Commit: b73dd70
/LLM/main/L0_MergeRequest_PR pipeline #49713 completed with status: 'SUCCESS'

CI Report

Link to invocation

@lori-ren
lori-ren merged commit 2fbb367 into NVIDIA:main Jul 24, 2026
12 checks passed
@lori-ren
lori-ren deleted the chore/unwaive-bug6473161 branch July 24, 2026 05:50
yuanjingx87 pushed a commit to yuanjingx87/TensorRT-LLM that referenced this pull request Jul 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants