Skip to content

[None][infra] Waive 4 failed cases for main in pre-merge 49550#16798

Merged
dpitman-nvda merged 1 commit into
NVIDIA:mainfrom
trtllm-agent:trtllm-ci-report/waive-20260723-161713
Jul 23, 2026
Merged

[None][infra] Waive 4 failed cases for main in pre-merge 49550#16798
dpitman-nvda merged 1 commit into
NVIDIA:mainfrom
trtllm-agent:trtllm-ci-report/waive-20260723-161713

Conversation

@trtllm-agent

@trtllm-agent trtllm-agent commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

Auto-generated Waive PR

Created by: TensorRT LLM CI Report (requested by @dpitman-nvda)
Target branch: main
Bug(s): 6499882

Waive entries added

unittest/executor/test_proxy_fast_death.py SKIP (https://nvbugs/6499882)
unittest/executor/test_proxy_fast_death.py::test_shutdown_does_not_block_on_dead_engine SKIP (https://nvbugs/6499882)
unittest/executor/test_proxy_fast_death.py::test_shutdown_does_not_shut_down_external_session SKIP (https://nvbugs/6499882)
unittest/executor/test_proxy_fast_death.py::test_shutdown_keeps_blocking_semantics_when_engine_alive SKIP (https://nvbugs/6499882)

This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.

Dev Engineer Review

  • Added four SKIP waivers for unittest/executor/test_proxy_fast_death.py and its shutdown/session test cases.
  • Entries consistently reference bug 6499882; no public API or code changes.
  • Waiver scope and formatting are appropriate.

QA Engineer Review

  • Modified: tests/integration/test_lists/waives.txt
  • Added four CI skip entries; no test-db or QA files were modified.
  • CBTS coverage data is unavailable; verdict: needs follow-up.

Bug(s): 6499882
Requested by: @dpitman-nvda

Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
@dpitman-nvda

Copy link
Copy Markdown
Collaborator

/bot skip --comment "Waive only"

@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

Four SKIP entries were added to the integration waiver list for the proxy fast-death test module and three shutdown/session test cases, all linked to https://nvbugs/6499882.

Changes

Test waiver updates

Layer / File(s) Summary
Proxy fast-death waiver entries
tests/integration/test_lists/waives.txt
Adds four SKIP entries covering the module and three shutdown/session-related test cases.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: qijune, brnguyen2, emmaqiaoch

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is missing the required template sections and most checklist/test details. Add the @coderabbitai summary, Description, Test Coverage, and PR Checklist sections, then summarize the waive rationale and validation.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies an infra waive for four failed cases and matches the PR's main change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@tests/integration/test_lists/waives.txt`:
- Around line 369-372: Remove the module-level waiver for
unittest/executor/test_proxy_fast_death.py from the waiver list, keeping only
the three existing test-specific :: entries for bug 6499882. Ensure unaffected
tests in that module are no longer skipped.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 8557aaa9-6a15-4207-9126-660187ccabac

📥 Commits

Reviewing files that changed from the base of the PR and between 77774d9 and 7aed3e8.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt

Comment thread tests/integration/test_lists/waives.txt
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #61333 [ skip ] triggered by Bot. Commit: 7aed3e8 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #61333 [ skip ] completed with state SUCCESS. Commit: 7aed3e8
Skipping testing for commit 7aed3e8

Link to invocation

@dpitman-nvda
dpitman-nvda merged commit f4e692d into NVIDIA:main Jul 23, 2026
12 checks passed
hhzhang16 added a commit to hhzhang16/TensorRT-LLM that referenced this pull request Jul 23, 2026
…nnahz/dep-1083-port-flashinfer-stable-va-lifecycle-for-native-all-reduce

* 'main' of https://github.com/NVIDIA/TensorRT-LLM: (83 commits)
  [None][feat] Bind SourceIdentity to checkpoint artifacts (NVIDIA#16159)
  [None][infra] Waive 4 failed cases for main in pre-merge 49550 (NVIDIA#16798)
  [None][fix] Make FlashInfer sampling op wrappers opaque to Dynamo (NVIDIA#16732)
  [None][feat] top-k: route decode to CuTe DSL GVR top-k in e2e (NVIDIA#16420)
  [None][feat] Default GLM-5 to the Python KV-cache transceiver (NVIDIA#16524)
  [None][chore] Add NVTX ranges to per-iteration ADP sync points in PyExecutor (NVIDIA#16422)
  [https://nvbugs/6426850][test] Unwaive Qwen3.5 397B NVFP4 ADP4 TRTLLM test (NVIDIA#16348)
  [https://nvbugs/6445456][fix] Restore inplace ops for functionalization v2 (NVIDIA#16410)
  [None][infra] Waive 1 failed cases for main in pre-merge 49229 (NVIDIA#16786)
  [None][fix] Load DeepSeek V4 mixed-precision NVFP4 checkpoints (NVIDIA#16433)
  [None][feat] ADP conversation router: configurable least-queued placement for new conversations (NVIDIA#16294)
  [None][infra] Waive 1 failed cases for main in pre-merge 49424 (NVIDIA#16780)
  [None][infra] Waive 1 failed cases for main in pre-merge 49424 (NVIDIA#16781)
  [TRTLLMINF-188][infra] Require approval for PerfSanity wildcard runs (NVIDIA#16777)
  [TRTLLM-13969][feat] Support MiniMax M3 for Disaggregated Serving (NVIDIA#16017)
  [NVIDIA#11932][fix] Filter CUTLASS MoE GEMM tile configs by device shared memory on SM121 (NVIDIA#12704)
  [None][chore] Remove attention backend test waivers (NVIDIA#16723)
  [TRTLLM-14540][perf] Skip fp32 state round-trip in FlashInfer GDN pre… (NVIDIA#16703)
  [TRTLLM-13694][feat] Add IBDB recipe provenance and refresh configs (NVIDIA#16254)
  [None][infra] Preview/bump/main (NVIDIA#16758)
  ...

Signed-off-by: Hannah Zhang <hannahz@nvidia.com>
yuanjingx87 pushed a commit to yuanjingx87/TensorRT-LLM that referenced this pull request Jul 26, 2026
…A#16798)

Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants