Skip to content

[https://nvbugs/5542878][fix] Unwaive test - #8027

Merged
MartinMarciniszyn merged 1 commit into
NVIDIA:mainfrom
2ez4bz:dev-unwaive-acc-test
Oct 14, 2025
Merged

[https://nvbugs/5542878][fix] Unwaive test#8027
MartinMarciniszyn merged 1 commit into
NVIDIA:mainfrom
2ez4bz:dev-unwaive-acc-test

Conversation

@2ez4bz

@2ez4bz 2ez4bz commented Sep 26, 2025

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Tests
    • Re-enabled an integration test on A100 GPUs for the Mistral Small 24B auto-dtype scenario, removing a prior skip.
    • The test now runs in CI on A100 hardware to improve coverage and earlier regression detection.
    • No runtime or user-facing behavior changed; this update solely strengthens validation on A100 environments.
    • All other existing test waivers remain unchanged.

[https://nvbugs/5542878][fix] Unwaive test

Could not repro failures described in the bugs (bug 5542928 is for the same test but on H100).

image image

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@coderabbitai

coderabbitai Bot commented Sep 26, 2025

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

A single SKIP entry was removed from tests/integration/test_lists/waives.txt, re-enabling TestMistralSmall24B::test_auto_dtype on A100. No other modifications or logic changes were made.

Changes

Cohort / File(s) Summary of Changes
Integration test waivers
tests/integration/test_lists/waives.txt
Removed one SKIP entry for A100 related to TestMistralSmall24B::test_auto_dtype, enabling the test on A100; all other waivers unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR description references the NVBugs ID and provides context with screenshots but does not follow the required bolded title format, omits a dedicated “## Description” heading, and leaves the “## Test Coverage” section empty. This deviates from the repository’s PR template which requires a proper title, structured description, and test coverage details. While the PR Checklist and GitHub Bot Help sections are present, essential template elements are not fulfilled. As a result, the description is incomplete against the required template. Please update the PR title to match the template with bolded [ticket][type] Summary, add a dedicated “## Description” section explaining the issue, changes, and rationale, and populate the “## Test Coverage” section with specific test cases or safeguards. Ensure the listed tests clearly validate the unwaived test behavior. After updating these sections, confirm alignment with TRT-LLM coding guidelines and that all checklist items are addressed.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title succinctly captures the primary change by indicating that a test waiver is being removed, correctly includes the NVBugs reference and the “[fix]” tag, and directly summarizes the main change without unnecessary detail or noise.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@2ez4bz

2ez4bz commented Sep 26, 2025

Copy link
Copy Markdown
Collaborator Author

/bot run --extra-stage "H100_PCIe-PyTorch-Post-Merge-1"

@2ez4bz
2ez4bz requested a review from EmmaQiaoCh September 26, 2025 14:04
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #20102 [ run ] triggered by Bot

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #20102 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15146 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

@2ez4bz
2ez4bz force-pushed the dev-unwaive-acc-test branch from e3d5455 to 711133c Compare October 10, 2025 16:57
@2ez4bz
2ez4bz requested a review from a team October 10, 2025 16:57
@2ez4bz
2ez4bz requested a review from a team as a code owner October 10, 2025 16:57
@2ez4bz
2ez4bz requested a review from Shixiaowei02 October 10, 2025 16:57
@2ez4bz

2ez4bz commented Oct 10, 2025

Copy link
Copy Markdown
Collaborator Author

/bot run --extra-stage "H100_PCIe-PyTorch-Post-Merge-1"

@2ez4bz

2ez4bz commented Oct 10, 2025

Copy link
Copy Markdown
Collaborator Author

/bot kill

@2ez4bz
2ez4bz force-pushed the dev-unwaive-acc-test branch from 711133c to d8c5f55 Compare October 10, 2025 17:08
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #21045 [ run ] triggered by Bot

@2ez4bz

2ez4bz commented Oct 10, 2025

Copy link
Copy Markdown
Collaborator Author

/bot run --extra-stage "H100_PCIe-PyTorch-Post-Merge-1"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #21046 [ kill ] triggered by Bot

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #21045 [ run ] completed with state ABORTED

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #21046 [ kill ] completed with state SUCCESS
Successfully killed previous jobs for commit d8c5f55

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #21048 [ run ] triggered by Bot

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #21048 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15911 completed with status: 'FAILURE'

@2ez4bz

2ez4bz commented Oct 10, 2025

Copy link
Copy Markdown
Collaborator Author

/bot run --extra-stage "H100_PCIe-PyTorch-Post-Merge-1"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #21053 [ run ] triggered by Bot

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #21053 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15914 completed with status: 'FAILURE'

@2ez4bz
2ez4bz force-pushed the dev-unwaive-acc-test branch from d8c5f55 to 0f44537 Compare October 13, 2025 16:02
@2ez4bz

2ez4bz commented Oct 13, 2025

Copy link
Copy Markdown
Collaborator Author

/bot run --extra-stage "H100_PCIe-PyTorch-Post-Merge-1"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #21236 [ run ] triggered by Bot

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #21236 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #16029 completed with status: 'FAILURE'

Signed-off-by: William Zhang <133824995+2ez4bz@users.noreply.github.com>
@2ez4bz
2ez4bz force-pushed the dev-unwaive-acc-test branch from 0f44537 to c452952 Compare October 13, 2025 23:43
@2ez4bz

2ez4bz commented Oct 13, 2025

Copy link
Copy Markdown
Collaborator Author

/bot run --extra-stage "H100_PCIe-PyTorch-Post-Merge-1"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #21259 [ run ] triggered by Bot

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #21259 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #16050 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

@MartinMarciniszyn
MartinMarciniszyn merged commit 72d65d0 into NVIDIA:main Oct 14, 2025
5 checks passed
govind-ramnarayan pushed a commit to nv-auto-deploy/TensorRT-LLM that referenced this pull request Oct 21, 2025
Signed-off-by: William Zhang <133824995+2ez4bz@users.noreply.github.com>
yufeiwu-nv pushed a commit to yufeiwu-nv/TensorRT-LLM that referenced this pull request Oct 24, 2025
Signed-off-by: William Zhang <133824995+2ez4bz@users.noreply.github.com>
Signed-off-by: yufeiwu-nv <230315618+yufeiwu-nv@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants