[None][chore] Remove attention backend test waivers#16723
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
WalkthroughRemoved two integration-test waiver entries for bf16 and fp8 attention backend cases using the ChangesAttention backend waiver updates
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>
|
/bot run --disable-fail-fast |
|
PR_Github #60965 [ run ] triggered by Bot. Commit: |
|
PR_Github #60965 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #61159 [ run ] triggered by Bot. Commit: |
|
PR_Github #61159 [ run ] completed with state |
…nnahz/dep-1083-port-flashinfer-stable-va-lifecycle-for-native-all-reduce * 'main' of https://github.com/NVIDIA/TensorRT-LLM: (83 commits) [None][feat] Bind SourceIdentity to checkpoint artifacts (NVIDIA#16159) [None][infra] Waive 4 failed cases for main in pre-merge 49550 (NVIDIA#16798) [None][fix] Make FlashInfer sampling op wrappers opaque to Dynamo (NVIDIA#16732) [None][feat] top-k: route decode to CuTe DSL GVR top-k in e2e (NVIDIA#16420) [None][feat] Default GLM-5 to the Python KV-cache transceiver (NVIDIA#16524) [None][chore] Add NVTX ranges to per-iteration ADP sync points in PyExecutor (NVIDIA#16422) [https://nvbugs/6426850][test] Unwaive Qwen3.5 397B NVFP4 ADP4 TRTLLM test (NVIDIA#16348) [https://nvbugs/6445456][fix] Restore inplace ops for functionalization v2 (NVIDIA#16410) [None][infra] Waive 1 failed cases for main in pre-merge 49229 (NVIDIA#16786) [None][fix] Load DeepSeek V4 mixed-precision NVFP4 checkpoints (NVIDIA#16433) [None][feat] ADP conversation router: configurable least-queued placement for new conversations (NVIDIA#16294) [None][infra] Waive 1 failed cases for main in pre-merge 49424 (NVIDIA#16780) [None][infra] Waive 1 failed cases for main in pre-merge 49424 (NVIDIA#16781) [TRTLLMINF-188][infra] Require approval for PerfSanity wildcard runs (NVIDIA#16777) [TRTLLM-13969][feat] Support MiniMax M3 for Disaggregated Serving (NVIDIA#16017) [NVIDIA#11932][fix] Filter CUTLASS MoE GEMM tile configs by device shared memory on SM121 (NVIDIA#12704) [None][chore] Remove attention backend test waivers (NVIDIA#16723) [TRTLLM-14540][perf] Skip fp32 state round-trip in FlashInfer GDN pre… (NVIDIA#16703) [TRTLLM-13694][feat] Add IBDB recipe provenance and refresh configs (NVIDIA#16254) [None][infra] Preview/bump/main (NVIDIA#16758) ... Signed-off-by: Hannah Zhang <hannahz@nvidia.com>
Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>
Dev Engineer Review
tests/integration/test_lists/waives.txtto remove the twoSKIPwaiver lines forunittest/_torch/attention/test_attention_backends.py::test_attention_backendcovering the GPT-OSS GQAgpt_oss_gqa_hd64_gptj_swa128-ctxcase fordtype=bf16anddtype=fp8(backendHND-p32-v1).waives.txtentries matchingtest_attention_backendfor thegpt_oss_gqa_hd64_gptj_swa128-ctxcase (so CI should no longer find matching waivers to skip these tests).QA Engineer Review
tests/integration/test_lists/waives.txt:...::test_attention_backendongpt_oss_gqa_hd64_gptj_swa128-ctx(dtype=bf16, backendHND-p32-v1)....::test_attention_backendongpt_oss_gqa_hd64_gptj_swa128-ctx(dtype=fp8, backendHND-p32-v1).Description
Remove the waivers for the BF16 and FP8 GPT-OSS GQA
test_attention_backendcases so both cases run in CI again.Test Coverage
pre-commit run --files tests/integration/test_lists/waives.txttests/integration/defs/test_list_parser.pypython scripts/check_test_list.py --validatetest_attention_backendwaiver remainsPR Checklist
GitHub Bot Help
To see a list of available CI bot commands, comment
/bot help.