Skip to content

[None][chore] Remove attention backend test waivers#16723

Merged
yuxianq merged 2 commits into
NVIDIA:mainfrom
yuxianq:chore/remove-attention-backend-waives
Jul 23, 2026
Merged

[None][chore] Remove attention backend test waivers#16723
yuxianq merged 2 commits into
NVIDIA:mainfrom
yuxianq:chore/remove-attention-backend-waives

Conversation

@yuxianq

@yuxianq yuxianq commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Dev Engineer Review

  • Updated tests/integration/test_lists/waives.txt to remove the two SKIP waiver lines for unittest/_torch/attention/test_attention_backends.py::test_attention_backend covering the GPT-OSS GQA gpt_oss_gqa_hd64_gptj_swa128-ctx case for dtype=bf16 and dtype=fp8 (backend HND-p32-v1).
  • Verified that there are no remaining waives.txt entries matching test_attention_backend for the gpt_oss_gqa_hd64_gptj_swa128-ctx case (so CI should no longer find matching waivers to skip these tests).
  • Kept waiver file format/scope consistent (no replacement waivers or unrelated entries added).

QA Engineer Review

  • Modified tests/integration/test_lists/waives.txt:
    • Removed the BF16 waiver for ...::test_attention_backend on gpt_oss_gqa_hd64_gptj_swa128-ctx (dtype=bf16, backend HND-p32-v1).
    • Removed the FP8 waiver for ...::test_attention_backend on gpt_oss_gqa_hd64_gptj_swa128-ctx (dtype=fp8, backend HND-p32-v1).
  • No test code changes.
  • Verdict: needs follow-up pending CBTS coverage data.

Description

Remove the waivers for the BF16 and FP8 GPT-OSS GQA test_attention_backend cases so both cases run in CI again.

Test Coverage

  • pre-commit run --files tests/integration/test_lists/waives.txt
  • Parsed all waiver entries with tests/integration/defs/test_list_parser.py
  • python scripts/check_test_list.py --validate
  • Verified no matching test_attention_backend waiver remains

PR Checklist

  • PR description clearly explains what and why.
  • PR follows the TRT-LLM coding guidelines.
  • No new code paths or dependencies are introduced.
  • No API, CODEOWNERS, documentation, or architecture changes are required.
  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, comment /bot help.

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: b448c458-0c40-4b68-9a01-bc3845f70911

📥 Commits

Reviewing files that changed from the base of the PR and between dd524f0 and 8e2fc87.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt

Walkthrough

Removed two integration-test waiver entries for bf16 and fp8 attention backend cases using the HND-p32-v1 configuration.

Changes

Attention backend waiver updates

Layer / File(s) Summary
Remove obsolete attention backend waivers
tests/integration/test_lists/waives.txt
Removes SKIP entries for the gpt_oss_gqa_hd64_gptj_swa128-ctx case with bf16 and fp8 dtypes.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: stanleysun639

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: removing attention backend test waivers.
Description check ✅ Passed The description follows the template and includes a clear description, test coverage, and checklist items.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>
@yuxianq

yuxianq commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #60965 [ run ] triggered by Bot. Commit: dd524f0 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #60965 [ run ] completed with state FAILURE. Commit: dd524f0
/LLM/main/L0_MergeRequest_PR pipeline #49227 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@yuxianq

yuxianq commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #61159 [ run ] triggered by Bot. Commit: 8e2fc87 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #61159 [ run ] completed with state SUCCESS. Commit: 8e2fc87
/LLM/main/L0_MergeRequest_PR pipeline #49409 completed with status: 'SUCCESS'

CI Report

Link to invocation

@yuxianq
yuxianq merged commit 0a401b4 into NVIDIA:main Jul 23, 2026
10 checks passed
hhzhang16 added a commit to hhzhang16/TensorRT-LLM that referenced this pull request Jul 23, 2026
…nnahz/dep-1083-port-flashinfer-stable-va-lifecycle-for-native-all-reduce

* 'main' of https://github.com/NVIDIA/TensorRT-LLM: (83 commits)
  [None][feat] Bind SourceIdentity to checkpoint artifacts (NVIDIA#16159)
  [None][infra] Waive 4 failed cases for main in pre-merge 49550 (NVIDIA#16798)
  [None][fix] Make FlashInfer sampling op wrappers opaque to Dynamo (NVIDIA#16732)
  [None][feat] top-k: route decode to CuTe DSL GVR top-k in e2e (NVIDIA#16420)
  [None][feat] Default GLM-5 to the Python KV-cache transceiver (NVIDIA#16524)
  [None][chore] Add NVTX ranges to per-iteration ADP sync points in PyExecutor (NVIDIA#16422)
  [https://nvbugs/6426850][test] Unwaive Qwen3.5 397B NVFP4 ADP4 TRTLLM test (NVIDIA#16348)
  [https://nvbugs/6445456][fix] Restore inplace ops for functionalization v2 (NVIDIA#16410)
  [None][infra] Waive 1 failed cases for main in pre-merge 49229 (NVIDIA#16786)
  [None][fix] Load DeepSeek V4 mixed-precision NVFP4 checkpoints (NVIDIA#16433)
  [None][feat] ADP conversation router: configurable least-queued placement for new conversations (NVIDIA#16294)
  [None][infra] Waive 1 failed cases for main in pre-merge 49424 (NVIDIA#16780)
  [None][infra] Waive 1 failed cases for main in pre-merge 49424 (NVIDIA#16781)
  [TRTLLMINF-188][infra] Require approval for PerfSanity wildcard runs (NVIDIA#16777)
  [TRTLLM-13969][feat] Support MiniMax M3 for Disaggregated Serving (NVIDIA#16017)
  [NVIDIA#11932][fix] Filter CUTLASS MoE GEMM tile configs by device shared memory on SM121 (NVIDIA#12704)
  [None][chore] Remove attention backend test waivers (NVIDIA#16723)
  [TRTLLM-14540][perf] Skip fp32 state round-trip in FlashInfer GDN pre… (NVIDIA#16703)
  [TRTLLM-13694][feat] Add IBDB recipe provenance and refresh configs (NVIDIA#16254)
  [None][infra] Preview/bump/main (NVIDIA#16758)
  ...

Signed-off-by: Hannah Zhang <hannahz@nvidia.com>
yuanjingx87 pushed a commit to yuanjingx87/TensorRT-LLM that referenced this pull request Jul 26, 2026
Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants