Skip to content

Update BCL to point to the new address + remove cpprestsdk as a dependency#5626

Open
jmarrec wants to merge 12 commits into
developfrom
bcl_update
Open

Update BCL to point to the new address + remove cpprestsdk as a dependency#5626
jmarrec wants to merge 12 commits into
developfrom
bcl_update

Conversation

@jmarrec

@jmarrec jmarrec commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Pull request overview

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@jmarrec jmarrec self-assigned this Jun 29, 2026
@jmarrec jmarrec mentioned this pull request Jul 2, 2026
Draft
19 tasks
kflemin
kflemin reviewed Jul 15, 2026
View reviewed changes
Comment thread src/utilities/bcl/RemoteBCL.cpp Outdated

#define REMOTE_PRODUCTION_SERVER "https://bcl.nrel.gov"
#define REMOTE_PRODUCTION_SERVER "https://bcl.nlr.gov"
#define REMOTE_DEVELOPMENT_SERVER "https://bcl2.nrel.gov"

@kflemin kflemin Jul 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if REMOTE_DEVELOPMENT_SERVER is important, but that doesn't exist right now. could change to nlr.gov there as well? or something like bcl-test.nlr.gov which is a URL we could use for the dev server.

@jmarrec jmarrec Jul 15, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sets the BCL url to that one when remoteBCL.useRemoteDevelopmentUrl() is called...

I don't think anyone really uses that. Anyways, I changed it to bcl-test.nlr.gov.

jmarrec
jmarrec commented Jul 15, 2026
View reviewed changes
Comment thread src/utilities/bcl/RemoteBCL.cpp Outdated
jmarrec added 12 commits July 16, 2026 16:26
@jmarrec
change bcl.nrel.gov to bcl.nlr.gov
177b561
@jmarrec
Update BCL to use the new API and not the legacy
73f07a5
@jmarrec
The new API doesn't accept a TID
1a1ec2b
@jmarrec
Replace RemoteBCL cpprestsdk -> cpp-httplib. It's a bit slower, but n…
947d25d 
…ot too much

```diff
-1/5 Test #673: BCLFixture.RemoteBCLTest ...............   Passed   24.32 sec
+1/5 Test #673: BCLFixture.RemoteBCLTest ...............   Passed   26.52 sec
-2/5 Test #674: BCLFixture.RemoteBCLTest2 ..............   Passed    4.15 sec
+2/5 Test #674: BCLFixture.RemoteBCLTest2 ..............   Passed    3.43 sec
-3/5 Test #676: BCLFixture.RemoteBCLMetaSearchTest .....   Passed    4.04 sec
+3/5 Test #676: BCLFixture.RemoteBCLMetaSearchTest .....   Passed    4.97 sec
-4/5 Test #677: BCLFixture.RemoteBCL_EncodingURI .......   Passed    4.90 sec
+4/5 Test #677: BCLFixture.RemoteBCL_EncodingURI .......   Passed    5.09 sec
-5/5 Test #678: BCLFixture.RemoteBCL_BCLSearchResult ...   Passed    3.88 sec
+5/5 Test #678: BCLFixture.RemoteBCL_BCLSearchResult ...   Passed    5.25 sec
```
@jmarrec
Replace MeasureManager cpprestsdk -> httplib
b8cfd1c
@jmarrec
remove cpprestsdk and websocketpp from conan dependencies
5e85770
@jmarrec
Remove the ThreadSafeDeque workaround by using a ThreadPool with 1 th…
92b9420 
…read only
@jmarrec
unknown_endpoint should be a 404
24666de
@jmarrec
Use the access logger / error logger facilities provided by cpp httplib
bc124d0
@jmarrec
Don't expose httplib publicly
c1b24c5
@jmarrec
cpp-httplib requires windows 10 or later, so use that when we define
efccc2e
@jmarrec
Change the Remote Dev server url to a (non-existing) bcl-test.nlr.gov
2bc1e4d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kflemin kflemin kflemin left review comments
@kbenne kbenne Awaiting requested review from kbenne
@joseph-robertson joseph-robertson Awaiting requested review from joseph-robertson

Assignees

@jmarrec jmarrec

Labels

component - Conan Dependency / Package manager problems component - Measure Manager component - Measures severity - Blocker

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BCL is pointing to the old, completely removed, URL Consider removing cpprestsdk as a dependency

2 participants

@jmarrec @kflemin