Skip to content

Redid README.md, includes new logo (Can be updated later when website is acutally up) - #122

Closed
EthanBoiLol wants to merge 17 commits into
Redot-Engine:masterfrom
EthanBoiLol:master
Closed

Redid README.md, includes new logo (Can be updated later when website is acutally up)#122
EthanBoiLol wants to merge 17 commits into
Redot-Engine:masterfrom
EthanBoiLol:master

Conversation

@EthanBoiLol

Copy link
Copy Markdown

No description provided.

@addmix

addmix commented Oct 3, 2024

Copy link
Copy Markdown
Contributor

You should probably squash your commits, that way changes can be reviewed effectively.

@Mizumo-prjkt

Mizumo-prjkt commented Oct 3, 2024

Copy link
Copy Markdown

lol this chain reminds me back in the days i used git and github lol

edit: *actually

@Pierouge

Pierouge commented Oct 3, 2024

Copy link
Copy Markdown

Shouldn't the redot website url be lowercase ? (Not breaking anything tho) Also, shouldn't the logo be the red/orange robot one ?

Comment thread README.md
<p align="center">
<a href="https://godotengine.org">
<img src="logo_outlined.svg" width="400" alt="Godot Engine logo">
<a href="https://Redotengine.org">

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the redot link should be lowercase as stated by @Pierouge

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, now I just gotta figure out how to squash my commits via online github lol

@Mizumo-prjkt

Copy link
Copy Markdown

can u try check discord about the new logo because if i remember its now looking like retro or something on x

Redotengine.org -> redotengine.org
@EthanBoiLol

Copy link
Copy Markdown
Author

can u try check discord about the new logo because if i remember its now looking like retro or something on x

Will join the server soon to find the new logo, sadly might take a bit as my life is kinda busy rn

@Pierouge

Pierouge commented Oct 4, 2024

Copy link
Copy Markdown

iE73HOlSU6SMkCRsXYLs-RMR6lWEur619O9c413JKGY.jpg

@Mizumo-prjkt

Copy link
Copy Markdown

FB_IMG_1727379225091.jpg

Will wait

@73NN0

73NN0 commented Oct 4, 2024

Copy link
Copy Markdown

please see #145 and #135

@73NN0 73NN0 mentioned this pull request Oct 5, 2024
@Redot-Engine Redot-Engine deleted a comment Oct 6, 2024

@Zynos-Logan Zynos-Logan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes have been addressed through pull request: #627

The links to Twitter are a good addition and will likely be added in a future pr . If you would open a new pr titled "Add Twitter links to README.md " based on the current redot-code-merge branch and ensure the new pr targets that branch.

As such this pr can be closed.

Thank you for your work 😊

@Zynos-Logan

Copy link
Copy Markdown
Contributor

These changes have been addressed through pull request: #627

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants