Doc/update readme - #164
Conversation
|
This is a good Pull Request and will make the merge easier. |
yarbelk
left a comment
yarbelk
left a comment
There was a problem hiding this comment.
Nice simple changes, but got a Godot reference left over on line 41
| Official binaries for the Godot editor and the export templates can be found | ||
| [on the Godot website](https://godotengine.org/download). | ||
| Official binaries for the Redot editor and the export templates can be found | ||
| [on the Godot website](https://redotengine.org/download). |
This should be: [on the Redot website] on line 41 |
| as well as a list of [awesome Godot community resources](https://github.com/Redot-Engine/redot-awesome). | ||
|
|
||
| There are also a number of other | ||
| [learning resources](https://docs.godotengine.org/en/latest/community/tutorials.html) |
|
Hello, Sorry for the many changes I fixup my pr for update most of the badges. I don't know how update the TODOs one |
TODOs? |
Yes this one on ligne 79 (commented now) |
You can't update it? |
Does this suit you? The TODOs badge For the time being, I've taken the liberty of putting a link to Open Issues. |
|
|
||
| [](https://github.com/Redot-Engine/redot-engine/issues) | ||
|
|
||
| <!-- [](https://www.tickgit.com/browse?repo=github.com/godotengine/godot) --> |
|
I have a question, |
Not sure. The project haven't any donations for now |
I updated the community section |
|
How can we call reviewers here? |
What do you mean ? |
I think it's ready now. Need to approve. |
|
move your README changes to the redot-merge branch, the image changes are already done. |
#193 image is with issue |
Hello i will rebase my branch |
|
please @Bioblaze can you confirm me that the last commit of the redot-merge branch has 887264b as SHA-256 ? it currently rebased on the redot-engine's master branch. I prepared a commit for the case where indeed you want me to insert my modifications on the readme on "redot-merge" branch. I will just have to reset hard on this commit ^^
|
|
I saw that the redot-merge branch was merged.... the commit have only the readme changes
|
|
Please, remove that white text path from logo-outlined.svg Thanks! |
|
Hello, This logo story is very exciting but very messy. I can reintegrate pr #145 very easily. PS: if you see modifications other than those to the readme, it's because I'm currently rebasing on the Bioblaze pr. Rebase instead of merge the Rhysjosmin's work
|
Looks great! |
|
if theses changes take too long to happen this will probably lead to problems with the godot foundation. |
|
|
|
Thanks for your suggestions, but I can't manage the logo. The original purpose of this pr was to merge several about README.md, it turns out that the logo is linked and the only PR at the time was that of Rhysjosmin. According to the following message : #164 (comment) the icons and logos have been updated, see with staff members. If you have a suggestion I suggest you discuss it on the discord server |
|
finaly rebased on master to be independant from other PR. |
But GitHub writes obiwor wants to merge 1 commit into Redot-Engine:master from obiwor:doc/update-readme |
By master I mean the redot-engine 's master branch |
11 participants
Hello,
I'm new on this project, I want to contribute and this is my first Pull Request.
I just saw many Pull Requests about the Readme.md file, this Pull Request is an attempt to merge theses Pull Requests :
Please review my Pull Request, I will be glad to help you.
Regards,
Obiwor