Skip to content

Update README.md - #135

Closed
NosiDev wants to merge 4 commits into
Redot-Engine:masterfrom
NosiDev:master
Closed

Update README.md#135
NosiDev wants to merge 4 commits into
Redot-Engine:masterfrom
NosiDev:master

Conversation

@NosiDev

@NosiDev NosiDev commented Oct 3, 2024

Copy link
Copy Markdown

No description provided.

@jsbrucker jsbrucker left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change should update a few other links assuming this fork is going to migrate everything from the source project and is intended to stand by itself.

Comment thread README.md Outdated
# Redot Engine x Godot Engine

<p align="center">
<a href="https://godotengine.org">

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget this link

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redot Engine not Redot Engine x Godot Engine

Comment thread README.md Outdated
Before being open sourced in [February 2014](https://github.com/godotengine/godot/commit/0b806ee0fc9097fa7bda7ac0109191c9c5e0a1ac),
Godot had been developed by [Juan Linietsky](https://github.com/reduz) and
Before being open sourced in [February 2014](https://github.com/redotengine/godot/commit/0b806ee0fc9097fa7bda7ac0109191c9c5e0a1ac),
Redot had been developed by [Juan Linietsky](https://github.com/reduz) and

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps, "Redot was originally developed as Godot by ..." would be better?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes you're right

Comment thread README.md Outdated

Before being open sourced in [February 2014](https://github.com/godotengine/godot/commit/0b806ee0fc9097fa7bda7ac0109191c9c5e0a1ac),
Godot had been developed by [Juan Linietsky](https://github.com/reduz) and
Before being open sourced in [February 2014](https://github.com/redotengine/godot/commit/0b806ee0fc9097fa7bda7ac0109191c9c5e0a1ac),

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the repo name will also need to be updated to redot here. Though maybe ot will be better to keep this linking to the prior repo?

Comment thread README.md Outdated
titles.

![Screenshot of a 3D scene in the Godot Engine editor](https://raw.githubusercontent.com/godotengine/godot-design/master/screenshots/editor_tps_demo_1920x1080.jpg)
![Screenshot of a 3D scene in the Redot Engine editor](https://raw.githubusercontent.com/godotengine/godot-design/master/screenshots/editor_tps_demo_1920x1080.jpg)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should link to a redotengine asset

Corrections
@NosiDev

NosiDev commented Oct 4, 2024

Copy link
Copy Markdown
Author

I just made another commit to update the changes with the corrections you suggested

Comment thread README.md Outdated
Comment thread README.md Outdated
NosiDev and others added 2 commits October 6, 2024 01:03
Co-authored-by: cinderbrick1212 <107356645+cinderbrick1212@users.noreply.github.com>
Co-authored-by: cinderbrick1212 <107356645+cinderbrick1212@users.noreply.github.com>
@Redot-Engine Redot-Engine deleted a comment Oct 6, 2024

@Zynos-Logan Zynos-Logan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes have been addressed through pull request: #627

As such this pr can be closed.

Thank you for your work 😊

@Zynos-Logan

Copy link
Copy Markdown
Contributor

These changes have been addressed through pull request: #627

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants