Skip to content

[FEAT] /gh me Github Profile Feature with Share Profile and Issue Display#32

Merged
Sing-Li merged 29 commits into
RocketChat:mainfrom
henit-chobisa:GithubProfile
Nov 30, 2022
Merged

[FEAT] /gh me Github Profile Feature with Share Profile and Issue Display#32
Sing-Li merged 29 commits into
RocketChat:mainfrom
henit-chobisa:GithubProfile

Conversation

@henit-chobisa
Copy link
Copy Markdown
Contributor

@henit-chobisa henit-chobisa commented Oct 15, 2022 •
edited
Loading

Issue(s)

Closes #30

Screenshots

image

image

image

image

Video :

GH.App.Demo.mp4

Acceptance Criteria fulfillment

  • Add new slash command which triggers the UserProfileModal
  • Add new UserProfileModal and supporting modals to view relevant data - repositories, activity, starred repos etc inside Rocket.Chat
  • Add functionality to share the fetched results to Rocket.Chat channels similar to [Feature] GitHub Search #15 (comment)
  • Add the new function to fetch users data in the GitHubSDK

@henit-chobisa
feat: User Modal Initiated
381f6f6
@henit-chobisa
feat: Command Utility modified for User Profile Subcommand
d46214f
@henit-chobisa
feat: Github SDK modified for fetching User Data
d35cc69
@henit-chobisa
feat: Handlers and Subcommands Created
3e0183e
@henit-chobisa
feat: User Profile Modal Created
37c772e
@henit-chobisa
feat: Share Profile Modal Added
bfc2e40
@henit-chobisa
feat: Modal Actions Added for Profile Modal and Sharing Modal
5daa223
@henit-chobisa
feat: Modal Actiions Registered for issues, repos and feed
79cdad8
@henit-chobisa
feat: Issue and Repo actions added for User Profile Modal
5251cab
@henit-chobisa
feat: Notification and Repo Modal Templetes Added
1f7d233
@henit-chobisa
feat: Issue Search Filter Blocks Added
6ed04bf
@henit-chobisa
feat: Search Filter Actions Added
b80f774
@henit-chobisa
feat: Github SDK Configured for issue search methods
39ca927
@henit-chobisa
feat: Octicon Icons Added for Issue Modal
b33a482
@henit-chobisa
feat: Issues Modal UI Modified and Improved
52daabb
@henit-chobisa
feat: Github Issue Schema Modified for Issue Display Modal.
608bbd9
@henit-chobisa
feat: Isse Display trigger and Modal added
7fb70da
@henit-chobisa
feat : Github SDK modified for issue data
e6c2a81
@henit-chobisa
feat : Issue Display Modal Added to UI
34d4ac5
@henit-chobisa
feat: Body Markdown renderer added
098dbd1
@henit-chobisa
refactor: Issue Filter Action Optimized with Single Action
d5d08f3
@henit-chobisa
refactor : Stats and Reactions detached from Issue Display
4575f07
@henit-chobisa
fix : User Display Model fixed with Distinct Action IDs
0a8cec0
@henit-chobisa
fix : Updated Body Parser for both heading and checkboxes
692831a
@henit-chobisa
feat : Body Renderer Added with headings and Check Boxes
c71ac74
@henit-chobisa henit-chobisa marked this pull request as ready for review November 10, 2022 19:59
@henit-chobisa henit-chobisa changed the title [ WIP ] feat: /gh me Github Profile Feature feat: /gh me Github Profile Feature with Share Profile and Issue Display Nov 10, 2022
@henit-chobisa
Copy link
Copy Markdown
Contributor Author

henit-chobisa commented Nov 13, 2022

@samad-yar-khan
Hello Samad, I have made the desired changes, can you please review it and suggest me the changes, so that I can fix it as soon as possible.

@henit-chobisa henit-chobisa changed the title feat: /gh me Github Profile Feature with Share Profile and Issue Display [FEAT] /gh me Github Profile Feature with Share Profile and Issue Display Nov 14, 2022
@samad-yar-khan
Copy link
Copy Markdown
Contributor

samad-yar-khan commented Nov 16, 2022

@henit-chobisa Thankyou for this PR. A much awaited feature 🙌. I will review the code changes and test it once and let you know.

@henit-chobisa
Copy link
Copy Markdown
Contributor Author

henit-chobisa commented Nov 16, 2022

@samad-yar-khan
Sure, thank you Samad!

@henit-chobisa henit-chobisa mentioned this pull request Nov 25, 2022
Closed
samad-yar-khan
samad-yar-khan reviewed Nov 30, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@samad-yar-khan samad-yar-khan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@henit-chobisa Everything looks great, just some minor changes. Please also remove all the code that is not being used at the moment as discussed in the last meeting.

Comment thread github/processors/bodyMarkdowmRenderer.ts Outdated
Comment thread github/modals/UserReposModal.ts Outdated
samad-yar-khan
samad-yar-khan reviewed Nov 30, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@samad-yar-khan samad-yar-khan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@henit-chobisa Just a few more changes. 🙌

Comment thread github/handlers/UserProfileHandler.ts Outdated
Comment thread github/lib/CreateIssueStatsBar.ts Outdated
Comment thread github/modals/UserProfileModal.ts Outdated
Comment thread github/modals/UserProfileModal.ts Outdated
Comment thread github/processors/bodyMarkdowmRenderer.ts
@samad-yar-khan
Copy link
Copy Markdown
Contributor

samad-yar-khan commented Nov 30, 2022

@henit-chobisa LGTM ! Thanks a lot for this PR 💯

@henit-chobisa
Copy link
Copy Markdown
Contributor Author

henit-chobisa commented Nov 30, 2022

@henit-chobisa LGTM ! Thanks a lot for this PR 💯

My pleasure to contribute to such an amazing concept! 😊

@Sing-Li Sing-Li merged commit 0e26f58 into RocketChat:main Nov 30, 2022
@Nabhag8848 Nabhag8848 mentioned this pull request Feb 13, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@samad-yar-khan samad-yar-khan samad-yar-khan left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

GitHub Profile

3 participants

@henit-chobisa @samad-yar-khan @Sing-Li