Skip to content

[FEAT] /gh me Github Profile Feature with Share Profile and Issue Display#32

Merged
Sing-Li merged 29 commits into
RocketChat:mainfrom
henit-chobisa:GithubProfile
Nov 30, 2022
Merged

[FEAT] /gh me Github Profile Feature with Share Profile and Issue Display#32
Sing-Li merged 29 commits into
RocketChat:mainfrom
henit-chobisa:GithubProfile

Conversation

@henit-chobisa
Copy link
Copy Markdown
Contributor

@henit-chobisa henit-chobisa commented Oct 15, 2022

Issue(s)

Closes #30

Screenshots

image

image

image

image

Video :

GH.App.Demo.mp4

Acceptance Criteria fulfillment

  • Add new slash command which triggers the UserProfileModal
  • Add new UserProfileModal and supporting modals to view relevant data - repositories, activity, starred repos etc inside Rocket.Chat
  • Add functionality to share the fetched results to Rocket.Chat channels similar to [Feature] GitHub Search #15 (comment)
  • Add the new function to fetch users data in the GitHubSDK

@henit-chobisa henit-chobisa marked this pull request as ready for review November 10, 2022 19:59
@henit-chobisa henit-chobisa changed the title [ WIP ] feat: /gh me Github Profile Feature feat: /gh me Github Profile Feature with Share Profile and Issue Display Nov 10, 2022
@henit-chobisa
Copy link
Copy Markdown
Contributor Author

@samad-yar-khan
Hello Samad, I have made the desired changes, can you please review it and suggest me the changes, so that I can fix it as soon as possible.

@henit-chobisa henit-chobisa changed the title feat: /gh me Github Profile Feature with Share Profile and Issue Display [FEAT] /gh me Github Profile Feature with Share Profile and Issue Display Nov 14, 2022
@samad-yar-khan
Copy link
Copy Markdown
Contributor

@henit-chobisa Thankyou for this PR. A much awaited feature 🙌. I will review the code changes and test it once and let you know.

@henit-chobisa
Copy link
Copy Markdown
Contributor Author

@samad-yar-khan
Sure, thank you Samad!

Copy link
Copy Markdown
Contributor

@samad-yar-khan samad-yar-khan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@henit-chobisa Everything looks great, just some minor changes. Please also remove all the code that is not being used at the moment as discussed in the last meeting.

Comment thread github/processors/bodyMarkdowmRenderer.ts Outdated
Comment thread github/modals/UserReposModal.ts Outdated
Copy link
Copy Markdown
Contributor

@samad-yar-khan samad-yar-khan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@henit-chobisa Just a few more changes. 🙌

Comment thread github/handlers/UserProfileHandler.ts Outdated
Comment thread github/lib/CreateIssueStatsBar.ts Outdated
Comment thread github/modals/UserProfileModal.ts Outdated
Comment thread github/modals/UserProfileModal.ts Outdated
Comment thread github/processors/bodyMarkdowmRenderer.ts
@samad-yar-khan
Copy link
Copy Markdown
Contributor

@henit-chobisa LGTM ! Thanks a lot for this PR 💯

@henit-chobisa
Copy link
Copy Markdown
Contributor Author

@henit-chobisa LGTM ! Thanks a lot for this PR 💯

My pleasure to contribute to such an amazing concept! 😊

@Sing-Li Sing-Li merged commit 0e26f58 into RocketChat:main Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GitHub Profile

3 participants