feat: add Enable Mobile Ringing toggle in user preferences#7155
Merged
Conversation
diegolmello
had a problem deploying
to
approve_e2e_testing
GitHub Actions
Error
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (27)
WalkthroughAdds a new "Enable Mobile Ringing" localization key across multiple locale files, extends the notification preferences interface with Changes
Sequence Diagram(s)sequenceDiagram
participant User as User (UI)
participant View as UserPreferencesView
participant Store as Redux Store / Dispatcher
participant API as saveUserPreferences (API)
User->>View: taps "Enable Mobile Ringing" toggle
View->>Store: dispatch update (preferences.enableMobileRinging = !current)
Store->>API: persist updated preferences
API-->>Store: success / error
Store-->>View: updated state or error
View-->>User: updated toggle UI (or show error)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
app/views/UserPreferencesView/index.tsx (1)
30-30: NormalizeenableMobileRingingto a boolean before binding/toggling.Using a default boolean avoids undefined-driven toggle behavior and keeps
Switchusage deterministic.Proposed fix
-const enableMobileRinging = settings?.preferences?.enableMobileRinging; +const enableMobileRinging = settings?.preferences?.enableMobileRinging ?? false;Also applies to: 144-145, 149-149
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@app/views/UserPreferencesView/index.tsx` at line 30, The enableMobileRinging value is read from settings and may be undefined—normalize it to a boolean (e.g., const enableMobileRinging = Boolean(settings?.preferences?.enableMobileRinging) or use ?? false) before passing to the Switch or toggle handlers so the component always receives a deterministic true/false; update every occurrence (the initial const enableMobileRinging and places around lines referencing the Switch/toggle at 144-149 and 149) to use the normalized boolean and ensure any toggle handlers rely on the normalized value.app/i18n/locales/en.json (1)
317-317: Add this key to non-English locale bundles before release.Line 317 introduces the new key only in
en.json; please propagate it to the other locale files so non-English/RTL users don’t get fallback/mixed-language UI.As per coding guidelines, "Place internationalization configuration and locales in app/i18n/ with support for 40+ languages and RTL".
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@app/i18n/locales/en.json` at line 317, Add the new i18n key "Enable_Mobile_Ringing" to every non-English locale bundle (including all RTL and supported language files) so no locale falls back to English; update each locale's JSON with the same key and an appropriate translated value, ensuring pluralization/formatting conventions are preserved and merge/commit the updated locale files alongside the en.json change.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@app/views/UserPreferencesView/index.tsx`:
- Around line 62-65: The dispatched payload in toggleEnableMobileRinging
overwrites the entire preferences object with only enableMobileRinging, losing
sibling preference fields; update the dispatch to merge existing preferences
(use settings.preferences or settings?.preferences) into the new preferences
object so you dispatch setUser with settings: { ...settings, preferences: {
...settings.preferences, enableMobileRinging: value } } and then call
saveUserPreferences as before.
---
Nitpick comments:
In `@app/i18n/locales/en.json`:
- Line 317: Add the new i18n key "Enable_Mobile_Ringing" to every non-English
locale bundle (including all RTL and supported language files) so no locale
falls back to English; update each locale's JSON with the same key and an
appropriate translated value, ensuring pluralization/formatting conventions are
preserved and merge/commit the updated locale files alongside the en.json
change.
In `@app/views/UserPreferencesView/index.tsx`:
- Line 30: The enableMobileRinging value is read from settings and may be
undefined—normalize it to a boolean (e.g., const enableMobileRinging =
Boolean(settings?.preferences?.enableMobileRinging) or use ?? false) before
passing to the Switch or toggle handlers so the component always receives a
deterministic true/false; update every occurrence (the initial const
enableMobileRinging and places around lines referencing the Switch/toggle at
144-149 and 149) to use the normalized boolean and ensure any toggle handlers
rely on the normalized value.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 842a9512-5b33-4c40-b67b-105a6a7bde3e
📒 Files selected for processing (3)
app/definitions/IUser.tsapp/i18n/locales/en.jsonapp/views/UserPreferencesView/index.tsx
📜 Review details
🧰 Additional context used
📓 Path-based instructions (7)
**/*.{js,jsx,ts,tsx,json}
📄 CodeRabbit inference engine (CLAUDE.md)
Configure Prettier with tabs, single quotes, 130 character width, no trailing commas, arrow parens avoid, and bracket same line
Files:
app/i18n/locales/en.jsonapp/definitions/IUser.tsapp/views/UserPreferencesView/index.tsx
app/i18n/**/*
📄 CodeRabbit inference engine (CLAUDE.md)
Place internationalization configuration and locales in app/i18n/ with support for 40+ languages and RTL
Files:
app/i18n/locales/en.json
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
Use ESLint with
@rocket.chat/eslint-configbase configuration including React, React Native, TypeScript, and Jest plugins
Files:
app/definitions/IUser.tsapp/views/UserPreferencesView/index.tsx
**/*.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
Use TypeScript with strict mode enabled and configure baseUrl to app/ for import resolution
**/*.{ts,tsx}: Use TypeScript for type safety; add explicit type annotations to function parameters and return types
Prefer interfaces over type aliases for defining object shapes in TypeScript
Use enums for sets of related constants rather than magic strings or numbers
Files:
app/definitions/IUser.tsapp/views/UserPreferencesView/index.tsx
app/definitions/**/*.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
Place shared TypeScript type definitions in app/definitions/
Files:
app/definitions/IUser.ts
**/*.{js,ts,jsx,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{js,ts,jsx,tsx}: Use descriptive names for functions, variables, and classes that clearly convey their purpose
Write comments that explain the 'why' behind code decisions, not the 'what'
Keep functions small and focused on a single responsibility
Use const by default, let when reassignment is needed, and avoid var
Prefer async/await over .then() chains for handling asynchronous operations
Use explicit error handling with try/catch blocks for async operations
Avoid deeply nested code; refactor complex logic into helper functions
Files:
app/definitions/IUser.tsapp/views/UserPreferencesView/index.tsx
app/views/**/*.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
Place screen components in app/views/ directory
Files:
app/views/UserPreferencesView/index.tsx
🔇 Additional comments (2)
app/definitions/IUser.ts (1)
115-115: Type addition is clean and correctly scoped.
enableMobileRinging?: booleaninINotificationPreferencesis a good extension point for the new preference flow.app/views/UserPreferencesView/index.tsx (1)
138-153: Version gating is correctly implemented for the new preference UI.Rendering the row only for
serverVersion >= 6.10.0matches the PR objective and avoids exposing unsupported settings.
diegolmello
force-pushed
the
feat.voip-lib-new
branch
from
2143aba to
2a098f7
Compare
diegolmello
force-pushed
the
chore/enable-mobile-ringing
branch
from
8f0bec8 to
c979bae
Compare
diegolmello
had a problem deploying
to
approve_e2e_testing
GitHub Actions
Error
diegolmello
force-pushed
the
chore/enable-mobile-ringing
branch
from
c979bae to
7ba5863
Compare
diegolmello
had a problem deploying
to
approve_e2e_testing
GitHub Actions
Error
diegolmello
had a problem deploying
to
official_android_build
GitHub Actions
Error
diegolmello
had a problem deploying
to
official_ios_build
GitHub Actions
Error
diegolmello
had a problem deploying
to
experimental_ios_build
GitHub Actions
Error
diegolmello
had a problem deploying
to
experimental_android_build
GitHub Actions
Error
diegolmello
force-pushed
the
chore/enable-mobile-ringing
branch
from
7ba5863 to
a5c120a
Compare
diegolmello
had a problem deploying
to
approve_e2e_testing
GitHub Actions
Error
diegolmello
force-pushed
the
chore/enable-mobile-ringing
branch
from
17b0714 to
62a05b0
Compare
diegolmello
had a problem deploying
to
approve_e2e_testing
GitHub Actions
Failure
diegolmello
added a commit
that referenced
this pull request
Apr 22, 2026
…/Decline (#7215) * merge feat.voip-lib * feat(voip): enhance call handling with UUID mapping and event listeners * Base call UI * feat(voip): integrate Zustand for call state management and enhance CallView UI * feat(voip): add simulateCall function for mock call handling in UI development * refactor(CallView): update button handlers and improve UI responsiveness * Add pause-shape-unfilled icon * Base CallHeader * toggleFocus * collapse buttons * Header components * Hide header when no call * Timer * Add use memo * Add voice call item on sidebar * cleanup * Temp use @rocket.chat/media-signaling from .tgz * cleanup * Check module and permissions to enable voip * Refactor stop method to use optional chaining for media signal listeners * voip push first test * Add VoIP call handling with pending call management - Implemented VoIP push notification handling in index.js, including storing call info for later processing. - Added CallKeep event handlers for answering and ending calls from a cold start. - Introduced a new CallIdUUID module to convert call IDs to deterministic UUIDs for compatibility with CallKit. - Created a pending call store to manage incoming calls when the app is not fully initialized. - Updated deep linking actions to include VoIP call handling. - Enhanced MediaSessionInstance to process pending calls and manage call states effectively. * Remove pending store and create getInitialEvents on app/index * Attempt to make iOS calls work from cold state * lint and format * Patch callkeep ios * Temp send iOS voip push token on gcm * Temp fix require cycle * chore: format code and fix lint issues [skip ci] * CallIDUUID module on android and voip push * Add setCallUUID on useCallStore to persist calls accepted on native Android * remove callkeep from notification * Android Incoming Call UI POC * Refactor VoIP handling: Migrate VoIP-related classes to a new package structure, removing deprecated modules and consolidating functionality. Update imports in MainApplication and NotificationIntentHandler to reflect changes. This cleanup enhances code organization and prepares for future VoIP feature enhancements. * Remove VoipForegroundService * cleanup and use caller instead of callerName * Cleanup and make iOS build again * Refactor VoIP handling: Remove unused event emissions for call answered and declined, switch from SharedPreferences to in-memory storage for pending VoIP call data, and update method signatures for better clarity. This cleanup enhances performance and prepares for future VoIP feature improvements. * Refactor VoIP handling: Introduce a new VoipPayload class to encapsulate call data, streamline notification processing, and enhance method signatures across the VoIP module. This update improves code clarity and prepares for future feature enhancements. * Migrate react-native-voip-push-notifications to VoipModule * Refactor VoIP module: Update package structure by moving VoipTurboPackage to the main package and removing the obsolete NativeVoipSpec class. Adjust imports in MainApplication and VoipModule to reflect these changes, enhancing code organization and maintainability. * Unify emitters * Move CallKeep listeners from MediaSessionInstance to getInitialEvents * Clear callkeep on endcall * Unify getInitialEvents logic * getInitialEvents -> MediaCallEvents * chore: format code and fix lint issues [skip ci] * feat(Android): Add full screen incoming call (#6977) * feat: Update call UI (#6990) * feat: Handle audio routing, e.g., Bluetooth headset vs. internal speaker switching (#6992) * fix: empty space when not on call (#6993) * feat: Dialpad (#7000) * action: organized translations * feat: start call (#7024) * chore: format code and fix lint issues * feat: Pre flight (#7038) * action: organized translations * feat: Receive voip push notifications from backend (#7045) * feat: Refactor media session handling and improve disconnect logic (#7065) * feat: Control incoming call from native (#7066) * feat: Voice message blocks (#7057) * feat: native accept success event (#7068) * feat(voip): call waiting, busy detection, and videoconf blocking (#7077) * action: organized translations * feat(voip): tap-to-hide call controls with animations (#7078) * feat(voip): navigate to call DM from message button and header (#7082) * feat(voip): tablet and landscape layout (#7110) * chore: develop into feat.voip-lib-new (RN 81 + Expo 54 + reanimated 4 + true-sheet + iOS 26) (#7114) * chore: format code and fix lint issues * feat(voip): android landscape layout for IncomingCallActivity (#7116) * Update agents files * feat(voip): Support a11y (#7106) * Fix content cutting on iOS on some edge cases * pods * Ignore .worktrees on jest * chore: Merge develop into feat.voip-lib-new (#7129) * fix(voip): show CallKit UI when call is active in background (#7128) * chore: Update media-signaling to 0.2.0 (#7153) * feat(voip): migrate iOS accept/reject from DDP to REST (#7124) * Fix icons * feat(voip): migrate Android accept/reject from DDP to REST (#7127) * test(voip): integration tests for CallView pipeline (#7161) * feat(voip): display video conf provider as subtitle (#7160) * fix(voip): CallView button grid and correct landscape/dialpad layouts (#7164) * fix(voip): prevent stale MMKV cache on Android first-install accept MMKVKeyManager.initialize ran in MainApplication.onCreate before the JS engine started and opened the default MMKV file via the Tencent 1.2 JAR when it was still empty. Tencent caches instances per-ID in a singleton registry, so that empty-state view was held for the rest of the process. JS later wrote credentials through react-native-mmkv (MMKV Core 2.0), which has its own separate registry. When a VoIP push arrived, Ejson.getMMKV() got the cached empty Tencent instance and reported "No userId found in MMKV for server". Closing and reopening the app cleared the cache, which is why only the very first call after install failed. Drop the open/verify block — the encryption key is already cached from SecureKeystore, so no MMKV handle is needed here. The first Tencent instance is now created inside Ejson.getMMKV() after JS has written, so it scans the file fresh. * fix(voip): prevent duplicate ringtone on Android incoming call (#7158) * fix(voip): set explicit snaps for NewMediaCall bottom sheet (#7165) * Update app/lib/services/voip/MediaSessionStore.ts Co-authored-by: Pierre Lehnen <55164754+pierre-lehnen-rc@users.noreply.github.com> * fix: make startVoipFork reactive to permissions-changed (#7151) * fix(android): remove MediaProjectionService from merged manifest (#7190) * fix(voip): Phone account creation (#7170) * feat: add Enable Mobile Ringing toggle in user preferences (#7155) * fix(voip): ship blockers for PushKit, licensing, outbound calls, push tokens (#7167) * fix(android): Play Store mic discoverability, safer FCM logs, avatar auth via headers (#7171) * fix(ios): serialize VoipService bridge statics (#7169) * fix(voip): Android DDP thread safety and VoipPayload bundle parity (#7168) * chore(voip): dead-code and hygiene sweep (#7174) * refactor(voip): decouple navigateToCallRoom from Redux and backfill REST/connect tests (#7176) * test(voip): tighten ringing endCall assertion and add VideoConf VoIP-lock saga coverage (#7177) * fix(ios): harden VoIP DDP WebSocket client on receive failures and TLS (#7173) * refactor(voip): MediaCallEvents Redux adapters and resetVoipState (#7178) * refactor(voip): decouple peer autocomplete from Redux; simplify NewMediaCall (#7175) * fix(ios): add NS_SWIFT_NAME to Challenge.runChallenge for Swift 6.2 compatibility Swift 6.2 (Xcode 26.x / macos-26 runner) auto-renames the Objective-C method runChallenge:didReceiveChallenge:completionHandler: to run(_:didReceive:completionHandler:) when imported into Swift. Add NS_SWIFT_NAME to explicitly pin the Swift import name, preventing the compiler from applying its heuristics. This keeps the existing Swift call site in DDPClient.swift working without changes. * fix(ios): cancel old URLSession/webSocketTask before reconnecting in DDPClient.connect (#7197) * fix(ios): add NSLock to nativeAcceptHandledCallIds and 10s REST timeout to handleNativeAccept (#7198) * feat(android): create VoipCallService with FOREGROUND_SERVICE_MICROPHONE (#7199) * fix(android): start VoipCallService on accept, stop on hangup/timeout, install end-call listener (#7200) * fix(voip): enable DM nav for users with SIP extension (#7203) * fix(android): handle null VoiceConnection in answerIncomingCall, notify JS (#7201) * fix(voip): resolve closure capture ordering in handleNativeAccept (#7209) * fix(android): integrate VoIP modules with SSL-pinned OkHttpClient (#7208) * fix(push): gate id and voipToken behind server version checks, fix VideoConf caller extra (#7210) * fix(voip): remove sensitive data from production logs (#7207) * fix(android): remove isRunning guard + add double-tap guard on Accept/Decline - VoipCallService: remove if (!isRunning) guard, call startForeground unconditionally (idempotent on Android, fixes Android 14+ foreground service requirement) - IncomingCallActivity: add AtomicBoolean guard on handleAccept/handleDecline to prevent double-tap from triggering multiple service starts --------- Co-authored-by: diegolmello <diegolmello@users.noreply.github.com> Co-authored-by: Pierre Lehnen <55164754+pierre-lehnen-rc@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adds an Enable Mobile Ringing toggle to
UserPreferencesView, matching the web client. When enabled, incoming video conference calls ring the device like a phone call. Server-side enterprise kill switch (VideoConf_Mobile_Ringing) is enforced silently by the server; no client-side check needed for MVP.INotificationPreferences: adds optionalenableMobileRinging?: booleanUserPreferencesView: adds version-gated (server >= 6.10.0)Switchwired tosaveUserPreferences()+dispatch(setUser(...)), following the existingconvertAsciiEmojipatternen.json: addsEnable_Mobile_RingingkeyIssue(s)
https://rocketchat.atlassian.net/browse/VMUX-72
How to test or reproduce
users.setPreferencesis called withenableMobileRinging: <value>.Screenshots
N/A
Types of changes
Checklist
Further comments
Targets
feat.voip-lib-new(notdevelop) since this stacks on the VoIP feature branch. MVP scope per ~/plans/enable-mobile-ringing/plan.md — no enterprise kill switch check (server enforces silently), no test additions (deferred).Summary by CodeRabbit