fix(voip): resolve closure capture ordering in handleNativeAccept

[diegolmello]

Proposed changes

Fixes two issues in handleNativeAccept:

1. Swift compiler error: Resolves "Closure captures 'finishAccept' before it is declared" by reordering finishAccept declaration before timeoutWorkItem.
2. Cold-start accept failures: Ensures iOS correctly reports accept failures when the app is not running at call accept time. Without this fix, cold-started apps misclassify accept failures as unanswered incoming calls.

Issue(s)

N/A

How to test or reproduce

1. Start a VoIP call to a user
2. Accept the call on iOS while the app is in the background or killed
3. Simulate REST failure (e.g. network timeout or server error)
4. Launch the app — verify the accept failure is correctly reported instead of being treated as a missed incoming call

Screenshots

N/A

Types of changes

• Bugfix (non-breaking change which fixes an issue)

Checklist

• I have read the CONTRIBUTING doc
• I have signed the CLA
• Lint and unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works (if applicable)
• I have added necessary documentation (if applicable)
• Any dependent changes have been merged and published in downstream modules

Further comments

N/A

[coderabbitai]

Walkthrough

Refactored VoipService accept flow: unified the 10s timeout handling into a single finishAccept(success:) closure guarded by finishAcceptInvoked to prevent double invocation; timeout work item no longer attempts cross-cancellation. Failure notifications now post failedPayload.toDictionary() instead of a manually assembled userInfo dictionary.

Changes

Cohort / File(s)	Summary
VoipService Timeout and Notification Refactor ios/Libraries/VoipService.swift	Replaced separate cancellation/DispatchWorkItem race pattern with a single guarded finishAccept(success:) closure and finishAcceptInvoked flag for 10s timeout handling. Failure notification now posts failedPayload.toDictionary() instead of constructing a manual VoipAcceptFailed userInfo dictionary. Success path unchanged.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested labels

type: bug

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly addresses the main change: a closure capture ordering fix in handleNativeAccept. It is specific, concise, and accurately reflects the core issue being resolved.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

ios/Libraries/VoipService.swift (1)

461-508: ⚠️ Potential issue | 🟠 Major

Remove weak captures to preserve payload lifecycle and observe completion state.

payload is deallocated after handleNativeAccept returns, but finishAccept is called asynchronously from the timeout handler (10+ seconds later) and the API response callback. With [weak payload], the guard fails on deallocation, silently skipping cleanup and notifications. Also, [finishAcceptInvoked] snapshots the initial value false, so the timeout handler never observes the completion flag being set to true, defeating the guard's intent.

Proposed fix

-        let finishAccept: (Bool) -> Void = { [weak payload] success in
+        let finishAccept: (Bool) -> Void = { success in
             guard !finishAcceptInvoked else { return }
             finishAcceptInvoked = true
-            guard let payload else { return }
             stopDDPClientInternal(callId: payload.callId)
             if success {
                 storeInitialEvents(payload)
@@
-        let timeoutWorkItem = DispatchWorkItem { [weak payload, finishAcceptInvoked] in
-            guard let payload else { return }
+        let timeoutWorkItem = DispatchWorkItem {
             guard !finishAcceptInvoked else { return }
             // Check the callId is still tracked (not already cleaned up).
             nativeAcceptLock.lock()

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@ios/Libraries/VoipService.swift` around lines 461 - 508, The closures
finishAccept and the DispatchWorkItem timeoutWorkItem currently capture payload
weakly and snapshot finishAcceptInvoked, causing payload to be deallocated and
the completion flag to not be observed; remove the explicit capture lists (i.e.,
drop “[weak payload]” from finishAccept and “[weak payload,
finishAcceptInvoked]” from timeoutWorkItem) so payload is captured normally and
finishAcceptInvoked is referenced by closure (not captured by value), and if you
need to avoid retain cycles capture only self weakly (not payload) — update the
closures in VoipService.swift where finishAccept, stopDDPClientInternal,
clearNativeAcceptDedupe, nativeAcceptLock, nativeAcceptHandledCallIds and the
DispatchWorkItem are defined.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@ios/Libraries/VoipService.swift`:
- Around line 461-508: The closures finishAccept and the DispatchWorkItem
timeoutWorkItem currently capture payload weakly and snapshot
finishAcceptInvoked, causing payload to be deallocated and the completion flag
to not be observed; remove the explicit capture lists (i.e., drop “[weak
payload]” from finishAccept and “[weak payload, finishAcceptInvoked]” from
timeoutWorkItem) so payload is captured normally and finishAcceptInvoked is
referenced by closure (not captured by value), and if you need to avoid retain
cycles capture only self weakly (not payload) — update the closures in
VoipService.swift where finishAccept, stopDDPClientInternal,
clearNativeAcceptDedupe, nativeAcceptLock, nativeAcceptHandledCallIds and the
DispatchWorkItem are defined.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 88ba80b7-f6e4-4405-82d8-fd407d06c659

📥 Commits

Reviewing files that changed from the base of the PR and between 7301db6 and 0ce408b.

📒 Files selected for processing (1)

• ios/Libraries/VoipService.swift

📜 Review details

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: ESLint and Test / run-eslint-and-test

🧰 Additional context used

🧠 Learnings (2)

📓 Common learnings

Learnt from: CR
Repo: RocketChat/Rocket.Chat.ReactNative PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-04-07T17:49:17.538Z
Learning: Applies to app/lib/services/voip/**/*.{ts,tsx} : Implement VoIP with WebRTC peer-to-peer audio calls in app/lib/services/voip/ using Zustand stores instead of Redux, with native CallKit (iOS) and Telecom (Android) integration; keep VoIP and VideoConf separate

📚 Learning: 2026-04-07T17:49:17.538Z

Learnt from: CR
Repo: RocketChat/Rocket.Chat.ReactNative PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-04-07T17:49:17.538Z
Learning: Applies to app/lib/services/voip/**/*.{ts,tsx} : Implement VoIP with WebRTC peer-to-peer audio calls in app/lib/services/voip/ using Zustand stores instead of Redux, with native CallKit (iOS) and Telecom (Android) integration; keep VoIP and VideoConf separate

Applied to files:

• ios/Libraries/VoipService.swift

[github-actions]

iOS Build Available

Rocket.Chat Experimental 4.72.0.108588