fix(voip): remove sensitive data from production logs

[diegolmello]

Summary

Defense-in-depth for VoIP secure logging. Complements the existing babel transform that strips console.log in production by removing sensitive data at the source level in both JS and Android native code.

Changes

JS/TS — console.log removal (source-level):

• MediaSessionInstance.ts: Removed all console.log calls and the // TODO: Show error message? comment
• MediaSessionStore.ts: Removed console.log('[VoIP] Mobile device ID:', mobileDeviceId)

Android Kotlin — BuildConfig.DEBUG gating:

• DDPClient.kt: All sensitive Log.d calls (wsUrl, connection, login, subscribe, method calls) gated behind if (BuildConfig.DEBUG)
• VoipNotification.kt: ~30 sensitive logs (DDP listener, callId, host, WebSocket messages) gated
• VoipModule.kt: addListener/removeListeners event name logs gated
• VoipCallService.kt: Service lifecycle logs gated
• IncomingCallActivity.kt: Activity creation/call accepted/declined logs gated

Android Kotlin — response body removal:

• MediaCallsAnswerRequest.kt: Removed HTTP response body logging (lines 125, 127) that could expose session tokens/crypto material

Sensitive data removed from production logs

• callId (call identifiers)
• Host URLs and wsUrl (WebSocket URLs)
• Device IDs (ANDROID_ID)
• WebSocket message content (DDP messages)
• HTTP response bodies (answer request responses)

Preserved for production support

• All Log.e (error logs needed for debugging)
• All console.error in JS
• Operational logs (notification lifecycle, TelecomManager failures, security exceptions, unknown action warnings)

Merge Order

Part of the VoIP secure logs cleanup. No dependencies.

Test plan

• TZ=UTC yarn test -- --testPathPattern='app/lib/services/voip/MediaSession' passes
• yarn lint passes
• Android unit tests pass (./gradlew :app:testDebugUnitTest --tests "chat.rocket.reactnative.voip.*")

Summary by CodeRabbit

• Chores
  • Reduced verbose debug logging across VoIP call and notification flows; debug messages now only appear in debug builds or were removed to cut noise. No functional changes to call behavior, UI, or call lifecycle.

[coderabbitai]

Walkthrough

Reduced debug logging across VoIP code: removed or gated many console/Log.d statements in TypeScript and Android files, renamed an unused callback parameter to _oldState. No control flow, public APIs, or functional behavior were changed.

Changes

Cohort / File(s)	Summary
VoIP service (TS) app/lib/services/voip/MediaSessionInstance.ts, app/lib/services/voip/MediaSessionStore.ts	Removed multiple console.log debug statements related to DDP media signals, call lifecycle, and device IDs. Renamed unused oldState parameter to _oldState and left handler empty.
Android: DDP & call lifecycle logging android/app/src/main/java/chat/rocket/reactnative/voip/DDPClient.kt, android/app/src/main/java/chat/rocket/reactnative/voip/IncomingCallActivity.kt	Wrapped debug Log.d calls with if (BuildConfig.DEBUG) to restrict debug output to debug builds; added BuildConfig imports. Error logs unchanged.
Android: HTTP response logging android/app/src/main/java/chat/rocket/reactnative/voip/MediaCallsAnswerRequest.kt	Removed response-status logging; retained success determination (code in 200..299) and result posting.
Android: VoIP module & service logging android/app/src/main/java/chat/rocket/reactnative/voip/VoipCallService.kt, android/app/src/main/java/chat/rocket/reactnative/voip/VoipModule.kt, android/app/src/main/java/chat/rocket/reactnative/voip/VoipNotification.kt	Gated many debug/info Log.d/Log.w statements behind BuildConfig.DEBUG; added imports. Functional behavior, notifications, and non-debug logs left intact.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested labels

type: chore

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix(voip): remove sensitive data from production logs' accurately summarizes the main objective of the changeset—removing sensitive information from logs across both JS/TS and Android code.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)

• LOGS-6918: Request failed with status code 401

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

app/lib/services/voip/MediaSessionInstance.ts (1)

116-118: Consider removing the empty event handler if not required.

The stateChange event handler is now empty after removing the sensitive logging. While the underscore prefix for the unused parameter follows convention, if this handler serves no purpose, consider removing the entire call.emitter.on('stateChange', ...) registration to reduce unnecessary overhead.

If the handler must remain registered (e.g., to prevent warnings or errors from the event system), the current implementation is correct.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@app/lib/services/voip/MediaSessionInstance.ts` around lines 116 - 118, The
empty stateChange handler on call.emitter in MediaSessionInstance adds
unnecessary overhead; remove the entire call.emitter.on('stateChange', _oldState
=> { ... }) registration unless the event must be subscribed to (e.g., to avoid
runtime warnings). If you must keep it, leave it as-is; otherwise delete the
call.emitter.on('stateChange', ...) line to stop registering a no-op listener.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@app/lib/services/voip/MediaSessionInstance.ts`:
- Around line 116-118: The empty stateChange handler on call.emitter in
MediaSessionInstance adds unnecessary overhead; remove the entire
call.emitter.on('stateChange', _oldState => { ... }) registration unless the
event must be subscribed to (e.g., to avoid runtime warnings). If you must keep
it, leave it as-is; otherwise delete the call.emitter.on('stateChange', ...)
line to stop registering a no-op listener.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7a6c4317-dec1-4b26-9352-6ae96cd8fa51

📥 Commits

Reviewing files that changed from the base of the PR and between 7301db6 and ed36940.

📒 Files selected for processing (2)

• app/lib/services/voip/MediaSessionInstance.ts
• app/lib/services/voip/MediaSessionStore.ts

💤 Files with no reviewable changes (1)

• app/lib/services/voip/MediaSessionStore.ts

📜 Review details

🧰 Additional context used

📓 Path-based instructions (5)

**/*.{js,jsx,ts,tsx,json}

📄 CodeRabbit inference engine (CLAUDE.md)

Configure Prettier with tabs, single quotes, 130 character width, no trailing commas, arrow parens avoid, and bracket same line

Files:

• app/lib/services/voip/MediaSessionInstance.ts

**/*.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (CLAUDE.md)

Use ESLint with @rocket.chat/eslint-config base configuration including React, React Native, TypeScript, and Jest plugins

Files:

• app/lib/services/voip/MediaSessionInstance.ts

**/*.{ts,tsx}

📄 CodeRabbit inference engine (CLAUDE.md)

Use TypeScript with strict mode enabled and configure baseUrl to app/ for import resolution

**/*.{ts,tsx}: Use TypeScript for type safety; add explicit type annotations to function parameters and return types
Prefer interfaces over type aliases for defining object shapes in TypeScript
Use enums for sets of related constants rather than magic strings or numbers

Files:

• app/lib/services/voip/MediaSessionInstance.ts

app/lib/services/voip/**/*.{ts,tsx}

📄 CodeRabbit inference engine (CLAUDE.md)

Implement VoIP with WebRTC peer-to-peer audio calls in app/lib/services/voip/ using Zustand stores instead of Redux, with native CallKit (iOS) and Telecom (Android) integration; keep VoIP and VideoConf separate

Files:

• app/lib/services/voip/MediaSessionInstance.ts

**/*.{js,ts,jsx,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.{js,ts,jsx,tsx}: Use descriptive names for functions, variables, and classes that clearly convey their purpose
Write comments that explain the 'why' behind code decisions, not the 'what'
Keep functions small and focused on a single responsibility
Use const by default, let when reassignment is needed, and avoid var
Prefer async/await over .then() chains for handling asynchronous operations
Use explicit error handling with try/catch blocks for async operations
Avoid deeply nested code; refactor complex logic into helper functions

Files:

• app/lib/services/voip/MediaSessionInstance.ts

🧠 Learnings (3)

📓 Common learnings

Learnt from: CR
Repo: RocketChat/Rocket.Chat.ReactNative PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-04-07T17:49:17.538Z
Learning: Applies to app/lib/services/voip/**/*.{ts,tsx} : Implement VoIP with WebRTC peer-to-peer audio calls in app/lib/services/voip/ using Zustand stores instead of Redux, with native CallKit (iOS) and Telecom (Android) integration; keep VoIP and VideoConf separate

Learnt from: CR
Repo: RocketChat/Rocket.Chat.ReactNative PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-04-07T17:49:17.538Z
Learning: Applies to @(app/sagas/videoConf.ts|app/lib/methods/videoConf.ts) : Manage video conferencing via Redux actions/reducers/sagas in app/sagas/videoConf.ts and app/lib/methods/videoConf.ts using server-managed Jitsi integration; do not conflate with VoIP

📚 Learning: 2026-04-07T17:49:17.538Z

Learnt from: CR
Repo: RocketChat/Rocket.Chat.ReactNative PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-04-07T17:49:17.538Z
Learning: Applies to app/lib/services/voip/**/*.{ts,tsx} : Implement VoIP with WebRTC peer-to-peer audio calls in app/lib/services/voip/ using Zustand stores instead of Redux, with native CallKit (iOS) and Telecom (Android) integration; keep VoIP and VideoConf separate

Applied to files:

• app/lib/services/voip/MediaSessionInstance.ts

📚 Learning: 2026-04-07T17:49:17.538Z

Learnt from: CR
Repo: RocketChat/Rocket.Chat.ReactNative PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-04-07T17:49:17.538Z
Learning: Applies to @(app/sagas/videoConf.ts|app/lib/methods/videoConf.ts) : Manage video conferencing via Redux actions/reducers/sagas in app/sagas/videoConf.ts and app/lib/methods/videoConf.ts using server-managed Jitsi integration; do not conflate with VoIP

Applied to files:

• app/lib/services/voip/MediaSessionInstance.ts

🔇 Additional comments (1)

app/lib/services/voip/MediaSessionInstance.ts (1)

1-257: Security improvements successfully implemented.

The removal of sensitive console.log statements while preserving console.error and console.warn calls aligns perfectly with the PR's defense-in-depth approach for VoIP secure logging. The changes protect sensitive data (callId, state transitions, DDP message content) from production logs while maintaining essential error reporting for production support.

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

android/app/src/main/java/chat/rocket/reactnative/voip/MediaCallsAnswerRequest.kt (1)

95-97: ⚠️ Potential issue | 🟠 Major

Remove remaining sensitive values from production logs.

Line 96 still logs host, and Line 116 still logs callId; both are listed as sensitive by the PR objective. Also consider avoiding e.message here because networking exceptions can include endpoint details.

🔒 Proposed log sanitization

-            Log.w(TAG, "Missing credentials for $host — cannot send media-call answer")
+            Log.w(TAG, "Missing credentials — cannot send media-call answer")
...
-                Log.e(TAG, "MediaCallsAnswerRequest failed for callId=$callId: ${e.message}")
+                Log.e(TAG, "MediaCallsAnswerRequest failed: ${e.javaClass.simpleName}")

Also applies to: 115-117

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In
`@android/app/src/main/java/chat/rocket/reactnative/voip/MediaCallsAnswerRequest.kt`
around lines 95 - 97, In MediaCallsAnswerRequest, remove sensitive values from
logs: stop logging the host and callId variables in Log.w/Log.e calls (replace
with generic messages like "Missing credentials" or "Failed to send media-call
answer") and avoid printing exception messages that may contain endpoint details
(do not use e.message); instead log a non-sensitive error note or use
e.toString()/log exception type without payload if needed. Update the checks and
catch blocks referencing host and callId to use the class/method names
(MediaCallsAnswerRequest / onResult callback) in the messages so logs remain
informative but contain no host/callId or raw exception message.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In
`@android/app/src/main/java/chat/rocket/reactnative/voip/MediaCallsAnswerRequest.kt`:
- Around line 95-97: In MediaCallsAnswerRequest, remove sensitive values from
logs: stop logging the host and callId variables in Log.w/Log.e calls (replace
with generic messages like "Missing credentials" or "Failed to send media-call
answer") and avoid printing exception messages that may contain endpoint details
(do not use e.message); instead log a non-sensitive error note or use
e.toString()/log exception type without payload if needed. Update the checks and
catch blocks referencing host and callId to use the class/method names
(MediaCallsAnswerRequest / onResult callback) in the messages so logs remain
informative but contain no host/callId or raw exception message.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 92490959-89d1-4826-943d-d67749fc34bf

📥 Commits

Reviewing files that changed from the base of the PR and between ed36940 and f546e8d.

📒 Files selected for processing (6)

• android/app/src/main/java/chat/rocket/reactnative/voip/DDPClient.kt
• android/app/src/main/java/chat/rocket/reactnative/voip/IncomingCallActivity.kt
• android/app/src/main/java/chat/rocket/reactnative/voip/MediaCallsAnswerRequest.kt
• android/app/src/main/java/chat/rocket/reactnative/voip/VoipCallService.kt
• android/app/src/main/java/chat/rocket/reactnative/voip/VoipModule.kt
• android/app/src/main/java/chat/rocket/reactnative/voip/VoipNotification.kt

✅ Files skipped from review due to trivial changes (1)

• android/app/src/main/java/chat/rocket/reactnative/voip/IncomingCallActivity.kt

📜 Review details

🧰 Additional context used

🧠 Learnings (4)

📓 Common learnings

Learnt from: CR
Repo: RocketChat/Rocket.Chat.ReactNative PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-04-07T17:49:17.538Z
Learning: Applies to app/lib/services/voip/**/*.{ts,tsx} : Implement VoIP with WebRTC peer-to-peer audio calls in app/lib/services/voip/ using Zustand stores instead of Redux, with native CallKit (iOS) and Telecom (Android) integration; keep VoIP and VideoConf separate

📚 Learning: 2026-04-07T17:49:17.538Z

Learnt from: CR
Repo: RocketChat/Rocket.Chat.ReactNative PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-04-07T17:49:17.538Z
Learning: Applies to app/lib/services/voip/**/*.{ts,tsx} : Implement VoIP with WebRTC peer-to-peer audio calls in app/lib/services/voip/ using Zustand stores instead of Redux, with native CallKit (iOS) and Telecom (Android) integration; keep VoIP and VideoConf separate

Applied to files:

• android/app/src/main/java/chat/rocket/reactnative/voip/VoipCallService.kt
• android/app/src/main/java/chat/rocket/reactnative/voip/VoipNotification.kt

📚 Learning: 2026-03-31T11:59:31.061Z

Learnt from: Rohit3523
Repo: RocketChat/Rocket.Chat.ReactNative PR: 6875
File: android/build.gradle:3-8
Timestamp: 2026-03-31T11:59:31.061Z
Learning: In the RocketChat/Rocket.Chat.ReactNative repository, the React Native upgrade helper (https://react-native-community.github.io/upgrade-helper/?from=0.79.4&to=0.81.5) recommends kotlinVersion = "2.1.20", compileSdkVersion = 36, targetSdkVersion = 36, and buildToolsVersion = "36.0.0" in android/build.gradle for the RN 0.79.4 → 0.81.5 upgrade. These are the sanctioned values for this upgrade path and should not be flagged as compatibility concerns.

Applied to files:

• android/app/src/main/java/chat/rocket/reactnative/voip/VoipModule.kt
• android/app/src/main/java/chat/rocket/reactnative/voip/DDPClient.kt

📚 Learning: 2026-02-05T13:55:06.688Z

Learnt from: Rohit3523
Repo: RocketChat/Rocket.Chat.ReactNative PR: 6930
File: package.json:101-101
Timestamp: 2026-02-05T13:55:06.688Z
Learning: The RocketChat/Rocket.Chat.ReactNative repository uses a fork of react-native-image-crop-picker (RocketChat/react-native-image-crop-picker) with custom Android edge-to-edge fixes, not the upstream ivpusic/react-native-image-crop-picker package. Dependencies should reference commit pins from the RocketChat fork.

Applied to files:

• android/app/src/main/java/chat/rocket/reactnative/voip/VoipModule.kt

🔇 Additional comments (5)

android/app/src/main/java/chat/rocket/reactnative/voip/MediaCallsAnswerRequest.kt (1)

120-124: LGTM: response body logging is removed.

The response handler now derives success from the status code only and avoids logging the HTTP response body.

android/app/src/main/java/chat/rocket/reactnative/voip/VoipCallService.kt (1)

74-109: LGTM — callId is properly suppressed in release builds.

Both callId-carrying Log.d sites are gated behind BuildConfig.DEBUG, and the remaining ungated logs ("Service already running…", lifecycle onCreate/onDestroy, Log.w unknown action) carry no sensitive data. Consistent with the PR's defense-in-depth goal.

android/app/src/main/java/chat/rocket/reactnative/voip/VoipModule.kt (1)

107-161: LGTM.

callId in the expired-event log is now suppressed in release builds, matching the PR's sensitive-data goal. The remaining ungated Log.d calls (clearInitialEventsInternal, registerVoipToken, stopNativeDDPClient, removeListeners) carry no PII, which is consistent.

android/app/src/main/java/chat/rocket/reactnative/voip/DDPClient.kt (1)

54-181: LGTM — all sensitive DDP debug logs gated.

wsUrl (host), subscription names, and handshake milestones are now debug-only; Log.e paths (including onFailure's t.message, Login failed, Failed to subscribe, Method … failed, Connect timeout) are preserved for production triage. Good balance between privacy and supportability.

android/app/src/main/java/chat/rocket/reactnative/voip/VoipNotification.kt (1)

99-955: LGTM — comprehensive gating across timeout, accept/decline, DDP, and notification paths.

Sensitive values (callId, caller, host, extras keys, raw DDP messages via Log.d(TAG, "DDP received message: $message")) are all now debug-only, while Log.e error paths and the operational Log.w for unsupported payload types / full-screen intent fallback remain in production as intended.

One minor note for awareness (no change requested): registerCallWithTelecomManager's Log.e at line 752 includes callId/caller in the error string. This is preserved per PR scope ("All Log.e error logs remain unchanged") and is useful for triaging rejected payloads, but if caller can be a phone number / PII it's worth a follow-up to redact in a later pass.