Skip to content

Upgrade elastix from C++11 to C++14#513

Merged
N-Dekker merged 2 commits intodevelopfrom
Upgrade-C++11-to-C++14
Aug 27, 2021
Merged

Upgrade elastix from C++11 to C++14#513
N-Dekker merged 2 commits intodevelopfrom
Upgrade-C++11-to-C++14

Conversation

@N-Dekker
Copy link
Copy Markdown
Member

@N-Dekker N-Dekker commented Aug 26, 2021

C++14 is a small extension over C++11, featuring mainly bug fixes and small improvements: https://en.wikipedia.org/wiki/C%2B%2B14

This pull request follows ITK pull request InsightSoftwareConsortium/ITK#2563 commit InsightSoftwareConsortium/ITK@daec0fd "ENH: Upgrade ITK from C++11 to C++14" (1 June 2021).

Follow-up to pull request #123 commit b84ab47 "ENH: Explicitly set CMAKE_CXX_STANDARD to 11", by Kasper Marstal (@kaspermarstal), 8 March 2019

Started using C++14 std::make_unique.

C++14 is a small extension over C++11, featuring mainly bug fixes and small improvements: https://en.wikipedia.org/wiki/C%2B%2B14

This commit follows ITK pull request InsightSoftwareConsortium/ITK#2563 commit InsightSoftwareConsortium/ITK@daec0fd "ENH: Upgrade ITK from C++11 to C++14" (1 June 2021).

Follow-up to pull request #123 commit b84ab47 "ENH: Explicitly set CMAKE_CXX_STANDARD to 11", by Kasper Marstal, 8 March 2019
@mstaring
Copy link
Copy Markdown
Member

lgtm

According to Clang-Tidy modernize-make-unique:
https://clang.llvm.org/extra/clang-tidy/checks/modernize-make-unique.html

C++ Core Guidelines, August 19, 2021, R.23: Use make_unique() to make unique_ptrs
http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rr-make_unique

Following ITK pull request InsightSoftwareConsortium/ITK#2574 commit InsightSoftwareConsortium/ITK@22bce72 (4 June 2021)
@N-Dekker N-Dekker force-pushed the Upgrade-C++11-to-C++14 branch from 64f4e52 to be1c21c Compare August 26, 2021 21:22
@N-Dekker N-Dekker merged commit e6427d9 into develop Aug 27, 2021
@N-Dekker N-Dekker deleted the Upgrade-C++11-to-C++14 branch August 27, 2021 06:58
N-Dekker added a commit that referenced this pull request Mar 24, 2023
Following ITK pull request InsightSoftwareConsortium/ITK#3969 "ENH: Upgrade ITK from C++14 to C++17"

Follow-up to pull request #513 commit d98d9c0 "ENH: Upgrade elastix from C++11 to C++14".
N-Dekker added a commit that referenced this pull request Apr 2, 2023
Following ITK pull request InsightSoftwareConsortium/ITK#3969 commit InsightSoftwareConsortium/ITK@513507e "ENH: Upgrade ITK from C++14 to C++17"

Follow-up to pull request #513 commit d98d9c0 "ENH: Upgrade elastix from C++11 to C++14".
N-Dekker added a commit that referenced this pull request Apr 3, 2023
Following ITK pull request InsightSoftwareConsortium/ITK#3969 commit InsightSoftwareConsortium/ITK@513507e "ENH: Upgrade ITK from C++14 to C++17"

Follow-up to pull request #513 commit d98d9c0 "ENH: Upgrade elastix from C++11 to C++14".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants