feat: new settings for portal to serve/fetch nav#1117
Closed
wesleyboar wants to merge 1 commit intomainfrom
Closed
feat: new settings for portal to serve/fetch nav#1117wesleyboar wants to merge 1 commit intomainfrom
wesleyboar wants to merge 1 commit intomainfrom
Conversation
## Overview Introduces 2 new settings — * `PORTAL_HOSTS_NAV` * `PORTAL_LOADS_NAV` — to control and distinguish whether portal serves its own nav and/or loads CMS nav. This change permits TUP-UI to serve a portal nav, while not loading CMS nav bits. ## Changes - Updated `urls.py` to include conditions for rendering navigation based on the new settings. - Modified `nav_portal.html` and `nav_portal.raw.html` templates to check for the new settings in addition to the existing `PORTAL_IS_TACC_CORE_PORTAL`. - Added example configurations for the new settings in `settings_local.example.py`. - Set default values for the new settings in `settings.py`. ## Testing 1. Verify that nav elements render correctly based on the new settings. 2. Ensure backward compatibility with existing configurations.
wesleyboar
added a commit
to TACC/tup-ui
that referenced
this pull request
Mar 11, 2026
wesleyboar
added a commit
to TACC/tup-ui
that referenced
this pull request
Mar 11, 2026
Member
Author
|
Closed in favor of TACC/tup-ui#541. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Closed in favor of TACC/tup-ui#541.
Overview
Introduces 2 new settings —
PORTAL_HOSTS_NAVPORTAL_LOADS_NAV— to control and distinguish whether portal serves its own nav and/or loads CMS nav.
This change permits TUP-UI to serve a portal nav, while not loading CMS nav bits.
Related
Changes
urls.pynav_portal.htmlnav_portal.raw.htmlsettings_local.example.pysettings.pyPORTAL_IS_TACC_CORE_PORTALTesting
UI
…