Skip to content

refactor: simplify portal nav#541

Merged
wesleyboar merged 4 commits intomainfrom
refactor/simplify-portal-nav
Mar 11, 2026
Merged

refactor: simplify portal nav#541
wesleyboar merged 4 commits intomainfrom
refactor/simplify-portal-nav

Conversation

@wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Mar 11, 2026

Overview

Simplify Portal nav:

  • from custom app and URL
  • to template overwrite

Related

Changes

  • deletes portal_nav/ app
  • moves nav_portal.raw.html template
  • changes nav_portal.raw.html template to use view logic

Testing

  1. Deploy/Serve.
  2. Log in to portal.
  3. Verify header shows portal nav in logged in state.
    I.e. no "Login" link)

UI

  1. deploy
    1 deploy
  2. log in
    2 log in
  3. portal nav changed
    3 logged in

@wesleyboar wesleyboar marked this pull request as draft March 11, 2026 21:30
@wesleyboar wesleyboar marked this pull request as ready for review March 11, 2026 21:49
@wesleyboar wesleyboar requested a review from jarosenb March 11, 2026 22:14
wesleyboar added a commit to TACC/Core-CMS that referenced this pull request Mar 11, 2026
## Overview

Let client (e.g. [TACC/tup-ui]) access `user` in `nav_portal.html`.

[TACC/tup-ui]: https://github.com/TACC/tup-ui

## Related

This will be required by [TACC/tup-ui] **after** it uses —

- **both**
[TACC/Core-CMS#v4.35.3](https://github.com/TACC/Core-CMS/release/v4.35.3)
(because [#993](#993))
- **and** TACC/tup-ui#541

— and otherwise makes sense for portal nav to access `user`.

## Changes

- **adds** `user` to limited context

## Testing / UI

1. See TACC/tup-ui#541
@wesleyboar wesleyboar mentioned this pull request Mar 11, 2026
@wesleyboar wesleyboar merged commit 74b6036 into main Mar 11, 2026
1 check passed
@wesleyboar wesleyboar deleted the refactor/simplify-portal-nav branch March 11, 2026 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants